From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.erc.general,gmane.emacs.bugs Subject: Re: 28.0.90; duplicate checks in erc--switch-to-buffer Date: Fri, 28 Jan 2022 19:07:43 -0800 Message-ID: <87ee4rutmo.fsf@neverwas.me> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1561"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: bug-gnu-emacs@gnu.org, emacs-erc@gnu.org To: Guy Gastineau Original-X-From: emacs-erc-bounces+sf-erc-help=m.gmane-mx.org@gnu.org Sat Jan 29 04:08:14 2022 Return-path: Envelope-to: sf-erc-help@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDe61-00008g-ET for sf-erc-help@m.gmane-mx.org; Sat, 29 Jan 2022 04:08:13 +0100 Original-Received: from localhost ([::1]:54088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDe5y-0007B2-8N for sf-erc-help@m.gmane-mx.org; Fri, 28 Jan 2022 22:08:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDe5l-0007Au-13 for emacs-erc@gnu.org; Fri, 28 Jan 2022 22:07:57 -0500 Original-Received: from mail-108-mta106.mxroute.com ([136.175.108.106]:37101) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDe5h-0003lW-2e for emacs-erc@gnu.org; Fri, 28 Jan 2022 22:07:56 -0500 Original-Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta106.mxroute.com (ZoneMTA) with ESMTPSA id 17ea3cd960d0005a20.003 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sat, 29 Jan 2022 03:07:46 +0000 X-Zone-Loop: 5b39bd916b0149168d45c526831896098ae7f213202f X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aE64YxVnFXh1USbphdw2LCxxiJcv0tfg0imBmx0cfn8=; b=mhcch2wv5CViQMTwWOa0gj0jha cVfzxuCajMM31JI0KiwViqC34ioDZ7YVefjUtqiVd8Ci7/jvbR2RJJL27RviVA6z7ZpkqyvUwdqm5 xUkmKxWdt49XTlrvzlOGcDZd21OkujJpEwa+wwU+eebeIyRxR1abn+H1UPqIa0bz0E8miAZ7LuA9o cx6RR9Pq2Xj7/iTrsdQgGEunFHSWbFFiiMCs4XWmcl+GgG957g+4ftUJBg1ltaHrFrmqeSo4+6qdv HTQ+c11EhXdyVFFGPdja7McPS1y3rtOpfYUCPwCzbbjZkwWrxIZNnmZmVJpCaJcFAo9rxz/ZboCJJ Hzf/Jp3A==; In-Reply-To: (Guy Gastineau's message of "Fri, 28 Jan 2022 19:10:00 -0500") X-AuthUser: masked@neverwas.me Received-SPF: pass client-ip=136.175.108.106; envelope-from=jp@neverwas.me; helo=mail-108-mta106.mxroute.com X-Spam_score_int: 2 X-Spam_score: 0.2 X-Spam_bar: / X-Spam_report: (0.2 / 5.0 requ) DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-erc@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: General discussion about ERC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-erc-bounces+sf-erc-help=m.gmane-mx.org@gnu.org Original-Sender: "emacs-erc" Xref: news.gmane.io gmane.emacs.erc.general:1706 gmane.emacs.bugs:225501 Archived-At: Hi Guy, Thanks for following through with the report. Guy Gastineau writes: > The entire sexp starting with `with-current-buffer ...` can be removed > without changing the semantics of erc--switch-to-buffer. You're right, of course. In fact, the same commit that introduced `erc--buffer-p' added the redundancy as well [1]. It looks like they saw an opportunity to factor out that predicate and simply forgot to erase the last of what they'd just obsoleted. Are you sure you're not into cloning the repo and saving out a patch? No worries if not. This is great regardless. Thanks again, J.P. [1] https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f925fc93