unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Richard Stallman <rms@gnu.org>
Cc: 55491@debbugs.gnu.org, jdtsmith@gmail.com
Subject: bug#55491: All completion fragments get added to obarray
Date: Fri, 20 May 2022 02:03:23 +0200	[thread overview]
Message-ID: <87ee0p83zo.fsf@gnus.org> (raw)
In-Reply-To: <E1nrS1E-0006pG-9M@fencepost.gnu.org> (Richard Stallman's message of "Wed, 18 May 2022 18:19:48 -0400")

Poking at this some more, this behaviour comes from:

(defun elisp-completion-at-point ()
[...]
           (fun-sym (condition-case nil
                        (save-excursion
                          (up-list -1)
                          (forward-char 1)
                          (and (memq (char-syntax (char-after)) '(?w ?_))
                               (read (current-buffer))))
                      (error nil))))

That `read' there is interning `ohno' when hitting `C-M-i' after:

(ohno

And that's unnecessary -- we don't actually need the fun-sym; we're just
checking whether we're looking at `ignore-error'.  So I've now fixed
this in Emacs 29.

Note that completion in emacs-lisp-mode may still intern stuff, but not
as gratuitously as before. 

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no






  reply	other threads:[~2022-05-20  0:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17 20:22 bug#55491: All completion fragments get added to obarray JD Smith
2022-05-17 20:30 ` Lars Ingebrigtsen
2022-05-17 22:50   ` JD Smith
2022-05-18 11:03     ` Lars Ingebrigtsen
2022-05-18 11:07       ` Lars Ingebrigtsen
2022-05-18 22:19   ` Richard Stallman
2022-05-20  0:03     ` Lars Ingebrigtsen [this message]
2022-06-04 17:59       ` Dmitry Gutov
2022-06-05 14:15         ` Lars Ingebrigtsen
2022-06-05 23:36           ` Dmitry Gutov
2022-06-06 12:44             ` Lars Ingebrigtsen
2022-06-06 21:30               ` Dmitry Gutov
2022-06-07  9:30                 ` Lars Ingebrigtsen
2022-06-11  0:46                   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee0p83zo.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=55491@debbugs.gnu.org \
    --cc=jdtsmith@gmail.com \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).