unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Lars Ingebrigtsen <larsi@gnus.org>, Richard Stallman <rms@gnu.org>
Cc: 55491@debbugs.gnu.org, jdtsmith@gmail.com
Subject: bug#55491: All completion fragments get added to obarray
Date: Sat, 4 Jun 2022 20:59:47 +0300	[thread overview]
Message-ID: <63f442fd-0fb3-3a33-9d05-ec8091ed8c04@yandex.ru> (raw)
In-Reply-To: <87ee0p83zo.fsf@gnus.org>

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

On 20.05.2022 03:03, Lars Ingebrigtsen wrote:
> And that's unnecessary -- we don't actually need the fun-sym; we're just
> checking whether we're looking at `ignore-error'.  So I've now fixed
> this in Emacs 29.
> 
> Note that completion in emacs-lisp-mode may still intern stuff, but not
> as gratuitously as before.

Should we try to remove the last 'read' call on line 700? Like this.

[-- Attachment #2: elisp-c-a-p-no-read.diff --]
[-- Type: text/x-patch, Size: 827 bytes --]

diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el
index 77bf3f1ed1..0130c002da 100644
--- a/lisp/progmodes/elisp-mode.el
+++ b/lisp/progmodes/elisp-mode.el
@@ -697,7 +697,8 @@ elisp-completion-at-point
                                      (let ((c (char-after)))
                                        (if (eq c ?\() ?\(
                                          (if (memq (char-syntax c) '(?w ?_))
-                                             (read (current-buffer))))))
+                                             (and (looking-at "\\(?:\\sw\\|\\s_\\)+")
+                                                  (intern-soft (match-string 0)))))))
                             (error nil))))
                      (pcase parent
                        ;; FIXME: Rather than hardcode special cases here,

  reply	other threads:[~2022-06-04 17:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17 20:22 bug#55491: All completion fragments get added to obarray JD Smith
2022-05-17 20:30 ` Lars Ingebrigtsen
2022-05-17 22:50   ` JD Smith
2022-05-18 11:03     ` Lars Ingebrigtsen
2022-05-18 11:07       ` Lars Ingebrigtsen
2022-05-18 22:19   ` Richard Stallman
2022-05-20  0:03     ` Lars Ingebrigtsen
2022-06-04 17:59       ` Dmitry Gutov [this message]
2022-06-05 14:15         ` Lars Ingebrigtsen
2022-06-05 23:36           ` Dmitry Gutov
2022-06-06 12:44             ` Lars Ingebrigtsen
2022-06-06 21:30               ` Dmitry Gutov
2022-06-07  9:30                 ` Lars Ingebrigtsen
2022-06-11  0:46                   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63f442fd-0fb3-3a33-9d05-ec8091ed8c04@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=55491@debbugs.gnu.org \
    --cc=jdtsmith@gmail.com \
    --cc=larsi@gnus.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).