bug#610: elisp manual on ad-add-advice definition arg

bug#610: elisp manual on ad-add-advice definition arg

[Kevin Ryde]

In the "Computed Advice" node of the elisp manual describing
ad-add-advice, it doesn't say what the "DEFINITION" arg should look
like.  Nosing around the code I see it's a zany `advice'+`lambda' form.
It'd be good if that was described.  (Or if it's described elsewhere I
missed then a cross-reference.)


In GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2008-04-27 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs22:/etc/emacs:/usr/local/share/emacs/22.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/22.2/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/22.2/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  locale-coding-system: iso-8859-1
  default-enable-multibyte-characters: t

bug#610: marked as done (elisp manual on ad-add-advice definition arg)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 847 bytes --]


Your message dated Wed, 22 Oct 2008 15:54:19 -0400
with message-id <87zlkwbe38.fsf@cyd.mit.edu>
and subject line Re: elisp manual on ad-add-advice definition arg
has caused the Emacs bug report #610,
regarding elisp manual on ad-add-advice definition arg
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
610: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=610
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3627 bytes --]

From: Kevin Ryde <user42@zip.com.au>
To: bug-gnu-emacs@gnu.org
Subject: elisp manual on ad-add-advice definition arg
Date: Sat, 26 Jul 2008 10:35:33 +1000
Message-ID: <87d4l1o52i.fsf@blah.blah>

In the "Computed Advice" node of the elisp manual describing
ad-add-advice, it doesn't say what the "DEFINITION" arg should look
like.  Nosing around the code I see it's a zany `advice'+`lambda' form.
It'd be good if that was described.  (Or if it's described elsewhere I
missed then a cross-reference.)


In GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2008-04-27 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs22:/etc/emacs:/usr/local/share/emacs/22.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/22.2/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/22.2/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  locale-coding-system: iso-8859-1
  default-enable-multibyte-characters: t




[-- Attachment #3: Type: message/rfc822, Size: 1276 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Kevin Ryde <user42@zip.com.au>
Cc: 610-done@emacsbugs.donarmstrong.com
Subject: Re: elisp manual on ad-add-advice definition arg
Date: Wed, 22 Oct 2008 15:54:19 -0400
Message-ID: <87zlkwbe38.fsf@cyd.mit.edu>

> In the "Computed Advice" node of the elisp manual describing
> ad-add-advice, it doesn't say what the "DEFINITION" arg should look
> like.  Nosing around the code I see it's a zany `advice'+`lambda'
> form.  It'd be good if that was described.  (Or if it's described
> elsewhere I missed then a cross-reference.)

Fixed, thanks.