From: Noam Postavsky <npostavs@gmail.com>
To: Ivan Shmakov <ivan@siamics.net>
Cc: 32470@debbugs.gnu.org
Subject: bug#32470: rcirc-debug: ignore read-only; do not move point if mid-buffer; use %F
Date: Fri, 14 Sep 2018 08:22:23 -0400 [thread overview]
Message-ID: <87d0tgs1z4.fsf@gmail.com> (raw)
In-Reply-To: <87k1ooyrug.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sat, 18 Aug 2018 08:57:43 +0000")
Ivan Shmakov <ivan@siamics.net> writes:
> I’m somewhat unsure if this change is NEWS-worthy; if so,
> I suggest the following entry.
The behaviour of debug tracing functions is somewhat in the gray area
between user visible and internal details, but I'd say there's no need
to update NEWS for this.
> - (goto-char (point-max))
> - (insert (concat
> - "["
> - (format-time-string "%Y-%m-%dT%T ") (process-name process)
> - "] "
> - text)))))
> + (let ((old (set-marker (make-marker) (point))))
You could use (point-marker) instead.
> + (set-marker-insertion-type old t)
> + (goto-char (point-max))
> + (let ((inhibit-read-only t))
> + (terpri (current-buffer) t)
This looks like you're adding an extra newline, or was there a lack of
newlines before?
next prev parent reply other threads:[~2018-09-14 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 8:57 bug#32470: rcirc-debug: ignore read-only; do not move point if mid-buffer; use %F Ivan Shmakov
2018-09-14 12:22 ` Noam Postavsky [this message]
2018-09-14 19:05 ` Ivan Shmakov
2018-09-18 22:46 ` Noam Postavsky
2019-05-16 11:26 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0tgs1z4.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=32470@debbugs.gnu.org \
--cc=ivan@siamics.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).