From: Noam Postavsky <npostavs@gmail.com>
To: Ivan Shmakov <ivan@siamics.net>
Cc: 32470@debbugs.gnu.org
Subject: bug#32470: rcirc-debug: ignore read-only; do not move point if mid-buffer; use %F
Date: Tue, 18 Sep 2018 18:46:59 -0400 [thread overview]
Message-ID: <877ejiqv8c.fsf@gmail.com> (raw)
In-Reply-To: <87pnxfgart.fsf@violet.siamics.net> (Ivan Shmakov's message of "Fri, 14 Sep 2018 19:05:26 +0000")
Ivan Shmakov <ivan@siamics.net> writes:
> >> + (terpri (current-buffer) t)
>
> > This looks like you’re adding an extra newline,
>
> Only if there’s none already, as the second argument to terpri
> is non-nil. Which can happen, for example, should user edit the
> buffer manually (for whatever reason.)
Oh, right. I don't use terpri so much, so I'd forgotten about that
handy feature.
> Please consider the revised patch MIMEd.
>
> FTR, a ‘side effect’ of this change is that rcirc-debug no
> longer returns the string appended to buffer. (Instead, it
> returns the marker coinciding with point.) AFAICT, the return
> value of this function is never used in the Rcirc code.
I think that's fine, please push to master.
next prev parent reply other threads:[~2018-09-18 22:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 8:57 bug#32470: rcirc-debug: ignore read-only; do not move point if mid-buffer; use %F Ivan Shmakov
2018-09-14 12:22 ` Noam Postavsky
2018-09-14 19:05 ` Ivan Shmakov
2018-09-18 22:46 ` Noam Postavsky [this message]
2019-05-16 11:26 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ejiqv8c.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=32470@debbugs.gnu.org \
--cc=ivan@siamics.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).