* bug#49626: Why mouse-1 is not allowed on button links?
@ 2021-07-18 22:38 Juri Linkov
2021-07-19 13:51 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Juri Linkov @ 2021-07-18 22:38 UTC (permalink / raw)
To: 49626
Tried to click mouse-1 on the button links in the 'dictionary' buffers
(from the built-in package lisp/net/dictionary.el),
but it does nothing, unlike mouse-2. Should this patch be applied?
I'm asking because I'm not sure about its side effects to other packages.
diff --git a/lisp/button.el b/lisp/button.el
index 69d70540c0..74dfb5d541 100644
--- a/lisp/button.el
+++ b/lisp/button.el
@@ -61,6 +61,7 @@ button-map
;; might get converted to ^M when building loaddefs.el
(define-key map [(control ?m)] 'push-button)
(define-key map [mouse-2] 'push-button)
+ (define-key map [follow-link] 'mouse-face)
;; FIXME: You'd think that for keymaps coming from text-properties on the
;; mode-line or header-line, the `mode-line' or `header-line' prefix
;; shouldn't be necessary!
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#49626: Why mouse-1 is not allowed on button links?
2021-07-18 22:38 bug#49626: Why mouse-1 is not allowed on button links? Juri Linkov
@ 2021-07-19 13:51 ` Lars Ingebrigtsen
2021-07-20 19:53 ` Juri Linkov
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2021-07-19 13:51 UTC (permalink / raw)
To: Juri Linkov; +Cc: 49626
Juri Linkov <juri@linkov.net> writes:
> Tried to click mouse-1 on the button links in the 'dictionary' buffers
> (from the built-in package lisp/net/dictionary.el),
> but it does nothing, unlike mouse-2. Should this patch be applied?
> I'm asking because I'm not sure about its side effects to other packages.
I think it should be applied -- I think mouse-1 should work as
documented in all packages?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#49626: Why mouse-1 is not allowed on button links?
2021-07-19 13:51 ` Lars Ingebrigtsen
@ 2021-07-20 19:53 ` Juri Linkov
0 siblings, 0 replies; 3+ messages in thread
From: Juri Linkov @ 2021-07-20 19:53 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 49626
tags 49626 fixed
close 49626 28.0.50
quit
>> Tried to click mouse-1 on the button links in the 'dictionary' buffers
>> (from the built-in package lisp/net/dictionary.el),
>> but it does nothing, unlike mouse-2. Should this patch be applied?
>> I'm asking because I'm not sure about its side effects to other packages.
>
> I think it should be applied -- I think mouse-1 should work as
> documented in all packages?
So now applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-20 19:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-18 22:38 bug#49626: Why mouse-1 is not allowed on button links? Juri Linkov
2021-07-19 13:51 ` Lars Ingebrigtsen
2021-07-20 19:53 ` Juri Linkov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).