* bug#58202: [PATCH] Move point to end of line after indent for sieve-mode
@ 2022-09-30 18:07 John Helmert III
2022-10-01 12:52 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: John Helmert III @ 2022-09-30 18:07 UTC (permalink / raw)
To: 58202; +Cc: John Helmert III
* lisp/net/sieve-mode.el: move pointer to end of line after indenting
---
lisp/net/sieve-mode.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/net/sieve-mode.el b/lisp/net/sieve-mode.el
index f62af03534..80532fc1ba 100644
--- a/lisp/net/sieve-mode.el
+++ b/lisp/net/sieve-mode.el
@@ -200,7 +200,8 @@ Turning on Sieve mode runs `sieve-mode-hook'."
(let ((depth (car (syntax-ppss))))
(when (looking-at "[ \t]*}")
(setq depth (1- depth)))
- (indent-line-to (* 2 depth)))))
+ (indent-line-to (* 2 depth))))
+ (end-of-line))
(provide 'sieve-mode)
--
2.37.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#58202: [PATCH] Move point to end of line after indent for sieve-mode
2022-09-30 18:07 bug#58202: [PATCH] Move point to end of line after indent for sieve-mode John Helmert III
@ 2022-10-01 12:52 ` Lars Ingebrigtsen
2022-10-01 14:54 ` John Helmert III
0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2022-10-01 12:52 UTC (permalink / raw)
To: John Helmert III; +Cc: 58202
John Helmert III <ajak@gentoo.org> writes:
> * lisp/net/sieve-mode.el: move pointer to end of line after indenting
I'm not very familiar with sieve-mode, but moving the pointer to the end
of the line after indenting is pretty unusual for a mode. Why should
sieve-mode do this?
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#58202: [PATCH] Move point to end of line after indent for sieve-mode
2022-10-01 12:52 ` Lars Ingebrigtsen
@ 2022-10-01 14:54 ` John Helmert III
2022-10-02 12:06 ` Lars Ingebrigtsen
0 siblings, 1 reply; 4+ messages in thread
From: John Helmert III @ 2022-10-01 14:54 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 58202
[-- Attachment #1: Type: text/plain, Size: 487 bytes --]
On Sat, Oct 01, 2022 at 02:52:23PM +0200, Lars Ingebrigtsen wrote:
> John Helmert III <ajak@gentoo.org> writes:
>
> > * lisp/net/sieve-mode.el: move pointer to end of line after indenting
>
> I'm not very familiar with sieve-mode, but moving the pointer to the end
> of the line after indenting is pretty unusual for a mode. Why should
> sieve-mode do this?
Without doing this, the point ends up at the beginning of an indented
line, before any added indentation spacing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#58202: [PATCH] Move point to end of line after indent for sieve-mode
2022-10-01 14:54 ` John Helmert III
@ 2022-10-02 12:06 ` Lars Ingebrigtsen
0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2022-10-02 12:06 UTC (permalink / raw)
To: John Helmert III; +Cc: 58202
John Helmert III <ajak@gentoo.org> writes:
> Without doing this, the point ends up at the beginning of an indented
> line, before any added indentation spacing.
But with it, if you hit TAB in the middle of a line, you'll end up at
the end of the line.
I've now pushed a different fix to Emacs 29 that makes TAB work like in
other modes.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-02 12:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-30 18:07 bug#58202: [PATCH] Move point to end of line after indent for sieve-mode John Helmert III
2022-10-01 12:52 ` Lars Ingebrigtsen
2022-10-01 14:54 ` John Helmert III
2022-10-02 12:06 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).