From: Dmitry Gutov <dmitry@gutov.dev>
To: Juri Linkov <juri@linkov.net>
Cc: sbaugh@janestreet.com, Eli Zaretskii <eliz@gnu.org>,
63469@debbugs.gnu.org
Subject: bug#63469: 29.0.90; project.el doesn't add menu-bar entries
Date: Fri, 26 May 2023 01:19:25 +0300 [thread overview]
Message-ID: <87c247b4-21c8-4dfe-2ef8-ba4365f4562e@gutov.dev> (raw)
In-Reply-To: <868rdcfe3n.fsf@mail.linkov.net>
On 25/05/2023 21:41, Juri Linkov wrote:
>>>> -(cl-defmethod project-name ((_project (head vc)))
>>>> - (or project-vc-name
>>>> +(cl-defmethod project-name ((project (head vc)))
>>>> + (or (project--value-in-dir 'project-vc-name (project-root project))
>>>> (cl-call-next-method)))
>>> Thanks, I confirm this uses project-vc-name from dir-locals in non-file
>>> buffers.
>> If you had a chance to verify that the performance is good enough (for
>> using the result in the mode-line), that would be great.
>>
>> Either way...
>>
>>>>> ;;;###autoload(put 'compilation-directory 'safe-local-variable 'stringp)
>>>> Huh, so the attribute :safe only makes proper sense for preloaded packages
>>>> and autoloaded defcustom forms (which are discouraged anyway).
>>>>
>>>> Do you want to write a patch for all those vars in project.el? It will
>>>> probably make sense to push it to emacs-29.
>>> With this patch the problem is solved. I can push it to emacs-29.
>> ...this patch LGTM too. Please go ahead and install it, or even both
>> patches.
> I pushed ###autoload to emacs-29.
Thanks!
> But not sure about your patch
> since currently I have no idea how to verify its performance.
> Maybe it should be pushed to master so that everyone can test it?
I think the performance requirements for 'project-name' are currently
rather modest: the name is only used when selecting the project (in a
custom config) and when generating some buffer names. For that, the new
logic should be fine.
With your feature, however, project-name could be called during
redisplay, and that might require better performance. So I thought you
would test it together with the patch for your feature request.
But I suppose if you're not working on it right this moment, I could
push the patch to emacs-29, and then we could refine the performance (if
necessary) on master.
next prev parent reply other threads:[~2023-05-25 22:19 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 17:48 bug#63469: 29.0.90; project.el doesn't add menu-bar entries Spencer Baugh
2023-05-12 19:09 ` Eli Zaretskii
2023-05-12 19:25 ` Dmitry Gutov
2023-05-15 16:49 ` Juri Linkov
2023-05-15 18:15 ` Spencer Baugh
2023-05-15 18:19 ` Eli Zaretskii
2023-05-15 18:11 ` Spencer Baugh
2023-05-15 18:37 ` Eli Zaretskii
2023-05-15 18:46 ` Spencer Baugh
2023-05-16 16:09 ` Eli Zaretskii
2023-05-16 17:09 ` Spencer Baugh
2023-05-17 11:30 ` Eli Zaretskii
2023-05-17 14:50 ` Spencer Baugh
2023-05-18 6:53 ` Dmitry Gutov
2023-05-18 7:01 ` Eli Zaretskii
2023-05-18 9:49 ` Dmitry Gutov
2023-05-18 10:23 ` Eli Zaretskii
2023-05-18 14:30 ` Spencer Baugh
2023-05-18 15:15 ` Eli Zaretskii
2023-05-18 15:57 ` Juri Linkov
2023-05-18 16:06 ` Eli Zaretskii
2023-05-18 19:34 ` Dmitry Gutov
2023-05-19 6:56 ` Juri Linkov
2023-05-19 10:44 ` Eli Zaretskii
2023-05-19 17:46 ` Juri Linkov
2023-05-19 18:28 ` Eli Zaretskii
2023-05-22 17:48 ` Juri Linkov
2023-05-22 18:20 ` Eli Zaretskii
2023-05-22 19:49 ` Spencer Baugh
2023-05-22 19:54 ` Dmitry Gutov
2023-05-22 21:20 ` Spencer Baugh
2023-05-22 21:30 ` Dmitry Gutov
2023-05-23 13:57 ` Michael Albinus
2023-05-24 1:07 ` Dmitry Gutov
2023-05-24 8:38 ` Michael Albinus
2023-05-23 6:52 ` Juri Linkov
2023-05-23 11:17 ` Eli Zaretskii
2023-05-23 18:08 ` Juri Linkov
2023-05-24 1:10 ` Dmitry Gutov
2023-05-24 6:25 ` Juri Linkov
2023-05-25 1:15 ` Dmitry Gutov
2023-05-25 6:35 ` Juri Linkov
2023-05-25 16:17 ` Dmitry Gutov
2023-05-23 6:49 ` Juri Linkov
2023-05-22 19:59 ` Dmitry Gutov
2023-05-23 6:46 ` Juri Linkov
2023-05-23 18:11 ` Juri Linkov
2023-05-24 1:03 ` Dmitry Gutov
2023-05-24 6:29 ` Juri Linkov
2023-05-25 1:14 ` Dmitry Gutov
2023-05-25 6:29 ` Juri Linkov
2023-05-25 16:14 ` Dmitry Gutov
2023-05-25 18:41 ` Juri Linkov
2023-05-25 22:19 ` Dmitry Gutov [this message]
2023-05-30 17:51 ` Juri Linkov
2023-06-02 2:11 ` Dmitry Gutov
2023-06-02 6:37 ` Juri Linkov
2023-06-03 1:36 ` Dmitry Gutov
2023-05-24 1:00 ` Dmitry Gutov
2023-05-19 14:42 ` Spencer Baugh
2023-05-19 17:41 ` Juri Linkov
2023-06-28 0:54 ` Spencer Baugh
2023-06-28 6:52 ` Juri Linkov
2023-06-29 15:30 ` Spencer Baugh
2023-06-29 17:31 ` Juri Linkov
2023-06-29 18:03 ` Eli Zaretskii
2023-06-29 19:22 ` Spencer Baugh
2023-06-30 5:32 ` Eli Zaretskii
2023-06-30 15:55 ` Spencer Baugh
2023-07-01 9:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87c247b4-21c8-4dfe-2ef8-ba4365f4562e@gutov.dev \
--to=dmitry@gutov.dev \
--cc=63469@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).