unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: 10112@debbugs.gnu.org
Subject: bug#10112: ImageMagick doesn't display some image formats
Date: Thu, 14 Jun 2012 02:57:05 +0300	[thread overview]
Message-ID: <87bokmbwa2.fsf@mail.jurta.org> (raw)
In-Reply-To: <874nx11j7j.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 16 Dec 2011 01:57:52 +0200")

I'm starting to adapt this patch to the recent changes in bug#11557.

I propose the following modifications:

1. Currently the priority of specialized image libraries over
ImageMagick is hard-coded in `imagemagick-register-types' as:

	  ;; Append to `image-type-file-name-regexps', so that we
	  ;; preferentially use specialized image libraries.
	  (add-to-list 'image-type-file-name-regexps
	  	       (cons re 'imagemagick) t)

It could use a new customizable variable where the user can specify
whether to use ImageMagick for all enabled image types, or use
available specialized libraries.  The same option could also specify the
priority of `imagemagick' elements in `image-type-header-regexps'.

Or maybe this new option is not necessary, and `imagemagick'
should have the highest priority.  When the user wants to use
specialized image libraries, it's possible to remove conflicting
image types (such as jpeg/png/gif) from `imagemagick-enabled-types'.

2. The most user-friendly UI to enable image types
is to allow the user to select a set of enabled formats
from the list of all available formats displayed as checkboxes.
This is like during installation of some graphical programs
when they present a list of available image format to allow the user
to associate them with file extensions.

It's possible to do this in Customization UI using the following type
for `imagemagick-enabled-types':

  :type (cons 'set (mapcar
		    (lambda (type)
		      (list 'const type))
		    (sort (imagemagick-types) 'string<)))

3. `imagemagick-types-inhibit' could use the same customization type,
and it should be renamed to `imagemagick-disabled-types' or completely
removed, with adding a new element to `imagemagick-enabled-types'
that will specify whether the list excludes/includes the defined types.





  reply	other threads:[~2012-06-13 23:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22 22:01 bug#10112: ImageMagick doesn't display some image formats Juri Linkov
2011-11-24 19:09 ` Juri Linkov
2011-11-24 21:42   ` Wolfgang Jenkner
2011-11-24 21:52     ` Wolfgang Jenkner
2011-11-24 22:49       ` Juri Linkov
2011-12-15 23:57         ` Juri Linkov
2012-06-13 23:57           ` Juri Linkov [this message]
2014-12-08 23:32           ` Lars Magne Ingebrigtsen
2014-12-09  0:58             ` Juri Linkov
2014-12-09  1:18               ` Lars Magne Ingebrigtsen
2011-12-15 23:32   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bokmbwa2.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=10112@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).