unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: 10112@debbugs.gnu.org
Subject: bug#10112: ImageMagick doesn't display some image formats
Date: Fri, 16 Dec 2011 01:32:38 +0200	[thread overview]
Message-ID: <877h1x4dih.fsf@mail.jurta.org> (raw)
In-Reply-To: <87zkfltk13.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 24 Nov 2011 21:09:12 +0200")

> The patch below adds a new function `imagemagick_error' that is
> called in places where the ImageMagick returns `MagickFalse' status.

Patch installed.

> Removing `MagickSetResolution' cures this problem.  but I hesitate to
> remove it, because I don't know why it's here.  So at least moving
> `MagickSetResolution' a few lines below and calling after
> `MagickPingImage' will allow the read-only images to be correctly
> displayed:

Looking closer at the current situation, I discovered that
using `MagickSetResolution' is suggested by
http://www.imagemagick.org/discourse-server/viewtopic.php?f=2&t=16502
But this hack precludes from displaying some other image formats.
It is intended for loading multi-page djvu images.  Since the
functionality for browsing them is not implemented anyway, it can be
commented out until implemented in 24.2.

The relevant info from etc/TODO:

  *** For some reason its unbearably slow to look at a page in a large
  image bundle using the :index feature.  The ImageMagick "display"
  command is also a bit slow, but nowhere near as slow as the Emacs
  code.  It seems ImageMagick tries to unpack every page when loading the
  bundle.  This feature is not the primary usecase in Emacs though.

  ImageMagick 6.6.2-9 introduced a bugfix for single page djvu load.  It
  is now much faster to use the :index feature, but still not very fast.





      parent reply	other threads:[~2011-12-15 23:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22 22:01 bug#10112: ImageMagick doesn't display some image formats Juri Linkov
2011-11-24 19:09 ` Juri Linkov
2011-11-24 21:42   ` Wolfgang Jenkner
2011-11-24 21:52     ` Wolfgang Jenkner
2011-11-24 22:49       ` Juri Linkov
2011-12-15 23:57         ` Juri Linkov
2012-06-13 23:57           ` Juri Linkov
2014-12-08 23:32           ` Lars Magne Ingebrigtsen
2014-12-09  0:58             ` Juri Linkov
2014-12-09  1:18               ` Lars Magne Ingebrigtsen
2011-12-15 23:32   ` Juri Linkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877h1x4dih.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=10112@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).