unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Óscar Fuentes" <ofv@wanadoo.es>
To: 21054@debbugs.gnu.org
Subject: bug#21054: 25.0.50; Can't edit SES documents: Not at cell
Date: Wed, 18 Nov 2015 20:46:58 +0100	[thread overview]
Message-ID: <87bnar84zx.fsf@wanadoo.es> (raw)
In-Reply-To: <87fv03870r.fsf_-_@wanadoo.es> ("Óscar Fuentes"'s message of "Wed, 18 Nov 2015 20:03:16 +0100")

Óscar Fuentes <ofv@wanadoo.es> writes:

> ... Stephan ...

Stefan, sorry.

For the record, the problem starts on ses-edit-cell calling
ses-check-curcell, which throws the "Not at cell" error. It seems that
ses--curcell is always nil at that call path. So this is a "fix" that
ensures that ses--curcell has a value that correponds to the actual
position of the cursor:


diff --git a/lisp/ses.el b/lisp/ses.el
index ec1359b..1631af0 100644
--- a/lisp/ses.el
+++ b/lisp/ses.el
@@ -2355,6 +2355,7 @@ ses-edit-cell
   (interactive
    (progn
      (barf-if-buffer-read-only)
+     (ses-set-curcell)
      (ses-check-curcell)
      (let* ((rowcol  (ses-sym-rowcol ses--curcell))
 	    (row     (car rowcol))


As mentioned on my previous message, I have no idea about the
correctness of this change. Moreover, some quick checks with other
functions that call ses-check-curcell show that quite a few operations
are broken too. Since the set of SES features that I use is very small,
at this point I don't know how many of those bugs are regressions and,
specifically, how many of them were introduced by the same change that
caused this bug report. Comparing with an older Emacs version will
clarify those doubts, but right now I'm under the impression that ses.el
is badly broken.





  reply	other threads:[~2015-11-18 19:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-14 10:39 bug#21054: 25.0.50; Can't edit SES documents: Not at cell Óscar Fuentes
     [not found] ` <handler.21054.B.14368703993315.ack@debbugs.gnu.org>
2015-07-14 23:10   ` bug#21054: Acknowledgement (25.0.50; Can't edit SES documents: Not at cell) Óscar Fuentes
2015-08-23 13:54     ` bug#21054: 25.0.50; Can't edit SES documents: Not at cell Óscar Fuentes
2015-08-23 22:37       ` Stefan Monnier
2015-11-18  2:23 ` bug#21054: Fixed Óscar Fuentes
2015-11-18  4:00 ` bug#21054: Reopen Óscar Fuentes
2015-11-18 17:27   ` Eli Zaretskii
2015-11-18 19:03     ` bug#21054: 25.0.50; Can't edit SES documents: Not at cell Óscar Fuentes
2015-11-18 19:46       ` Óscar Fuentes [this message]
2015-11-19 17:11     ` bug#21054: Reopen Stephen Leake
2015-11-19 17:17       ` Stephen Leake
2015-11-19 17:37         ` Stephen Leake
2015-11-20 12:55           ` Óscar Fuentes
2016-01-01  5:42 ` bug#21054: 25.0.50; Can't edit SES documents: Not at cell Óscar Fuentes
2016-01-02 16:07 ` Vincent Belaïche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnar84zx.fsf@wanadoo.es \
    --to=ofv@wanadoo.es \
    --cc=21054@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).