From: Stephen Leake <stephen_leake@stephe-leake.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Óscar Fuentes" <ofv@wanadoo.es>, 21054@debbugs.gnu.org
Subject: bug#21054: Reopen
Date: Thu, 19 Nov 2015 11:17:29 -0600 [thread overview]
Message-ID: <86k2pd7vti.fsf@stephe-leake.org> (raw)
In-Reply-To: <86oaep7w32.fsf@stephe-leake.org> (Stephen Leake's message of "Thu, 19 Nov 2015 11:11:45 -0600")
Stephen Leake <stephen_leake@stephe-leake.org> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Óscar Fuentes <ofv@wanadoo.es>
>>> Date: Wed, 18 Nov 2015 05:00:15 +0100
>>>
>>> After a proper build (full rebuild from a pristine checkout; something
>>> is wrong with the Emacs build system) the problem is still there.
>>
>> The changeset you identified as the one to blame is huge, even if we
>> look only at changes in ses.el.
>
> That change introduced the function `ses--curcell'. It appears that the
> variable `ses--curcell' is supposed to be the cached value of the
> function `ses--curcell', but that is failing in this case.
>
> `ses--curcell-overlay' is another variable that must be set for the
> current cell; it adds the underline of the current cell. I noticed that
> the underline is correct in this use case, so I looked for places where
> `ses--curcell-overlay' is set but `ses--curcell' is not. I only found
> one, in `ses-setup'. This patch fixes the problem for me:
>
> diff --git a/lisp/ses.el b/lisp/ses.el
> index ec1359b..03aca0a 100644
> --- a/lisp/ses.el
> +++ b/lisp/ses.el
> @@ -1905,6 +1905,8 @@ Narrows the buffer to show only the print area. Gives it `read-only' and
> (forward-char)
> (point))))
> (put-text-property pos end 'cursor-intangible sym))))))
> + (goto-char (point-min))
> + (ses-set-curcell)
> ;; Create the underlining overlay. It's impossible for (point) to be 2,
> ;; because column A must be at least 1 column wide.
> (setq ses--curcell-overlay (make-overlay (1+ (point-min)) (1+ (point-min))))
I spoke too soon; this allows hitting <return> on cell A1. But hitting
<return> on cell C8 shows the contents of A1. So I missed something.
--
-- Stephe
next prev parent reply other threads:[~2015-11-19 17:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 10:39 bug#21054: 25.0.50; Can't edit SES documents: Not at cell Óscar Fuentes
[not found] ` <handler.21054.B.14368703993315.ack@debbugs.gnu.org>
2015-07-14 23:10 ` bug#21054: Acknowledgement (25.0.50; Can't edit SES documents: Not at cell) Óscar Fuentes
2015-08-23 13:54 ` bug#21054: 25.0.50; Can't edit SES documents: Not at cell Óscar Fuentes
2015-08-23 22:37 ` Stefan Monnier
2015-11-18 2:23 ` bug#21054: Fixed Óscar Fuentes
2015-11-18 4:00 ` bug#21054: Reopen Óscar Fuentes
2015-11-18 17:27 ` Eli Zaretskii
2015-11-18 19:03 ` bug#21054: 25.0.50; Can't edit SES documents: Not at cell Óscar Fuentes
2015-11-18 19:46 ` Óscar Fuentes
2015-11-19 17:11 ` bug#21054: Reopen Stephen Leake
2015-11-19 17:17 ` Stephen Leake [this message]
2015-11-19 17:37 ` Stephen Leake
2015-11-20 12:55 ` Óscar Fuentes
2016-01-01 5:42 ` bug#21054: 25.0.50; Can't edit SES documents: Not at cell Óscar Fuentes
2016-01-02 16:07 ` Vincent Belaïche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86k2pd7vti.fsf@stephe-leake.org \
--to=stephen_leake@stephe-leake.org \
--cc=21054@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=ofv@wanadoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).