unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#26057: 25.1; 'M-x eshell-source-file' fails
@ 2017-03-11  9:57 Chunyang Xu
  2019-07-26 12:15 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Chunyang Xu @ 2017-03-11  9:57 UTC (permalink / raw)
  To: 26057


After I open Eshell, the eshell-source-file is available as an
interactive command and in (info "(eshell) Scripts") it says

  Scripts are invoked from Eshell with ‘source’, or from anywhere in Emacs
  with ‘eshell-source-file’.

so it looks like to me I can run

  M-x eshell-source-file RET /tmp/foo.esh RET

the content of the file (which should not matter)

  ~ $ cat /tmp/foo.esh
  pwd
  ~ $

it fails by showing the following in the echo area

  eshell-source-file: No catch for tag: eshell-replace-command, (let ((eshell-command-name (quote "/tmp/foo.esh")) (eshell-command-arguments (quote nil))) (eshell-trap-errors (eshell-named-command "pwd")))

the backtrace is

Debugger entered--Lisp error: (no-catch eshell-replace-command (let ((eshell-command-name (quote "/tmp/foo.esh")) (eshell-command-arguments (quote nil))) (eshell-trap-errors (eshell-named-command "pwd"))))
  throw(eshell-replace-command (let ((eshell-command-name (quote "/tmp/foo.esh")) (eshell-command-arguments (quote nil))) (eshell-trap-errors (eshell-named-command "pwd"))))
  eshell-source-file("/tmp/foo.esh")
  funcall-interactively(eshell-source-file "/tmp/foo.esh")
  call-interactively(eshell-source-file record nil)
  command-execute(eshell-source-file record)
  execute-extended-command(nil "eshell-source-file" nil)
  funcall-interactively(execute-extended-command nil "eshell-source-file" nil)
  call-interactively(execute-extended-command nil nil)
  command-execute(execute-extended-command)

I don't really sure about the purpose of making eshell-source-file
interactive, maybe it is a bug?







^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#26057: 25.1; 'M-x eshell-source-file' fails
  2017-03-11  9:57 bug#26057: 25.1; 'M-x eshell-source-file' fails Chunyang Xu
@ 2019-07-26 12:15 ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2019-07-26 12:15 UTC (permalink / raw)
  To: Chunyang Xu; +Cc: 26057

Chunyang Xu <mail@xuchunyang.me> writes:

> After I open Eshell, the eshell-source-file is available as an
> interactive command and in (info "(eshell) Scripts") it says
>
>   Scripts are invoked from Eshell with ‘source’, or from anywhere in Emacs
>   with ‘eshell-source-file’.
>
> so it looks like to me I can run
>
>   M-x eshell-source-file RET /tmp/foo.esh RET

[...]

> it fails by showing the following in the echo area
>
>   eshell-source-file: No catch for tag: eshell-replace-command, (let

[...]

> I don't really sure about the purpose of making eshell-source-file
> interactive, maybe it is a bug?

It looks like the interactive spec has always been there (at least since
2000), but that function can't possibly work as an interactive command.
So, as you say, I think it's a bug, and I've now removed the interactive
spec from the function on the Emacs trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-26 12:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-11  9:57 bug#26057: 25.1; 'M-x eshell-source-file' fails Chunyang Xu
2019-07-26 12:15 ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).