unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 40919@debbugs.gnu.org, tspiteri@ieee.org
Subject: bug#40919: 27.0.91; next-error-select-buffer does not always behave as documented
Date: Fri, 12 Jun 2020 01:43:29 +0300	[thread overview]
Message-ID: <87bllp1b1e.fsf@mail.linkov.net> (raw)
In-Reply-To: <0138e3ed-2bf7-1d07-b5d1-7a4f3786e865@yandex.ru> (Dmitry Gutov's message of "Thu, 11 Jun 2020 02:32:44 +0300")

> what kind of functions do they want to put on there?

Both next-error-buffer-on-selected-frame and next-error-no-navigation-try-current.

> And/or would they be content to advice-add on
> next-error-find-buffer-function instead?

Is it possible to add advice-add by using customization?

>> -(defcustom next-error-find-buffer-function #'ignore
>> +(defcustom next-error-find-buffer-function '(ignore)
>
>                                              ^s, maybe?

Ok, when using as a hook it could be '-functions', but in case
of using advice-add it should be still '-function'.

>> +   (or (and (functionp next-error-find-buffer-function)
>> +            (funcall next-error-find-buffer-function avoid-current
>> +                     extra-test-inclusive extra-test-exclusive))
>> +       (and (listp next-error-find-buffer-function)
>> +            (run-hook-with-args-until-success
>> +             'next-error-find-buffer-function avoid-current
>> +             extra-test-inclusive extra-test-exclusive)))
>
> Looks like run_hook_with_args can deal with the case where the value of the
> hook is a single function.

Ok, if it's impossible to use advice-add then lets simplify the hook case.

>>      ;; 2. If next-error-last-buffer is an acceptable buffer, use that.
>>      (if (and next-error-last-buffer
>>               (next-error-buffer-p next-error-last-buffer avoid-current
>
> Should we take the rest of the cases in next-error-find-buffer and move
> them to the default value of the above hook?

I don't think so, I don't believe someone might want to customize the
rest of the cases.





  reply	other threads:[~2020-06-11 22:43 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28  1:51 bug#40919: 27.0.91; next-error-select-buffer does not always behave as documented Trevor Spiteri
2020-04-28 11:37 ` Trevor Spiteri
2020-04-28 23:40 ` Juri Linkov
2020-04-29  0:13   ` Trevor Spiteri
2020-04-29 20:38     ` Juri Linkov
2020-04-29 22:40       ` Trevor Spiteri
2020-04-30 20:14         ` Juri Linkov
2020-04-30 23:18           ` Trevor Spiteri
2020-05-02 23:38             ` Juri Linkov
2020-05-03  2:40               ` Eli Zaretskii
2020-05-03 22:36                 ` Juri Linkov
2020-05-19  1:48                   ` Dmitry Gutov
2020-05-19 22:21                     ` Juri Linkov
2020-05-21 23:57                       ` Dmitry Gutov
2020-05-23 22:24                         ` Juri Linkov
2020-05-23 23:30                           ` Dmitry Gutov
2020-05-24 21:48                             ` Juri Linkov
2020-05-25  1:58                               ` Dmitry Gutov
2020-05-25 15:17                                 ` Eli Zaretskii
2020-05-25 23:17                                   ` Dmitry Gutov
2020-05-26 16:06                                     ` Eli Zaretskii
2020-05-26 16:20                                       ` Dmitry Gutov
2020-05-26 16:33                                         ` Eli Zaretskii
2020-05-26 20:39                                           ` Dmitry Gutov
2020-05-27 19:18                                             ` Dmitry Gutov
2020-05-30 22:29                                 ` Juri Linkov
2020-06-10 23:03                                   ` Juri Linkov
2020-06-10 23:28                                     ` Dmitry Gutov
2020-06-11 13:11                                       ` Eli Zaretskii
2020-06-11 22:39                                       ` Juri Linkov
2020-06-12  7:06                                         ` Eli Zaretskii
2020-06-13 22:53                                           ` Juri Linkov
2020-06-14 23:17                                             ` Juri Linkov
2020-05-28 23:07                           ` Dmitry Gutov
2020-06-01 22:41                             ` Juri Linkov
2020-06-01 23:04                               ` Dmitry Gutov
2020-06-10 23:05                                 ` Juri Linkov
2020-06-10 23:32                                   ` Dmitry Gutov
2020-06-11 22:43                                     ` Juri Linkov [this message]
2020-06-14 11:50                                       ` Dmitry Gutov
2020-06-14 23:15                                         ` Juri Linkov
2020-06-15  7:58                                           ` Dmitry Gutov
2020-06-24 23:38                                             ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bllp1b1e.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=40919@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=tspiteri@ieee.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).