unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#49474: 28.0.50; package-menu-filter-by-status doesn't accept argument it claims to
@ 2021-07-09  1:20 Adam Porter
  2021-07-10 16:54 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Adam Porter @ 2021-07-09  1:20 UTC (permalink / raw)
  To: 49474

The docstring for the function package-menu-filter-by-status says:

    When called interactively, prompt for STATUS, which can be a
    comma-separated string.  If STATUS is empty, show all packages.

    When called from Lisp, STATUS can be a string or a list of
    strings.  If STATUS is nil or the empty string, show all
    packages.

However, when given a comma-separated string or a list of strings, it
doesn't work, because it applies a filter predicate that calls
string-match-p, which expects a regexp string.

Thanks for your work on Emacs.





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#49474: 28.0.50; package-menu-filter-by-status doesn't accept argument it claims to
  2021-07-09  1:20 bug#49474: 28.0.50; package-menu-filter-by-status doesn't accept argument it claims to Adam Porter
@ 2021-07-10 16:54 ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2021-07-10 16:54 UTC (permalink / raw)
  To: Adam Porter; +Cc: 49474

Adam Porter <adam@alphapapa.net> writes:

> The docstring for the function package-menu-filter-by-status says:
>
>     When called interactively, prompt for STATUS, which can be a
>     comma-separated string.  If STATUS is empty, show all packages.
>
>     When called from Lisp, STATUS can be a string or a list of
>     strings.  If STATUS is nil or the empty string, show all
>     packages.
>
> However, when given a comma-separated string or a list of strings, it
> doesn't work, because it applies a filter predicate that calls
> string-match-p, which expects a regexp string.

Yup.  I've now changed the command (in Emacs 28) to work as documented.
Hopefully nobody were relying on the previous, undocumented regexp-match
behaviour.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-10 16:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09  1:20 bug#49474: 28.0.50; package-menu-filter-by-status doesn't accept argument it claims to Adam Porter
2021-07-10 16:54 ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).