From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 51076@debbugs.gnu.org
Subject: bug#51076: 28.0.60; Null dereference warning with nox build in make_lispy_position
Date: Fri, 08 Oct 2021 11:20:41 +0100 [thread overview]
Message-ID: <87bl3zom12.fsf@tcd.ie> (raw)
In-Reply-To: <831r4x0ylq.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Oct 2021 09:10:48 -0400")
close 51076 28.1
quit
Eli Zaretskii [2021-10-07 09:10 -0400] wrote:
>> Date: Thu, 07 Oct 2021 12:35:24 +0100
>> From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> In file included from keyboard.c:29:
>> keyboard.c: In function ‘make_lispy_position’:
>> frame.h:949:35: warning: null pointer dereference [-Wnull-dereference]
>> 949 | #define FRAME_TAB_BAR_LINES(f) (f)->tab_bar_lines
>> | ~~~^~~~~~~~~~~~~~~
>> keyboard.c:5134:10: note: in expansion of macro ‘FRAME_TAB_BAR_LINES’
>> 5134 | && FRAME_TAB_BAR_LINES (f) > 0
>> | ^~~~~~~~~~~~~~~~~~~
>>
>> AFAICT the preceding condition '!FRAME_WINDOW_P (f)' will always be true
>> in a nox build
>
> Yes, but what about a build with X support that displays a TTY frame?
>
> I installed a trivial fix.
Thanks, that does the trick.
--
Basil
prev parent reply other threads:[~2021-10-08 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 11:35 bug#51076: 28.0.60; Null dereference warning with nox build in make_lispy_position Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-07 13:10 ` Eli Zaretskii
2021-10-08 10:20 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl3zom12.fsf@tcd.ie \
--to=bug-gnu-emacs@gnu.org \
--cc=51076@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).