From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51076: 28.0.60; Null dereference warning with nox build in make_lispy_position Date: Fri, 08 Oct 2021 11:20:41 +0100 Message-ID: <87bl3zom12.fsf@tcd.ie> References: <87wnmp2hkz.fsf@tcd.ie> <831r4x0ylq.fsf@gnu.org> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31589"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51076@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 08 12:21:31 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYn0L-0007qF-Kl for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Oct 2021 12:21:29 +0200 Original-Received: from localhost ([::1]:36888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYn0J-0006L3-Fx for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Oct 2021 06:21:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYmzu-0006Gb-JG for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 06:21:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37728) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYmzu-00036k-Ac for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 06:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mYmzu-0002vR-72 for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2021 06:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Oct 2021 10:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51076 X-GNU-PR-Package: emacs Original-Received: via spool by 51076-submit@debbugs.gnu.org id=B51076.163368845511225 (code B ref 51076); Fri, 08 Oct 2021 10:21:02 +0000 Original-Received: (at 51076) by debbugs.gnu.org; 8 Oct 2021 10:20:55 +0000 Original-Received: from localhost ([127.0.0.1]:49274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYmzn-0002uz-07 for submit@debbugs.gnu.org; Fri, 08 Oct 2021 06:20:55 -0400 Original-Received: from mail-wr1-f42.google.com ([209.85.221.42]:40904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mYmzh-0002uT-9p for 51076@debbugs.gnu.org; Fri, 08 Oct 2021 06:20:51 -0400 Original-Received: by mail-wr1-f42.google.com with SMTP id i12so15593535wrb.7 for <51076@debbugs.gnu.org>; Fri, 08 Oct 2021 03:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=HGjowycWLwrWSQl1yZ/72gMjhlkw9fv6meCA4k5FpZ4=; b=RdBS+ZB1O1hEUNACW7dHMjAKFe/HAyPwTbrWUOzhmjXYsyoyMOaTLAlvG4jJmUrlZg 6rjyDmSVKK299ffatfCjs51ACNW/fWOA4NdWKMp+Om3V3uXZ154IVaJa+jihFyZYYd0R qibRa7Wn3ZiWyGaKT4eqi4eQmWFw5T5XgFPxF9UF/piP29lRcl9p/0ji/2sBPzRjFoAC aidszsfPmjbfzpHlo+k5qLy0yhRlfPrLHtXiGgxDRu1qxqPus6Csg58n/NWqlfkZM++b QKKHmbVMIUGEoc7IwkD7WoTQtG3c2+tF/+P+BhHVKY0J7Iqz0rhxrM68F8U0NSV2kbl3 fNpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=HGjowycWLwrWSQl1yZ/72gMjhlkw9fv6meCA4k5FpZ4=; b=ENVt3zn/IV40LqSrw8ZuwoDoDGT+AfCfAzBOmW+0To7RtDREIvr5fOmaOG4BzrFH+6 M8mDl0/gc1Utcxi2FzZFFdgHmbJVwPMyU0JYnuLgW7HPryu+NOFQeDx+EUm74i1OMRa6 jQ3RlxotXAYcJcHB8xOsJpOFs6d/ieUHsyBwOJgfkKGzMsXg2DIvN+/yfOaBUvpxm1h5 CFmFi17r+dMODRtdWuQzseBvDbr7h73tPTz8boin38BQb68yn81atra6wA2GBcHE7NKl wVeKXxhqAXAeg8kQcT1W2oh60gpXrtyxkkbnLAOKHDqKQTsIRFjK53DGaFQqGQODimNQ 6/Ag== X-Gm-Message-State: AOAM530hh5XeoLS27wJCLJ//it/8SsO+aP8kOP7iA9emYT0Nf+C+fGDV o5Ho4oR+B90XY9ssh7HnTKqQEw== X-Google-Smtp-Source: ABdhPJxlYAkdG16ixJ98776VSpXI9ezydtyIqvsVT+Z3TCjJxFJUMGDUU3pSs4xUgjRkZhQFF0MJ7Q== X-Received: by 2002:a05:6000:1562:: with SMTP id 2mr2968810wrz.36.1633688443437; Fri, 08 Oct 2021 03:20:43 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id q3sm1998622wmc.25.2021.10.08.03.20.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 03:20:42 -0700 (PDT) In-Reply-To: <831r4x0ylq.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Oct 2021 09:10:48 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216699 Archived-At: close 51076 28.1 quit Eli Zaretskii [2021-10-07 09:10 -0400] wrote: >> Date: Thu, 07 Oct 2021 12:35:24 +0100 >> From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> In file included from keyboard.c:29: >> keyboard.c: In function =E2=80=98make_lispy_position=E2=80=99: >> frame.h:949:35: warning: null pointer dereference [-Wnull-dereference] >> 949 | #define FRAME_TAB_BAR_LINES(f) (f)->tab_bar_lines >> | ~~~^~~~~~~~~~~~~~~ >> keyboard.c:5134:10: note: in expansion of macro =E2=80=98FRAME_TAB_BAR_L= INES=E2=80=99 >> 5134 | && FRAME_TAB_BAR_LINES (f) > 0 >> | ^~~~~~~~~~~~~~~~~~~ >>=20 >> AFAICT the preceding condition '!FRAME_WINDOW_P (f)' will always be true >> in a nox build > > Yes, but what about a build with X support that displays a TTY frame? > > I installed a trivial fix. Thanks, that does the trick. --=20 Basil