From: Lars Ingebrigtsen <larsi@gnus.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: 52194@debbugs.gnu.org, dick.r.chiang@gmail.com
Subject: bug#52194: 28.0.50; [PATCH] Put paid to a flappy test module
Date: Tue, 30 Nov 2021 14:16:56 +0100 [thread overview]
Message-ID: <87bl21pyuv.fsf@gnus.org> (raw)
In-Reply-To: <87sfve3pce.fsf@gmail.com> (Robert Pluim's message of "Tue, 30 Nov 2021 11:33:21 +0100")
Robert Pluim <rpluim@gmail.com> writes:
>>>>>> On Mon, 29 Nov 2021 20:38:05 -0500, dick.r.chiang@gmail.com said:
>
> dick> From 18e2cfa112c3393b4191bb3497bf9a0ae643c2a2 Mon Sep 17 00:00:00 2001
> dick> From: dickmao <dick.r.chiang@gmail.com>
> dick> Date: Mon, 29 Nov 2021 20:31:28 -0500
> dick> Subject: [PATCH] Don't repeat yourself (DRY)
>
> I donʼt think that quite works:
[...]
> SKIPPED echo-server-with-dns
It works here...
But as for the patch itself -- "don't repeat yourself" is good advice in
normal code, but for tests, we want to be as explicit as possible, so
that when tests fail, we can see exactly what fails. So I don't think
rewriting the tests is a good idea, and I'm closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-11-30 13:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 1:38 bug#52194: 28.0.50; [PATCH] Put paid to a flappy test module dick.r.chiang
2021-11-30 10:33 ` Robert Pluim
2021-11-30 13:16 ` Lars Ingebrigtsen [this message]
2021-11-30 13:41 ` Robert Pluim
2021-11-30 13:53 ` dick
2021-11-30 14:12 ` Robert Pluim
2021-11-30 14:25 ` dick
2021-11-30 14:34 ` Lars Ingebrigtsen
2021-11-30 14:51 ` dick
2021-11-30 15:12 ` Robert Pluim
2021-11-30 15:12 ` Lars Ingebrigtsen
2021-11-30 17:16 ` Eli Zaretskii
2021-12-01 7:05 ` Richard Stallman
2021-12-01 15:05 ` dick
2021-12-02 4:35 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl21pyuv.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=52194@debbugs.gnu.org \
--cc=dick.r.chiang@gmail.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).