From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#52194: 28.0.50; [PATCH] Put paid to a flappy test module Date: Tue, 30 Nov 2021 14:16:56 +0100 Message-ID: <87bl21pyuv.fsf@gnus.org> References: <87pmqimnia.fsf@dick> <87sfve3pce.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17982"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52194@debbugs.gnu.org, dick.r.chiang@gmail.com To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 30 14:18:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ms31Y-0004TU-Hk for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Nov 2021 14:18:20 +0100 Original-Received: from localhost ([::1]:40022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ms31W-00059X-W7 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Nov 2021 08:18:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ms31G-00058O-KY for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2021 08:18:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57078) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ms31G-0006qO-Bk for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2021 08:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ms31G-0007Rp-3O for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2021 08:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Nov 2021 13:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52194 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52194-submit@debbugs.gnu.org id=B52194.163827822826658 (code B ref 52194); Tue, 30 Nov 2021 13:18:02 +0000 Original-Received: (at 52194) by debbugs.gnu.org; 30 Nov 2021 13:17:08 +0000 Original-Received: from localhost ([127.0.0.1]:40388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ms30N-0006vf-Ie for submit@debbugs.gnu.org; Tue, 30 Nov 2021 08:17:07 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:41402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ms30M-0006pu-0F for 52194@debbugs.gnu.org; Tue, 30 Nov 2021 08:17:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gUuvUep1f7l6DhKqrQkOSv4AyMIeGXInpGtP1XxSB6o=; b=uwj4WXjLd6jLkePwb5X9LRu16R Oy5ZQ59NPjSYgU+sO6oCwyQMhUNjJiRj1cLHSHxKvXXOFR395litiZ7S7qiZh8BDP0BjHa1W90F2F MPiHAEnjZSvRTr9SKNeI6aJi/x91PUnKmVvwQ5ge8msja66A2jo4z8sxVc5iXyar2kRY=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ms30C-0006S2-Rm; Tue, 30 Nov 2021 14:16:59 +0100 X-Now-Playing: Herbert's _Musca_: "Gold Dust feat. Bianca Rose" In-Reply-To: <87sfve3pce.fsf@gmail.com> (Robert Pluim's message of "Tue, 30 Nov 2021 11:33:21 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221114 Archived-At: Robert Pluim writes: >>>>>> On Mon, 29 Nov 2021 20:38:05 -0500, dick.r.chiang@gmail.com said: > > dick> From 18e2cfa112c3393b4191bb3497bf9a0ae643c2a2 Mon Sep 17 00:00:= 00 2001 > dick> From: dickmao > dick> Date: Mon, 29 Nov 2021 20:31:28 -0500 > dick> Subject: [PATCH] Don't repeat yourself (DRY) > > I don=CA=BCt think that quite works: [...] > SKIPPED echo-server-with-dns It works here... But as for the patch itself -- "don't repeat yourself" is good advice in normal code, but for tests, we want to be as explicit as possible, so that when tests fail, we can see exactly what fails. So I don't think rewriting the tests is a good idea, and I'm closing this bug report. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no