From: Michael Albinus <michael.albinus@gmx.de>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: 46351@debbugs.gnu.org
Subject: bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining
Date: Wed, 19 Jan 2022 16:52:00 +0100 [thread overview]
Message-ID: <87bl07910f.fsf@gmx.de> (raw)
In-Reply-To: <87y23dei2o.fsf@melete.silentflame.com> (Sean Whitton's message of "Mon, 17 Jan 2022 22:19:59 -0700")
Sean Whitton <spwhitton@spwhitton.name> writes:
> Hello,
Hi Sean,
> I've got it working. Please let me know what you think of the attached.
Some comments:
> --- /dev/null
> +++ b/test/lisp/eshell/em-extpipe-tests.el
> @@ -0,0 +1,122 @@
> +(load (expand-file-name "eshell-tests"
> + (file-name-directory (or load-file-name
> + default-directory))))
This is problematic. Loading eshell-tests.el declares also all ert tests
which are contained in that file. Running em-extpipe-tests.el in batch
would run also all tests from that file, which is not intended I believe.
A better approach would be to factor out the helper functions from
eshell-tests.el into an own file, and load it here and in eshell-tests.el.
> +(cl-macrolet
> + ((deftest (name input expected)
> + (let ((result (gensym)))
> + `(ert-deftest ,name ()
> + (let* ((shell-file-name "sh") (shell-command-switch "-c")
I'm not sure this is the right approach. Why do you change
shell-file-name and shell-command-switch? You've spoken in another
message about Tramp, but I don't understand this. Tramp has its own
machinery to handle them, via connection-local variables.
> + (deftest em-extpipe-test-7
Looks like em-extpipe-test-6 is missing.
> Sean Whitton
Best regards, Michael.
next prev parent reply other threads:[~2022-01-19 15:52 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 20:06 bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining Sean Whitton
2021-02-07 9:17 ` Michael Albinus
2021-02-07 19:01 ` Sean Whitton
2021-02-08 10:28 ` Michael Albinus
2021-02-08 18:07 ` Sean Whitton
2021-02-10 11:33 ` Michael Albinus
2021-12-24 21:20 ` Sean Whitton
2021-12-25 13:51 ` Michael Albinus
2021-12-25 22:45 ` Sean Whitton
2021-12-27 14:42 ` Michael Albinus
2021-12-27 18:13 ` Sean Whitton
2021-12-27 18:22 ` Eli Zaretskii
2021-12-27 19:21 ` Sean Whitton
2021-12-27 19:35 ` Eli Zaretskii
2021-12-27 19:53 ` Sean Whitton
2021-12-27 19:37 ` Michael Albinus
2021-12-27 19:54 ` Sean Whitton
2021-12-28 8:58 ` Michael Albinus
2022-01-18 5:19 ` Sean Whitton
2022-01-18 9:49 ` Robert Pluim
2022-01-18 18:27 ` Sean Whitton
2022-01-18 14:45 ` Eli Zaretskii
2022-01-18 18:40 ` Sean Whitton
2022-01-18 19:38 ` Eli Zaretskii
2022-01-18 23:16 ` Sean Whitton
2022-01-19 7:34 ` Eli Zaretskii
2022-01-19 20:39 ` Sean Whitton
2022-01-20 6:53 ` Eli Zaretskii
2022-01-20 22:16 ` Sean Whitton
2022-01-21 6:54 ` Eli Zaretskii
2022-01-22 0:16 ` Sean Whitton
2022-01-18 18:42 ` Sean Whitton
2022-01-19 15:52 ` Michael Albinus [this message]
2022-01-19 20:54 ` Sean Whitton
2022-01-20 18:41 ` Michael Albinus
2022-01-20 22:17 ` Sean Whitton
2022-01-23 22:39 ` Sean Whitton
2022-01-24 9:55 ` Lars Ingebrigtsen
2022-01-24 14:18 ` Michael Albinus
2022-01-24 20:32 ` Sean Whitton
2022-01-24 20:44 ` Sean Whitton
2022-01-24 20:48 ` Lars Ingebrigtsen
2022-01-24 21:42 ` Sean Whitton
2022-01-24 21:51 ` Lars Ingebrigtsen
2022-01-24 22:48 ` Sean Whitton
2022-01-24 20:46 ` Lars Ingebrigtsen
2022-01-25 2:39 ` Jim Porter
2022-01-25 5:33 ` bug#53518: 29.0.50; em-extpipe breaks input of sharp-quoted Lisp symbols Sean Whitton
2022-01-25 8:50 ` Sean Whitton
2022-01-25 12:26 ` Lars Ingebrigtsen
2022-01-25 16:48 ` Sean Whitton
2022-01-26 5:38 ` Jim Porter
2022-01-26 13:13 ` Lars Ingebrigtsen
2022-01-25 18:14 ` Jim Porter
2022-01-25 20:01 ` Sean Whitton
2022-01-25 20:52 ` Jim Porter
2022-01-25 22:38 ` Sean Whitton
2022-01-25 8:54 ` bug#46351: 28.0.50; Add convenient way to bypass Eshell's own pipelining Michael Albinus
2022-01-25 18:22 ` Jim Porter
2021-12-27 18:26 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl07910f.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=46351@debbugs.gnu.org \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).