bug#4417: 23.1.50; vc-hg is broken in non-English locales

bug#4417: 23.1.50; vc-hg is broken in non-English locales

[Sven Joachim]

When opening a file in a mercurial-controlled directory, the modeline
shows "Hg-0" instead of the revision number in my de_DE.UTF-8 locale.
Moreover, after pressing "C-x v l", the *vc-change-log* buffer is
unfontified, and standard keys (d, f) do not work there, because hg's
output is in German:

,----
| Änderung:        1587:1cdfa7c5503e
| Vorgänger:       1585:ef75fa728cca
| Nutzer:          Daniel Burrows <dburrows@debian.org>
| Datum:           Sun Jul 20 12:31:09 2008 -0700
| Zusammenfassung: Document how aptitude handles double-quotes.
`----

Setting LANG to C works around the problems.  For the reference, this is
my mercurial version:

,----
| % hg --version
| Mercurial Distributed SCM (version 1.3.1)
`----

In GNU Emacs 23.1.50.6 (i486-pc-linux-gnu, GTK+ Version 2.16.6)
 of 2009-09-12 on turtle
Windowing system distributor `The X.Org Foundation', version 11.0.10603000
configured using `configure  '--build=i486-linux-gnu' 'build_alias=i486-linux-gnu' 'CFLAGS=-DGTK_DISABLE_DEPRECATED -g -O2''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: C
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Group

Minor modes in effect:
  gnus-undo-mode: t
  display-time-mode: t
  auto-image-file-mode: t
  show-paren-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  temp-buffer-resize-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x d <M-backspace> <M-backspace> d e b <tab> a <M-backspace> 
<M-backspace> <M-backspace> a p t i <tab> <return> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <return> C-x v l M-x s e t e n v <return> L 
A N G <return> C <return> C-x o C-x k <return> <return> 
C-x c l C-x o C-x k <return> C-x o C-x v l C-x o C-z 
C-x 1 M-x g n u s <return> M-x r e p o <tab> r t - 
e m <tab> <return>

Recent messages:
Opening nnfolder server on archive...done
Reading active file from archive via nnfolder...done
Opening nnfolder server...done
No new newsgroups
Checking new news...
Opening nnfolder server on archive...done
Opening nntp server on news.gnus.org...done
Opening nntp server on news.eternal-september.org...done
Checking new news...done
Making completion list...

Load-path shadows:
None found.

bug#4417: 23.1.50; vc-hg is broken in non-English locales

[Dan Nicolaescu]

Sven Joachim <svenjoac@gmx.de> writes:

  > Setting LANG to C works around the problems.  For the reference, this is
  > my mercurial version:
  > 
  > ,----
  > | % hg --version
  > | Mercurial Distributed SCM (version 1.3.1)
  > `----

I have:
hg --version
Mercurial Distributed SCM (version 1.3)

  > When opening a file in a mercurial-controlled directory, the modeline
  > shows "Hg-0" instead of the revision number in my de_DE.UTF-8 locale.
  > Moreover, after pressing "C-x v l", the *vc-change-log* buffer is
  > unfontified, and standard keys (d, f) do not work there, because hg's
  > output is in German:
  > 
  > ,----
  > | Änderung:        1587:1cdfa7c5503e
  > | Vorgänger:       1585:ef75fa728cca
  > | Nutzer:          Daniel Burrows <dburrows@debian.org>
  > | Datum:           Sun Jul 20 12:31:09 2008 -0700
  > | Zusammenfassung: Document how aptitude handles double-quotes.
  > `----

I can't reproduce this, doing:

env LANG=de_DE.UTF-8 hg log

does not print German headings.

so it looks like this might be a bug in 1.3.1 or maybe in your
installation.  Can you please check?

bug#4417: 23.1.50; vc-hg is broken in non-English locales

[Sven Joachim]

On 2009-09-22 20:14 +0200, Dan Nicolaescu wrote:

> Sven Joachim <svenjoac@gmx.de> writes:
>
>   > Setting LANG to C works around the problems.  For the reference, this is
>   > my mercurial version:
>   > 
>   > ,----
>   > | % hg --version
>   > | Mercurial Distributed SCM (version 1.3.1)
>   > `----
>
> I have:
> hg --version
> Mercurial Distributed SCM (version 1.3)

Should not matter, the German translation has apparently not been
updated between 1.3 and 1.3.1.

>   > When opening a file in a mercurial-controlled directory, the modeline
>   > shows "Hg-0" instead of the revision number in my de_DE.UTF-8 locale.
>   > Moreover, after pressing "C-x v l", the *vc-change-log* buffer is
>   > unfontified, and standard keys (d, f) do not work there, because hg's
>   > output is in German:
>   > 
>   > ,----
>   > | Änderung:        1587:1cdfa7c5503e
>   > | Vorgänger:       1585:ef75fa728cca
>   > | Nutzer:          Daniel Burrows <dburrows@debian.org>
>   > | Datum:           Sun Jul 20 12:31:09 2008 -0700
>   > | Zusammenfassung: Document how aptitude handles double-quotes.
>   > `----
>
> I can't reproduce this, doing:
>
> env LANG=de_DE.UTF-8 hg log
>
> does not print German headings.
>
> so it looks like this might be a bug in 1.3.1 or maybe in your
> installation.

Well, I would not call it a bug if a program puts out messages in a
language that it has been asked for.  I rather think it's a bug in your
installation that it does not do that. 

> Can you please check?

I'm not familiar with the gory details of Debian's Python setup.
The message catalog for mercurial is in a strange directory, namely
/usr/share/pyshared/mercurial/locale/de/LC_MESSAGES, rather than the
usual /usr/share/locale/de/LC_MESSAGES that all other programs use.

Sven

bug#4417: 23.1.50; vc-hg is broken in non-English locales

[Dan Nicolaescu]

Sven Joachim <svenjoac@gmx.de> writes:

  > When opening a file in a mercurial-controlled directory, the modeline
  > shows "Hg-0" instead of the revision number in my de_DE.UTF-8 locale.
  > Moreover, after pressing "C-x v l", the *vc-change-log* buffer is
  > unfontified, and standard keys (d, f) do not work there, because hg's
  > output is in German:
  > 
  > ,----
  > | Änderung:        1587:1cdfa7c5503e
  > | Vorgänger:       1585:ef75fa728cca
  > | Nutzer:          Daniel Burrows <dburrows@debian.org>
  > | Datum:           Sun Jul 20 12:31:09 2008 -0700
  > | Zusammenfassung: Document how aptitude handles double-quotes.
  > `----
  > 
  > Setting LANG to C works around the problems.  For the reference, this is
  > my mercurial version:
  > 
  > ,----
  > | % hg --version
  > | Mercurial Distributed SCM (version 1.3.1)
  > `----
  > 
  > In GNU Emacs 23.1.50.6 (i486-pc-linux-gnu, GTK+ Version 2.16.6)
  >  of 2009-09-12 on turtle
  > Windowing system distributor `The X.Org Foundation', version 11.0.10603000
  > configured using `configure  '--build=i486-linux-gnu' 'build_alias=i486-linux-gnu' 'CFLAGS=-DGTK_DISABLE_DEPRECATED -g -O2''

I still cannot reproduce this... but it's not unreasonable that it
happens.

The "Hg-0" problem happens because vc-hg parses the "hg log" output so
that it can get the version number to display in the modeline (in
`vc-hg-working-revision').
I'll check in a fix shortly.

For the C-x v l problem, would it be acceptable for vc-hg to force the
language to be C?  If not, then someone would have to write regexps that
match the  "hg log" entries in any language.

bug#4417: 23.1.50; vc-hg is broken in non-English locales

[Sven Joachim]

On 2009-12-14 18:12 +0100, Dan Nicolaescu wrote:

> The "Hg-0" problem happens because vc-hg parses the "hg log" output so
> that it can get the version number to display in the modeline (in
> `vc-hg-working-revision').
> I'll check in a fix shortly.

Thanks.

> For the C-x v l problem, would it be acceptable for vc-hg to force the
> language to be C?  If not, then someone would have to write regexps that
> match the  "hg log" entries in any language.

That latter approach might not scale too well, who knows in what
languages mercurial gets translated.  Forcing a C locale for hg's output
would be fine with me.

Sven

bug#4417: 23.1.50; vc-hg is broken in non-English locales

[Dan Nicolaescu]

Sven Joachim <svenjoac@gmx.de> writes:

  > On 2009-12-14 18:12 +0100, Dan Nicolaescu wrote:
  > > For the C-x v l problem, would it be acceptable for vc-hg to force the
  > > language to be C?  If not, then someone would have to write regexps that
  > > match the  "hg log" entries in any language.
  > 
  > That latter approach might not scale too well, who knows in what
  > languages mercurial gets translated.  Forcing a C locale for hg's output
  > would be fine with me.

Does C-x v g suffer from the same problem?
Do you know of anything else that might be affected?

bug#4417: 23.1.50; vc-hg is broken in non-English locales

[Sven Joachim]

On 2009-12-14 19:23 +0100, Dan Nicolaescu wrote:

> Sven Joachim <svenjoac@gmx.de> writes:
>
>   > On 2009-12-14 18:12 +0100, Dan Nicolaescu wrote:
>   > > For the C-x v l problem, would it be acceptable for vc-hg to force the
>   > > language to be C?  If not, then someone would have to write regexps that
>   > > match the  "hg log" entries in any language.
>   > 
>   > That latter approach might not scale too well, who knows in what
>   > languages mercurial gets translated.  Forcing a C locale for hg's output
>   > would be fine with me.
>
> Does C-x v g suffer from the same problem?

Not anymore since you fixed vc-hg-working-revision. :-)

> Do you know of anything else that might be affected?

Not offhand.

Cheers,
       Sven

bug#4417: vc-hg is broken in non-English locales

[Glenn Morris]

It looks to me like this is done; but please reopen if it is not.