From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 11028@debbugs.gnu.org
Subject: bug#11028: 24.0.94; bad lighter and menus for `text-scale-mode'
Date: Sun, 01 May 2016 22:22:20 +0200 [thread overview]
Message-ID: <87a8k9y1dv.fsf@gnus.org> (raw)
In-Reply-To: <83eg9lmtuh.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 01 May 2016 23:00:38 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Lars Ingebrigtsen <larsi@gnus.org>
>> Date: Sun, 01 May 2016 21:46:39 +0200
>> Cc: 11028@debbugs.gnu.org
>>
>> "Drew Adams" <drew.adams@oracle.com> writes:
>>
>> > -1
>> > -------------------
>> > Turn Off minor mode
>> > Help for minor mode
>>
>> [...]
>> (let* ((minor-mode (lookup-minor-mode-from-indicator indicator))
>> (mm-fun (or (get minor-mode :minor-mode-function) minor-mode)))
>>
>> Wow, that's a roundabout way of doing it... Anyway, we then have the
>> mode symbol... What about using a pretty version of the mode symbol as
>> the menu header? That would be "Text Scale Mode" in this case.
>
> What menu header? Drew was complaining about the tooltip, not the
> menu. When you actually click on the lighter, the pop-up menu does
> have a header that shows the mode name.
>
> So what are you trying to do here?
The thing with the "+1" at the top is a menu:
(setq menu
(if menu
(mouse-menu-non-singleton menu)
(if (fboundp mm-fun) ; bug#20201
`(keymap
,indicator
(turn-off menu-item "Turn off minor mode" ,mm-fun)
(help menu-item "Help for minor mode"
(lambda () (interactive)
(describe-function ',mm-fun)))))))
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-05-01 20:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 18:54 bug#11028: 24.0.94; bad lighter and menus for `text-scale-mode' Drew Adams
2012-09-17 0:07 ` Drew Adams
2016-04-28 14:01 ` Lars Ingebrigtsen
2016-05-01 19:38 ` Lars Ingebrigtsen
2016-05-01 19:46 ` Lars Ingebrigtsen
2016-05-01 20:00 ` Eli Zaretskii
2016-05-01 20:22 ` Lars Ingebrigtsen [this message]
2022-01-27 16:36 ` Lars Ingebrigtsen
2022-01-27 16:37 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8k9y1dv.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=11028@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).