From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#11028: 24.0.94; bad lighter and menus for `text-scale-mode' Date: Sun, 01 May 2016 22:22:20 +0200 Message-ID: <87a8k9y1dv.fsf@gnus.org> References: <0F3DD8B617604CB59C5138747164263F@us.oracle.com> <87k2jdy31c.fsf@gnus.org> <83eg9lmtuh.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1462134222 28913 80.91.229.3 (1 May 2016 20:23:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 May 2016 20:23:42 +0000 (UTC) Cc: 11028@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 01 22:23:31 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1awxtp-000815-T7 for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 May 2016 22:23:30 +0200 Original-Received: from localhost ([::1]:34204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awxtl-0004Zd-SO for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 May 2016 16:23:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awxtd-0004Pc-Hy for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 16:23:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awxtR-0007GY-G2 for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 16:23:12 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awxtR-0007Eu-D5 for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 16:23:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1awxtO-0007Uo-1w for bug-gnu-emacs@gnu.org; Sun, 01 May 2016 16:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 May 2016 20:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11028 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11028-submit@debbugs.gnu.org id=B11028.146213415328768 (code B ref 11028); Sun, 01 May 2016 20:23:02 +0000 Original-Received: (at 11028) by debbugs.gnu.org; 1 May 2016 20:22:33 +0000 Original-Received: from localhost ([127.0.0.1]:32824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awxss-0007Tt-DX for submit@debbugs.gnu.org; Sun, 01 May 2016 16:22:33 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:41054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awxsn-0007Th-LP for 11028@debbugs.gnu.org; Sun, 01 May 2016 16:22:29 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1awxsi-00022M-Oy; Sun, 01 May 2016 22:22:24 +0200 In-Reply-To: <83eg9lmtuh.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 01 May 2016 23:00:38 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117544 Archived-At: Eli Zaretskii writes: >> From: Lars Ingebrigtsen >> Date: Sun, 01 May 2016 21:46:39 +0200 >> Cc: 11028@debbugs.gnu.org >> >> "Drew Adams" writes: >> >> > -1 >> > ------------------- >> > Turn Off minor mode >> > Help for minor mode >> >> [...] >> (let* ((minor-mode (lookup-minor-mode-from-indicator indicator)) >> (mm-fun (or (get minor-mode :minor-mode-function) minor-mode))) >> >> Wow, that's a roundabout way of doing it... Anyway, we then have the >> mode symbol... What about using a pretty version of the mode symbol as >> the menu header? That would be "Text Scale Mode" in this case. > > What menu header? Drew was complaining about the tooltip, not the > menu. When you actually click on the lighter, the pop-up menu does > have a header that shows the mode name. > > So what are you trying to do here? The thing with the "+1" at the top is a menu: (setq menu (if menu (mouse-menu-non-singleton menu) (if (fboundp mm-fun) ; bug#20201 `(keymap ,indicator (turn-off menu-item "Turn off minor mode" ,mm-fun) (help menu-item "Help for minor mode" (lambda () (interactive) (describe-function ',mm-fun))))))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no