From: Tassilo Horn <tsdh@gnu.org>
To: 37578@debbugs.gnu.org
Cc: ynyaaa@gmail.com
Subject: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image)
Date: Wed, 23 Oct 2019 18:07:53 +0200 [thread overview]
Message-ID: <87a79rxx5y.fsf@gnu.org> (raw)
In-Reply-To: <handler.37578.D37578.157026619422912.notifdone@debbugs.gnu.org> (GNU bug Tracking System's message of "Sat, 05 Oct 2019 09:04:02 +0000")
help-debbugs@gnu.org (GNU bug Tracking System) writes:
Hi Eli,
>> When viewing a tall image with image-mode,
>> typing M-> shows bottom side of the image.
>> But the lowest edge is not displayed.
>
> image-mode.el was scrolling images vertically in units of canonical
> character height, so it couldn't handle the last portion of an image
> smaller than the height of one character.
>
> This is now fixed on the master branch.
Your change 9c66b09950cf2db50eb6d818656a268ef750bfe6 broke doc-view.el
and the pdf-tools package whose author already filed bug#37874 for the
issue.
Could you have a look? If the image functions stay returning pixel
values that's ok but Andreas and I will need to adapt pdf-tools and
doc-view.el accordingly.
Bye,
Tassilo
next prev parent reply other threads:[~2019-10-23 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 9:00 bug#37578: 26.3; image-mode does not display the bottom edge of a tall image ynyaaa
2019-10-02 20:04 ` Alan Third
2019-10-05 9:02 ` Eli Zaretskii
[not found] ` <handler.37578.D37578.157026619422912.notifdone@debbugs.gnu.org>
2019-10-23 16:07 ` Tassilo Horn [this message]
2019-10-23 17:58 ` bug#37874: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image) Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a79rxx5y.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=37578@debbugs.gnu.org \
--cc=ynyaaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).