From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image) Date: Wed, 23 Oct 2019 18:07:53 +0200 Message-ID: <87a79rxx5y.fsf@gnu.org> References: <83wodj4lab.fsf@gnu.org> <86muejsert.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="102758"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: ynyaaa@gmail.com To: 37578@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 23 18:37:53 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNJdw-000QZ3-8T for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 18:37:52 +0200 Original-Received: from localhost ([::1]:41348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNJdu-0006Ly-0K for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Oct 2019 12:37:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46064) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNJC3-0001oK-Gw for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 12:09:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNJC2-0003SX-0z for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 12:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54273) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNJC1-0003SQ-Tw for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 12:09:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iNJC1-0003aE-N1 for bug-gnu-emacs@gnu.org; Wed, 23 Oct 2019 12:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Oct 2019 16:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37578 X-GNU-PR-Package: emacs X-Debbugs-Original-To: help-debbugs@gnu.org (GNU bug Tracking System) X-Debbugs-Original-Cc: 37578@debbugs.gnu.org, ynyaaa@gmail.com, Eli Zaretskii Original-Received: via spool by 37578-submit@debbugs.gnu.org id=B37578.157184688813695 (code B ref 37578); Wed, 23 Oct 2019 16:09:01 +0000 Original-Received: (at 37578) by debbugs.gnu.org; 23 Oct 2019 16:08:08 +0000 Original-Received: from localhost ([127.0.0.1]:34861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNJBA-0003Yp-60 for submit@debbugs.gnu.org; Wed, 23 Oct 2019 12:08:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNJB6-0003YJ-Id for 37578@debbugs.gnu.org; Wed, 23 Oct 2019 12:08:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iNJB1-0002lq-AB; Wed, 23 Oct 2019 12:07:59 -0400 Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:38539) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1iNJAz-0006P2-JL; Wed, 23 Oct 2019 12:07:57 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 2D38321DFB; Wed, 23 Oct 2019 12:07:57 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 23 Oct 2019 12:07:57 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrkeelgdelkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufhffjgfkfgggtgesthdtredttdertdenucfhrhhomhepvfgrshhsihhl ohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucfkphepkeegrddufedvrdelle drgeeinecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnodhmvghsmhhtphgruhht hhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedvleekqdhtshguhheppe hgnhhurdhorhhgsehfrghsthhmrghilhdrfhhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Original-Received: from thinkpad-t440p (p5484632e.dip0.t-ipconnect.de [84.132.99.46]) by mail.messagingengine.com (Postfix) with ESMTPA id 4E843D6005B; Wed, 23 Oct 2019 12:07:56 -0400 (EDT) In-Reply-To: (GNU bug Tracking System's message of "Sat, 05 Oct 2019 09:04:02 +0000") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170077 Archived-At: help-debbugs@gnu.org (GNU bug Tracking System) writes: Hi Eli, >> When viewing a tall image with image-mode, >> typing M-> shows bottom side of the image. >> But the lowest edge is not displayed. > > image-mode.el was scrolling images vertically in units of canonical > character height, so it couldn't handle the last portion of an image > smaller than the height of one character. > > This is now fixed on the master branch. Your change 9c66b09950cf2db50eb6d818656a268ef750bfe6 broke doc-view.el and the pdf-tools package whose author already filed bug#37874 for the issue. Could you have a look? If the image functions stay returning pixel values that's ok but Andreas and I will need to adapt pdf-tools and doc-view.el accordingly. Bye, Tassilo