bug#24517: Please provide the feature ada-ref-man

bug#24517: Please provide the feature ada-ref-man

[Jonas Bernoulli]

ada-ref-man.el from GNU Elpa isn't a real library, it only exists so
that the Ada Reference Manual can be installed using `package.el', which
expects a package to contain a library matching the package name.

Similarly the tools used to maintain the Emacsmirror impose such
restrictions on the mirrored packages.  In particular they are a bit
more fussy about the "main library" of the package.  In addition to
expecting the main library to have the "correct name", they also insist
on that library providing the matching feature.

Please consider adding (provide 'ada-ref-man) to ada-ref-man.el.
Considering that ada-ref-man.el only exists in the first place to
satisfy a tool, I don't think we would go to far if it additionally
provided the feature to satisfy another tool.

  Thanks,
  Jonas

bug#24517: Please provide the feature uni-confusables

[Jonas Bernoulli]

Please also consider providing the appropriate
feature in uni-confusables.el, also in GNU Elpa.

bug#24517: Please provide the feature ada-ref-man

[Stefan Kangas]

Jonas Bernoulli <jonas@bernoul.li> writes:

> ada-ref-man.el from GNU Elpa isn't a real library, it only exists so
> that the Ada Reference Manual can be installed using `package.el', which
> expects a package to contain a library matching the package name.
>
> Similarly the tools used to maintain the Emacsmirror impose such
> restrictions on the mirrored packages.  In particular they are a bit
> more fussy about the "main library" of the package.  In addition to
> expecting the main library to have the "correct name", they also insist
> on that library providing the matching feature.
>
> Please consider adding (provide 'ada-ref-man) to ada-ref-man.el.
> Considering that ada-ref-man.el only exists in the first place to
> satisfy a tool, I don't think we would go to far if it additionally
> provided the feature to satisfy another tool.
>
>   Thanks,
>   Jonas

Jonas Bernoulli <jonas@bernoul.li> writes:

> Please also consider providing the appropriate
> feature in uni-confusables.el, also in GNU Elpa.

Hi Jonas,

This request was sent 3 years ago, but it unfortunately never got a
reply at the time.  Is this still relevant?

Best regards,
Stefan Kangas

bug#24517: Please provide the feature ada-ref-man

[Jonas Bernoulli]

Stefan Kangas <stefan@marxist.se> writes:

> This request was sent 3 years ago, but it unfortunately never got a
> reply at the time.  Is this still relevant?

These requests are still relevant.

* In the case of ada-ref-man I ended up not mirroring it.  (Making it
  the only package from Emacs, including Elpa, that isn't mirrored on
  the Emacsmirror.)

* In the case of uni-confusables I ended up pretending
  "gen-confusables.el" is the "main library" resulting in the rather odd
  and incorrect package description "generate uni-confusables.el from
  confusables.txt".

  In addition to the provide form I would recommend adding a Commentary
  section to the library so that that longer description shows up at
  https://elpa.gnu.org/packages/uni-confusables.html among other places.

  I just tried looking at uni-confusables.el using Emacs and despite
  global-so-long-mode being enabled I ended up having to kill emacs.
  So maybe a few newline characters could be added as well.

Cheers,
Jonas

bug#24517: Please provide the feature ada-ref-man

[Stefan Kangas]

[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]

Jonas Bernoulli <jonas@bernoul.li> writes:

> Stefan Kangas <stefan@marxist.se> writes:
>
>> This request was sent 3 years ago, but it unfortunately never got a
>> reply at the time.  Is this still relevant?
>
> These requests are still relevant.
>
> * In the case of ada-ref-man I ended up not mirroring it.  (Making it
>   the only package from Emacs, including Elpa, that isn't mirrored on
>   the Emacsmirror.)
>
> * In the case of uni-confusables I ended up pretending
>   "gen-confusables.el" is the "main library" resulting in the rather odd
>   and incorrect package description "generate uni-confusables.el from
>   confusables.txt".

Does anyone object to the attached patch?

>   In addition to the provide form I would recommend adding a Commentary
>   section to the library so that that longer description shows up at
>   https://elpa.gnu.org/packages/uni-confusables.html among other places.

Could someone help with this?  I don't know what this is used for.
Teodor perhaps?

>   I just tried looking at uni-confusables.el using Emacs and despite
>   global-so-long-mode being enabled I ended up having to kill emacs.
>   So maybe a few newline characters could be added as well.

I'm seeing the same thing here.  Maybe that should be reported as a
separate bug.

Best regards,
Stefan Kangas


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-provide-statements-to-ada-ref-man-and-uni-confus.patch --]
[-- Type: text/x-diff, Size: 1249 bytes --]

From 447fcb04d526b460eccc976cd0b4b603e61454ed Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Thu, 7 Nov 2019 00:07:57 +0100
Subject: [PATCH] Add provide-statements to ada-ref-man and uni-confusables

* packages/ada-ref-man/ada-ref-man.el:
* packages/uni-confusables/uni-confusables.el: Add provide statements for
compatibility with emacs-mirror tools.  (Bug#24517)
---
 packages/ada-ref-man/ada-ref-man.el         | 2 ++
 packages/uni-confusables/uni-confusables.el | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/packages/ada-ref-man/ada-ref-man.el b/packages/ada-ref-man/ada-ref-man.el
index 7c7cbf7f0..d8e4a7d4e 100644
--- a/packages/ada-ref-man/ada-ref-man.el
+++ b/packages/ada-ref-man/ada-ref-man.el
@@ -10,4 +10,6 @@
 ;; Version: 2012.5
 ;; url: http://stephe-leake.org/ada/arm.html
 
+(provide 'ada-ref-man)
+
 ;;; ada-ref-man.el ends here
diff --git a/packages/uni-confusables/uni-confusables.el b/packages/uni-confusables/uni-confusables.el
index cf8b20bfc..4e182d803 100644
--- a/packages/uni-confusables/uni-confusables.el
+++ b/packages/uni-confusables/uni-confusables.el
@@ -80,4 +80,6 @@
 ;; no-byte-compile: t
 ;; End:
 
+(provide 'uni-confusables)
+
 ;;; uni-confusables.el ends here
-- 
2.20.1

bug#24517: Please provide the feature ada-ref-man

[Stefan Kangas]

Stefan Kangas <stefan@marxist.se> writes:

>> * In the case of ada-ref-man I ended up not mirroring it.  (Making it
>>   the only package from Emacs, including Elpa, that isn't mirrored on
>>   the Emacsmirror.)
>>
>> * In the case of uni-confusables I ended up pretending
>>   "gen-confusables.el" is the "main library" resulting in the rather odd
>>   and incorrect package description "generate uni-confusables.el from
>>   confusables.txt".
>
> Does anyone object to the attached patch?

No objections within 39 weeks, so I've pushed the patch to elpa.git as
commit c7e0e5bfa.

>>   In addition to the provide form I would recommend adding a Commentary
>>   section to the library so that that longer description shows up at
>>   https://elpa.gnu.org/packages/uni-confusables.html among other places.
>
> Could someone help with this?  I don't know what this is used for.
> Teodor perhaps?
>
>>   I just tried looking at uni-confusables.el using Emacs and despite
>>   global-so-long-mode being enabled I ended up having to kill emacs.
>>   So maybe a few newline characters could be added as well.
>
> I'm seeing the same thing here.  Maybe that should be reported as a
> separate bug.

The above still needs fixing.

Best regards,
Stefan Kangas

bug#24517: Please provide the feature ada-ref-man

[Lars Ingebrigtsen]

Stefan Kangas <stefan@marxist.se> writes:

>>>   I just tried looking at uni-confusables.el using Emacs and despite
>>>   global-so-long-mode being enabled I ended up having to kill emacs.
>>>   So maybe a few newline characters could be added as well.
>>
>> I'm seeing the same thing here.  Maybe that should be reported as a
>> separate bug.
>
> The above still needs fixing.

I've now done so.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no