bug#17272: 24.4.50; obsolete messages hides warning on startup

bug#17272: 24.4.50; obsolete messages hides warning on startup

[Robert Marshall]

If you start emacs with the following loaded file (emacs -Q -l .emacs.test)

;;; .emacs.test
(require 'longlines)
(desktop-save-mode 1)
(desktop-read "/home/robert") ;; $HOME....

When it starts you see the message

     Package longlines is obsolete!

But - if the .emacs.desktop is locked the message:

    Warning: desktop file appears to be in use by PID 6464.
    Using it may cause conflicts.  Use it anyway? (y or n) 

is hiding 'behind' the obsolete message and you don't see it until you
press a key - the emacs startup appears to have stopped but there's no
visual clue as to what it is waiting for. 


In GNU Emacs 24.4.50.4 (i686-pc-linux-gnu, GTK+ Version 3.8.6)
 of 2014-04-09 on poulenc
Repository revision: 116959 dancol@dancol.org-20140409081641-wcask11smm10bk3f
Windowing system distributor `The X.Org Foundation', version 11.0.11405000
System Description:	Ubuntu 13.10

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB

Important settings:
  value of $LANG: en_GB.UTF-8
  locale-coding-system: utf-8-unix

Robert
-- 
Robert Marshall

bug#17272: 24.4.50; obsolete messages hides warning on startup

[Juri Linkov]

> If you start emacs with the following loaded file (emacs -Q -l .emacs.test)
>
> ;;; .emacs.test
> (require 'longlines)
> (desktop-save-mode 1)
> (desktop-read "/home/robert") ;; $HOME....
>
> When it starts you see the message
>
>      Package longlines is obsolete!
>
> But - if the .emacs.desktop is locked the message:
>
>     Warning: desktop file appears to be in use by PID 6464.
>     Using it may cause conflicts.  Use it anyway? (y or n) 
>
> is hiding 'behind' the obsolete message and you don't see it until you
> press a key - the emacs startup appears to have stopped but there's no
> visual clue as to what it is waiting for. 

Here is the patch that fixes this (required changes from bug#38076):

diff --git a/lisp/subr.el b/lisp/subr.el
index 03cf3da278..33464d6032 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -4517,7 +4556,9 @@ do-after-load-evaluation
 	      (byte-compile-warn "%s" msg))
 	  (run-with-timer 0 nil
 			  (lambda (msg)
-			    (message "%s" msg))
+                            (if (minibufferp)
+                                (minibuffer-message "%s" msg)
+                              (message "%s" msg)))
                           msg)))))
 
   ;; Finally, run any other hook.

bug#17272: 24.4.50; obsolete messages hides warning on startup

[Juri Linkov]

> If you start emacs with the following loaded file (emacs -Q -l .emacs.test)
>
> ;;; .emacs.test
> (require 'longlines)
> (desktop-save-mode 1)
> (desktop-read "/home/robert") ;; $HOME....
>
> When it starts you see the message
>
>      Package longlines is obsolete!
>
> But - if the .emacs.desktop is locked the message:
>
>     Warning: desktop file appears to be in use by PID 6464.
>     Using it may cause conflicts.  Use it anyway? (y or n) 
>
> is hiding 'behind' the obsolete message and you don't see it until you
> press a key - the emacs startup appears to have stopped but there's no
> visual clue as to what it is waiting for. 

This is fixed now.