From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 39823@debbugs.gnu.org, rms@gnu.org
Subject: bug#39823: 26.3; update-directory-autoloads regression from Emacs 26 to Emacs 27
Date: Tue, 23 Jun 2020 16:42:33 -0400 [thread overview]
Message-ID: <87a70tms3q.fsf@gmail.com> (raw)
In-Reply-To: <85tuz3f8b6.fsf@gmail.com> (Noam Postavsky's message of "Mon, 22 Jun 2020 11:07:25 -0400")
Hello Noam,
Noam Postavsky <npostavs@gmail.com> writes:
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> + (let* (;; Honor the :generated-autoload-file keyword argument.
>> + (generated-autoload-file-arg (seq-position
>> + dirs ':generated-autoload-file))
>> + (generated-autoload-file (if generated-autoload-file-arg
>> + (elt dirs
>> + (1+ generated-autoload-file-arg))
>> + generated-autoload-file))
>> + ;; Cleanup dirs from such keyword argument, if any.
>> + (dirs (if generated-autoload-file-arg
>> + (delete generated-autoload-file
>> + (delete ':generated-autoload-file dirs))
>> + dirs))
>
> How about
>
> (let* ((generated-autoload-file
> (if (eq (car dirs) :generated-autoload-file)
> (progn (pop dirs) (pop dirs))
> generated-autoload-file))
That's much simpler, which is nice! The only drawback is that it
requires the keyword argument to be used as the first argument when
provided (mine didn't have such restriction).
Provided the docstring reflects this, I'm OK with it :-).
Thank you,
Maxim
next prev parent reply other threads:[~2020-06-23 20:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 15:11 bug#39823: 26.3; update-directory-autoloads regression from Emacs 26 to Emacs 27 Maxim Cournoyer
2020-03-13 0:43 ` Noam Postavsky
2020-03-13 8:30 ` Eli Zaretskii
2020-03-14 2:06 ` Maxim Cournoyer
2020-03-13 23:01 ` Michael Heerdegen
2020-03-14 2:03 ` Maxim Cournoyer
2020-03-17 11:48 ` Noam Postavsky
2020-03-14 3:34 ` Richard Stallman
2020-03-17 2:16 ` Maxim Cournoyer
2020-03-19 1:46 ` Richard Stallman
2020-04-08 3:55 ` Maxim Cournoyer
2020-04-08 6:31 ` Eli Zaretskii
2020-04-08 16:41 ` Maxim Cournoyer
2020-04-08 19:09 ` Eli Zaretskii
2020-04-19 3:13 ` Maxim Cournoyer
2020-04-19 12:19 ` Noam Postavsky
2020-06-22 4:10 ` Maxim Cournoyer
2020-06-22 15:07 ` Noam Postavsky
2020-06-23 20:42 ` Maxim Cournoyer [this message]
2020-09-30 15:23 ` Lars Ingebrigtsen
2020-10-01 17:20 ` Lars Ingebrigtsen
2020-10-01 17:54 ` Eli Zaretskii
2020-10-01 18:06 ` Lars Ingebrigtsen
2020-10-02 2:36 ` Lars Ingebrigtsen
2020-10-02 17:54 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a70tms3q.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=39823@debbugs.gnu.org \
--cc=npostavs@gmail.com \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).