From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Maxim Cournoyer Newsgroups: gmane.emacs.bugs Subject: bug#39823: 26.3; update-directory-autoloads regression from Emacs 26 to Emacs 27 Date: Tue, 23 Jun 2020 16:42:33 -0400 Message-ID: <87a70tms3q.fsf@gmail.com> References: <87zhd2lpad.fsf@gmail.com> <87o8t16q5e.fsf@gmail.com> <87y2rz4tgb.fsf@gmail.com> <87blo2k4wp.fsf@gmail.com> <83369eqyij.fsf@gnu.org> <87wo6qhqvd.fsf@gmail.com> <835ze9pzfq.fsf@gnu.org> <87mu78jhgz.fsf@gmail.com> <868sir8y85.fsf@gmail.com> <87mu4vn3kz.fsf@gmail.com> <85tuz3f8b6.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="123282"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 39823@debbugs.gnu.org, rms@gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 23 22:43:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnpl9-000VyK-PP for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Jun 2020 22:43:11 +0200 Original-Received: from localhost ([::1]:52990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnpl8-00077L-Ob for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Jun 2020 16:43:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnpl0-000770-Qo for bug-gnu-emacs@gnu.org; Tue, 23 Jun 2020 16:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53845) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jnpl0-0007I1-Gy for bug-gnu-emacs@gnu.org; Tue, 23 Jun 2020 16:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jnpl0-0002Op-Eh for bug-gnu-emacs@gnu.org; Tue, 23 Jun 2020 16:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jun 2020 20:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39823 X-GNU-PR-Package: emacs Original-Received: via spool by 39823-submit@debbugs.gnu.org id=B39823.15929449639182 (code B ref 39823); Tue, 23 Jun 2020 20:43:02 +0000 Original-Received: (at 39823) by debbugs.gnu.org; 23 Jun 2020 20:42:43 +0000 Original-Received: from localhost ([127.0.0.1]:37158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnpkh-0002O2-Kr for submit@debbugs.gnu.org; Tue, 23 Jun 2020 16:42:43 -0400 Original-Received: from mail-qk1-f177.google.com ([209.85.222.177]:39252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnpke-0002Nc-NI for 39823@debbugs.gnu.org; Tue, 23 Jun 2020 16:42:41 -0400 Original-Received: by mail-qk1-f177.google.com with SMTP id l6so16521389qkc.6 for <39823@debbugs.gnu.org>; Tue, 23 Jun 2020 13:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=FjEBtuuaaZq38rf64zFYpWK2ozA4zUccxa8934+ZhvI=; b=nqfdGEZ2dJrGyRnOteawIXLpG+KWq25vTM1i043br3NarDq/uUiWz36Ofw74mmr9Fp CL4ZqMpqT3zRh4ExBtI9L2EN7GYYZDfoNslA4KDWlomweX3Pw0PmP5GkKf5N0qctMrId iuU9giTABn/QaWt/toxZrFozgbE650Q6HUSEjBCHLvFuugvVslFAnud8ikyjZigplfTo SRElrdJH1G9eQXP3kNOdKnltbx94JIWJ0+P7yvIuDiUoQiDDxOYmSSJL48F7R+QzQRPZ Dcftf64tlthEc3LlYr1eMvP6jvZpK1PJ9WclmfV5bUlSXESPlMhN4WVTAgZwW6XeS2i+ bQiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=FjEBtuuaaZq38rf64zFYpWK2ozA4zUccxa8934+ZhvI=; b=UebizITpUxn20Z4nYajvkG9XrAtGM8vI21NKUNi2fyxHyZm7QE/Rh+HU7m/ucC2cJd kPihVlMaDbkZGsTC2fX7+mS3a5Pxv+A9JBln1H/yqq1VFvFxvr2Lx/l3nqquSi1C8eJ8 MgOnvluxz0jBph6ucGOjhKonzbtPstuj+vF+7EQAJ26w6JP4zhYqm/C4QAHdFvcVmRDx B8ywrw5eaVbkZ/Jxa7kWtTTjs9RVFPf9T+euUCJ7aFrxe8nJpDpijzRnEbcCBY9PC6GM wWX8pP+HWkLD4Ih7RrjevnK3sM5cbWuDXDkKaWji0DULEXY2LqoU6OTHmRdZdk/YZwn1 G+Sw== X-Gm-Message-State: AOAM533Q7bTTVx2EAHWkM6UsCIy3vkImqKO+zAwe17vIRZcg7Zz8VKti pIT9QNGUT2m79dU168bjtLY= X-Google-Smtp-Source: ABdhPJy2qSbhgbbEDs8TMgKaBWu5+5hwOR0HRWRAw/zaR/gJp5zpGKlu6hqpO1vkF9Coa7aaismfQA== X-Received: by 2002:a05:620a:56c:: with SMTP id p12mr12518125qkp.433.1592944955158; Tue, 23 Jun 2020 13:42:35 -0700 (PDT) Original-Received: from hurd (dsl-10-134-241.b2b2c.ca. [72.10.134.241]) by smtp.gmail.com with ESMTPSA id n64sm1374748qke.77.2020.06.23.13.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2020 13:42:34 -0700 (PDT) In-Reply-To: <85tuz3f8b6.fsf@gmail.com> (Noam Postavsky's message of "Mon, 22 Jun 2020 11:07:25 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182325 Archived-At: Hello Noam, Noam Postavsky writes: > Maxim Cournoyer writes: > >> + (let* (;; Honor the :generated-autoload-file keyword argument. >> + (generated-autoload-file-arg (seq-position >> + dirs ':generated-autoload-file)) >> + (generated-autoload-file (if generated-autoload-file-arg >> + (elt dirs >> + (1+ generated-autoload-file-arg)) >> + generated-autoload-file)) >> + ;; Cleanup dirs from such keyword argument, if any. >> + (dirs (if generated-autoload-file-arg >> + (delete generated-autoload-file >> + (delete ':generated-autoload-file dirs)) >> + dirs)) > > How about > > (let* ((generated-autoload-file > (if (eq (car dirs) :generated-autoload-file) > (progn (pop dirs) (pop dirs)) > generated-autoload-file)) That's much simpler, which is nice! The only drawback is that it requires the keyword argument to be used as the first argument when provided (mine didn't have such restriction). Provided the docstring reflects this, I'm OK with it :-). Thank you, Maxim