bug#44358: 27.1; holidays.el

bug#44358: 27.1; holidays.el

[André Alexandre Gomes]

Notice the comment in calendar-holidays, in the holidays.el package.  It
shouldn't be autoloaded.

Thanks.

--
André Alexandre Gomes
"Free Thought, Free World"

bug#44358: 27.1; holidays.el

[Glenn Morris]

André Alexandre Gomes wrote:

> Notice the comment in calendar-holidays, in the holidays.el package.  It
> shouldn't be autoloaded.

The variable calendar-holidays isn't autoloaded. What is your bug report?
(Perhaps you were misled by help-enable-completion-autoload?)

bug#44358: 27.1; holidays.el

[André Alexandre Gomes]

Glenn Morris <rgm@gnu.org> writes:

> André Alexandre Gomes wrote:
>
>> Notice the comment in calendar-holidays, in the holidays.el package.  It
>> shouldn't be autoloaded.
>
> The variable calendar-holidays isn't autoloaded. What is your bug report?
> (Perhaps you were misled by help-enable-completion-autoload?)

In my init.el I have customized variable such as
holiday-general-holidays.  However, if I run M-x list-holidays, I notice
that my changes aren't respected.

In the source code of holidays.el one can read:

;; This one should not be autoloaded, else .emacs changes of
;; holiday-general-holidays etc have no effect.
;; FIXME should have some :set-after.

Hope this helps.

--
André Alexandre Gomes
"Free Thought, Free World"

bug#44358: 27.1; holidays.el

[André Alexandre Gomes]

Hi Glenn Morris,

André Alexandre Gomes <andremegafone@gmail.com> writes:

> In my init.el I have customized variable such as
> holiday-general-holidays.  However, if I run M-x list-holidays, I notice
> that my changes aren't respected.
>
> In the source code of holidays.el one can read:
>
> ;; This one should not be autoloaded, else .emacs changes of
> ;; holiday-general-holidays etc have no effect.
> ;; FIXME should have some :set-after.

Sorry to bother again but is there any workaround this?

It seems that I need to run the following s-exp

(setq calendar-holidays (append holiday-general-holidays
                                holiday-local-holidays
                                holiday-other-holidays
                                holiday-christian-holidays
                                holiday-hebrew-holidays
                                holiday-islamic-holidays
                                holiday-bahai-holidays
                                holiday-oriental-holidays
                                holiday-solar-holidays))

everytime I open Emacs so that my configuration is respected.

Thanks.


-- 
André Alexandre Gomes
"Free Thought, Free World"

bug#44358: 27.1; holidays.el

[Glenn Morris]

Please use reply-to-all.

Works fine here.
I guess something in your .emacs loads holidays.el too early.

Tested with:

mkdir /tmp/foo
cat <<EOF > /tmp/foo/.emacs
(setq holiday-general-holidays '((holiday-fixed 1 1 "Special Day")))
EOF

HOME=/tmp/foo emacs-27.1
C-h v calendar-holidays

bug#44358: 27.1; holidays.el

[André Alexandre Gomes]

Glenn Morris <rgm@gnu.org> writes:

> Please use reply-to-all.

Oops!

> Works fine here.
> I guess something in your .emacs loads holidays.el too early.

Indeed, it is due to use-package.  I'm sure why, but the following

(use-package holidays
  :config
  (setq holiday-general-holidays '((holiday-fixed 1 1 "Special Day"))))

isn't equivalent to:

(setq holiday-general-holidays '((holiday-fixed 1 1 "Special Day")))

Thank you!

--
André Alexandre Gomes
"Free Thought, Free World"

bug#44358: 27.1; holidays.el

[Basil L. Contovounesios]

André Alexandre Gomes <andremegafone@gmail.com> writes:

> I'm sure why, but the following
>
> (use-package holidays
>   :config
>   (setq holiday-general-holidays '((holiday-fixed 1 1 "Special Day"))))
>
> isn't equivalent to:
>
> (setq holiday-general-holidays '((holiday-fixed 1 1 "Special Day")))

That is because (use-package X :config Y)
translates to (with-eval-after-load 'X Y),
i.e. Y gets evaluated only after X is loaded.

Try using :init or :custom instead.

Is there something left to solve here, or can this bug report be closed?

Thanks,

-- 
Basil

bug#44358: 27.1; holidays.el

[André Alexandre Gomes]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> André Alexandre Gomes <andremegafone@gmail.com> writes:
>
>> I'm sure why, but the following
>>
>> (use-package holidays
>>   :config
>>   (setq holiday-general-holidays '((holiday-fixed 1 1 "Special Day"))))
>>
>> isn't equivalent to:
>>
>> (setq holiday-general-holidays '((holiday-fixed 1 1 "Special Day")))
>
> That is because (use-package X :config Y)
> translates to (with-eval-after-load 'X Y),
> i.e. Y gets evaluated only after X is loaded.

I see.

> Try using :init or :custom instead.

:custom exhibits the same behaviour as with :config.  :init works great.

> Is there something left to solve here, or can this bug report be closed?

It can be closed.  Thank you.

--
André Alexandre Gomes
"Free Thought, Free World"

bug#44358: 27.1; holidays.el

[Basil L. Contovounesios]

tags 44358 - moreinfo
tags 44358 + notabug
close 44358
quit

André Alexandre Gomes <andremegafone@gmail.com> writes:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> Is there something left to solve here, or can this bug report be closed?
>
> It can be closed.  Thank you.

Thanks, done.

-- 
Basil