unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#49018: 28.0.50; [PATCH] Add tex-start-options to tex-compile-commands
@ 2021-06-14  9:36 Utkarsh Singh
  2021-06-14 13:15 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Utkarsh Singh @ 2021-06-14  9:36 UTC (permalink / raw)
  To: 49018

Hi,

Tex-mode support a defcustom called `tex-start-options' which can be
used to provide command line options to Tex programs but
`tex-compile-command' variable ignores this defcustom which is used in
function `tex-compile' to compile Tex documents.

LaTex provides a package called 'minted' which is a generic syntax
highlighter, it requires '--shell-escape' as command line option to work
properly.

From 22eb119d897077ad42c7d345977979e385bd16ed Mon Sep 17 00:00:00 2001
From: Utkarsh Singh <utkarsh190601@gmail.com>
Date: Mon, 14 Jun 2021 14:51:23 +0530
Subject: [PATCH] tex-mode.el: Add tex-start-options to tex-compile-commands

---
 lisp/textmodes/tex-mode.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/textmodes/tex-mode.el b/lisp/textmodes/tex-mode.el
index a805c8952f..8b8108cb97 100644
--- a/lisp/textmodes/tex-mode.el
+++ b/lisp/textmodes/tex-mode.el
@@ -2132,6 +2132,7 @@ tex-use-reftex
 (defvar tex-compile-commands
   `(,@(mapcar (lambda (prefix)
                 `((concat ,prefix tex-command
+                          " " tex-start-options
                           " " (if (< 0 (length tex-start-commands))
                                   (shell-quote-argument tex-start-commands))
                           " %f")
-- 
2.32.0

-- 
Utkarsh Singh
http://utkarshsingh.xyz





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#49018: 28.0.50; [PATCH] Add tex-start-options to tex-compile-commands
  2021-06-14  9:36 bug#49018: 28.0.50; [PATCH] Add tex-start-options to tex-compile-commands Utkarsh Singh
@ 2021-06-14 13:15 ` Lars Ingebrigtsen
  2021-06-14 17:10   ` Utkarsh Singh
  0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-06-14 13:15 UTC (permalink / raw)
  To: Utkarsh Singh; +Cc: 49018

Utkarsh Singh <utkarsh190601@gmail.com> writes:

> Subject: [PATCH] tex-mode.el: Add tex-start-options to tex-compile-commands

Makes sense, I think.  However, even if this is a very small patch,
there's already four patches from you in Emacs, so I think this would
put you over the limit as to what we can accept without copyright
assignment for the FSF.  I forget -- did you already start that process?
If not, would you be willing to do so?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#49018: 28.0.50; [PATCH] Add tex-start-options to tex-compile-commands
  2021-06-14 13:15 ` Lars Ingebrigtsen
@ 2021-06-14 17:10   ` Utkarsh Singh
  2021-06-15 13:48     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Utkarsh Singh @ 2021-06-14 17:10 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 49018

Hi Lars,

On 2021-06-14, 15:15 +0200, Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Makes sense, I think.  However, even if this is a very small patch,
> there's already four patches from you in Emacs, so I think this would
> put you over the limit as to what we can accept without copyright
> assignment for the FSF.  I forget -- did you already start that process?
> If not, would you be willing to do so?

Currently my copyright assignment is being processed, actually I am the
one causing the delay.  I will update you when it's completed.

-- 
Utkarsh Singh
http://utkarshsingh.xyz





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#49018: 28.0.50; [PATCH] Add tex-start-options to tex-compile-commands
  2021-06-14 17:10   ` Utkarsh Singh
@ 2021-06-15 13:48     ` Lars Ingebrigtsen
  2021-06-22  3:39       ` Utkarsh Singh
  0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-06-15 13:48 UTC (permalink / raw)
  To: Utkarsh Singh; +Cc: 49018

Utkarsh Singh <utkarsh190601@gmail.com> writes:

> Currently my copyright assignment is being processed, actually I am the
> one causing the delay.  I will update you when it's completed.

Great.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#49018: 28.0.50; [PATCH] Add tex-start-options to tex-compile-commands
  2021-06-15 13:48     ` Lars Ingebrigtsen
@ 2021-06-22  3:39       ` Utkarsh Singh
  2021-06-22 13:08         ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Utkarsh Singh @ 2021-06-22  3:39 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 49018

Hi Lars,

On 2021-06-15, 15:48 +0200, Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Utkarsh Singh <utkarsh190601@gmail.com> writes:
>
>> Currently my copyright assignment is being processed, actually I am the
>> one causing the delay.  I will update you when it's completed.
>
> Great.  :-)

My CLA has been completed on 2021-06-21.

Thank you,
Utkarsh Singh

-- 
Utkarsh Singh
http://utkarshsingh.xyz





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#49018: 28.0.50; [PATCH] Add tex-start-options to tex-compile-commands
  2021-06-22  3:39       ` Utkarsh Singh
@ 2021-06-22 13:08         ` Lars Ingebrigtsen
  0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-06-22 13:08 UTC (permalink / raw)
  To: Utkarsh Singh; +Cc: 49018

Utkarsh Singh <utkarsh190601@gmail.com> writes:

> My CLA has been completed on 2021-06-21.

Great; I've now applied and pushed your patch to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-06-22 13:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-14  9:36 bug#49018: 28.0.50; [PATCH] Add tex-start-options to tex-compile-commands Utkarsh Singh
2021-06-14 13:15 ` Lars Ingebrigtsen
2021-06-14 17:10   ` Utkarsh Singh
2021-06-15 13:48     ` Lars Ingebrigtsen
2021-06-22  3:39       ` Utkarsh Singh
2021-06-22 13:08         ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).