bug#55944: [PATCH] Fix dns-mode-font-lock-keywords

bug#55944: [PATCH] Fix dns-mode-font-lock-keywords

[Lassi Kortela]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

Attached is a simple fix to the syntax highlighting of dns-mode.

For example, IN and SOA are reserved words. Instead of highlighting only 
the full words IN and SOA, dns-mode would highlight any word that has IN 
or SOA as a substring. This patch fixes the use of regexp-opt such that 
reserved words are only highlighted when they are full words.

[-- Attachment #2: dns-mode-font-lock-keywords.patch --]
[-- Type: text/plain, Size: 782 bytes --]

--- dns-mode.el.orig	2022-06-13 13:25:03.000000000 +0300
+++ dns-mode.el	2022-06-13 13:31:15.000000000 +0300
@@ -110,11 +110,11 @@
 			"26.1" 'set)
 
 (defcustom dns-mode-font-lock-keywords
-  `((,(concat "^\\$" (regexp-opt dns-mode-control-entities))
+  `((,(concat "^\\$" (regexp-opt dns-mode-control-entities) "\\>")
      0 ,dns-mode-control-entity-face)
     ("^\\$[a-z0-9A-Z]+" 0 ,dns-mode-bad-control-entity-face)
-    (,(regexp-opt dns-mode-classes) 0 ,dns-mode-class-face)
-    (,(regexp-opt dns-mode-types) 0 ,dns-mode-type-face))
+    (,(regexp-opt dns-mode-classes 'words) 0 ,dns-mode-class-face)
+    (,(regexp-opt dns-mode-types 'words) 0 ,dns-mode-type-face))
   "Font lock keywords used to highlight text in DNS master file mode."
   :version "26.1"
   :type 'sexp)

bug#55944: [PATCH] Fix dns-mode-font-lock-keywords

[Lars Ingebrigtsen]

Lassi Kortela <lassi@lassi.io> writes:

> Attached is a simple fix to the syntax highlighting of dns-mode.
>
> For example, IN and SOA are reserved words. Instead of highlighting
> only the full words IN and SOA, dns-mode would highlight any word that
> has IN or SOA as a substring. This patch fixes the use of regexp-opt
> such that reserved words are only highlighted when they are full
> words.

Thanks; pushed to Emacs 29.

This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?