From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Augusto Stoffel <arstoffel@gmail.com>, 61553@debbugs.gnu.org
Subject: bug#61553: 29.0.60; Inconsistent use of dialog boxes by read-multiple-choice
Date: Fri, 17 Feb 2023 11:24:09 +0100 [thread overview]
Message-ID: <87a61c37zq.fsf@gmail.com> (raw)
In-Reply-To: <83a61d2wmp.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Feb 2023 22:17:18 +0200")
>>>>> On Thu, 16 Feb 2023 22:17:18 +0200, Eli Zaretskii <eliz@gnu.org> said:
>> So instead of adding a special case for kill-buffer, I would rather
>> modify the behavior of RMC to just ignore the long-form argument if
>> (use-dialog-box-p) returns t. Apart from that, your patch seems fine.
Eli> I disagree that rmc.el should make that decision. It isn't its call
Eli> (pun intended).
If we do this then we need to modify the docstring of
`read-multiple-choice', which explicitly defines the current
behaviour:
When `use-dialog-box' is t (the default), and the command using this
function was invoked via the mouse, this function pops up a GUI dialog
to collect the user input, but only if Emacs is capable of using GUI
dialogs. Otherwise, the function will always use text-mode dialogs.
The return value is the matching entry from the CHOICES list.
If LONG-FORM, do a `completing-read' over the NAME elements in
CHOICES instead.
Although perhaps we could clarify it:
If LONG-FORM, always do a `completing-read' over the NAME elements in
CHOICES instead, regardless of the value of `use-dialog-box'.
Robert
--
next prev parent reply other threads:[~2023-02-17 10:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 16:19 bug#61553: 29.0.60; Inconsistent use of dialog boxes by read-multiple-choice Augusto Stoffel
2023-02-16 17:59 ` Eli Zaretskii
2023-02-16 18:36 ` Augusto Stoffel
2023-02-16 20:17 ` Eli Zaretskii
2023-02-17 10:24 ` Robert Pluim [this message]
2023-02-17 12:31 ` Eli Zaretskii
2023-02-17 12:42 ` Robert Pluim
2023-02-19 9:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a61c37zq.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=61553@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).