From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#61553: 29.0.60; Inconsistent use of dialog boxes by read-multiple-choice Date: Fri, 17 Feb 2023 11:24:09 +0100 Message-ID: <87a61c37zq.fsf@gmail.com> References: <87a61dfur1.fsf@gmail.com> <83edqp330z.fsf@gnu.org> <875yc1foej.fsf@gmail.com> <83a61d2wmp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34925"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Augusto Stoffel , 61553@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 17 11:25:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSxvT-0008sx-T9 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Feb 2023 11:25:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSxvM-0005pT-HR; Fri, 17 Feb 2023 05:25:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSxvL-0005p9-2p for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 05:25:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSxvK-0000lH-JJ for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 05:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSxvJ-0003k7-TE for bug-gnu-emacs@gnu.org; Fri, 17 Feb 2023 05:25:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Feb 2023 10:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61553 X-GNU-PR-Package: emacs Original-Received: via spool by 61553-submit@debbugs.gnu.org id=B61553.167662945914334 (code B ref 61553); Fri, 17 Feb 2023 10:25:01 +0000 Original-Received: (at 61553) by debbugs.gnu.org; 17 Feb 2023 10:24:19 +0000 Original-Received: from localhost ([127.0.0.1]:38547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSxud-0003j7-9H for submit@debbugs.gnu.org; Fri, 17 Feb 2023 05:24:19 -0500 Original-Received: from mail-wm1-f44.google.com ([209.85.128.44]:42506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSxub-0003is-HK for 61553@debbugs.gnu.org; Fri, 17 Feb 2023 05:24:17 -0500 Original-Received: by mail-wm1-f44.google.com with SMTP id ja15-20020a05600c556f00b003dc52fed235so485347wmb.1 for <61553@debbugs.gnu.org>; Fri, 17 Feb 2023 02:24:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=fzDfoTlxslssXsTw6zw1NtDq5GufntNPipQ2u6xttvw=; b=mfyjkId+0DS+M8RymRXTRw9BkEY308gOjxzDMmlRwTYjfBVQO6WXNgdqI399UJj+GH yYkqyFncpXFwWXgYHLYCf/lAJKzmDdrhzseMbcogxdA7mIcvaioNy07rEy5dnUEEntaJ yC6Yx1pWj/Wu5HBKLhotrWafNwhwNlyDHO+Myl08YKvVxJ7rowf2sCCddcj6ihH3jbCY TyUhCNnth501l0TgV+XYaHERMoRomGENCstngAoqjSzKwJT1SdQKQo2GGapKgBxWWo/W Gj8ZME9n/cFlEAF5B/+feZ82e8L9CsVchJXDt7F6Z2BCLHG84W8t6SKrjfZW5zP7EsvS IqmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fzDfoTlxslssXsTw6zw1NtDq5GufntNPipQ2u6xttvw=; b=XbDa3M48ceE8pQ7RbxrWyqz7dzaij6QWzfWWSHyfB+r4BNxZNRTawyy+T6lvWLFPtH /lJsER3fZnyPwG2CZLeUQVBwq++fEixmFg7rWiKIgAi4dlRj4fCME5z0bTpTSX4TpHmD EKiFKZ7c0rALmVyej3Mo0UQssMmBPLUiyLzibIRjh+zmgltokQREaGqSZB3ymlt+wFMk f2mwNwKxja2qnvwfbtiuf6JZzhIwol80KNTDuOpjZj2oQtGvITlnVaTwfQ9KolL8xjBz wthjhJv5wBxteqcOEdijMdsp+gc6h40tS5BzrRbtsf/tw+v1jMeLcm4TtkAxnhlAVXeX nafg== X-Gm-Message-State: AO0yUKUPMsZjQMY0ouTTQnfZaMTklvwIavxkLRSsnfZlpDlXm+3LVX3n 7+Mc2MvRID1VNpH8ssC3d+LFLI8nvbE= X-Google-Smtp-Source: AK7set9OVgseAt3d7QSBWIaEmSL5/cPefB52gqfOHjWHj6+aY9XA6fmMzT6NP1e6xfoJaPmlEHTYWQ== X-Received: by 2002:a05:600c:3095:b0:3dc:555c:dd30 with SMTP id g21-20020a05600c309500b003dc555cdd30mr6856524wmn.27.1676629451092; Fri, 17 Feb 2023 02:24:11 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id z23-20020a7bc7d7000000b003e2096da239sm5570665wmk.7.2023.02.17.02.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 02:24:10 -0800 (PST) In-Reply-To: <83a61d2wmp.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Feb 2023 22:17:18 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255871 Archived-At: >>>>> On Thu, 16 Feb 2023 22:17:18 +0200, Eli Zaretskii said: >> So instead of adding a special case for kill-buffer, I would rather >> modify the behavior of RMC to just ignore the long-form argument if >> (use-dialog-box-p) returns t. Apart from that, your patch seems fine. Eli> I disagree that rmc.el should make that decision. It isn't its call Eli> (pun intended). If we do this then we need to modify the docstring of `read-multiple-choice', which explicitly defines the current behaviour: When `use-dialog-box' is t (the default), and the command using this function was invoked via the mouse, this function pops up a GUI dialog to collect the user input, but only if Emacs is capable of using GUI dialogs. Otherwise, the function will always use text-mode dialogs. The return value is the matching entry from the CHOICES list. If LONG-FORM, do a `completing-read' over the NAME elements in CHOICES instead. Although perhaps we could clarify it: If LONG-FORM, always do a `completing-read' over the NAME elements in CHOICES instead, regardless of the value of `use-dialog-box'. Robert --