bug#41408: Add a project-compile command

bug#41408: Add a project-compile command

[Philip K.]

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]


Hi,

this patch adds a `compile' command for project.el. It's nothing fancy,
just sets the first directory of `project-roots' as `default-directory',
and then calls the regular compile.

The TODOs mention a `project-build' command, and from my interpretation,
this is a slimmed down version (hence the other name, but also because
it just called compile in a different environment).

-- 
	Philip K.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-project-compile-command.patch --]
[-- Type: text/x-diff, Size: 1213 bytes --]

From d4aa98e6b01e95f50dc9c6ec02792d4fce542b22 Mon Sep 17 00:00:00 2001
From: Philip K <philip@warpmail.net>
Date: Tue, 19 May 2020 19:30:14 +0200
Subject: [PATCH] Add project-compile command

---
 lisp/progmodes/project.el | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index 44259990bb..15b5899140 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -590,6 +590,18 @@ project-read-file-name-function
                  (function :tag "Custom function" nil))
   :version "27.1")
 
+;;;###autoload
+(defun project-compile ()
+  "Run `compile' in the project root."
+  (interactive)
+  (let* ((pr (project-current t))
+         (roots (project-roots pr))
+         ;; TODO: be more intelligent when choosing a directory. This
+         ;; currently isn't a priority, since no `project-roots'
+         ;; implementation returns more that one directory.
+         (default-directory (car roots)))
+    (call-interactively 'compile)))
+
 (defun project--read-file-cpd-relative (prompt
                                         all-files &optional predicate
                                         hist default)
-- 
2.20.1

bug#41408: Add a project-compile command

[Dmitry Gutov]

Hey Philip,

On 19.05.2020 21:24, Philip K. wrote:
> this patch adds a `compile' command for project.el. It's nothing fancy,
> just sets the first directory of `project-roots' as `default-directory',
> and then calls the regular compile.
> 
> The TODOs mention a `project-build' command, and from my interpretation,
> this is a slimmed down version (hence the other name, but also because
> it just called compile in a different environment).

Is this a command you'd be using yourself? If so, we'll add it happily.

I'm just asking because it's indeed bare-bones, and I basically never 
use 'M-x compile' directly.

bug#41408: Add a project-compile command

[Philip K.]

Dmitry Gutov <dgutov@yandex.ru> writes:

> Hey Philip,
>
> On 19.05.2020 21:24, Philip K. wrote:
>> this patch adds a `compile' command for project.el. It's nothing fancy,
>> just sets the first directory of `project-roots' as `default-directory',
>> and then calls the regular compile.
>> 
>> The TODOs mention a `project-build' command, and from my interpretation,
>> this is a slimmed down version (hence the other name, but also because
>> it just called compile in a different environment).
>
> Is this a command you'd be using yourself? If so, we'll add it happily.

I wrote it because I needed it, otherwise I wouldn't have suggested it,
hoping others to do. And I assume others do, since projectile has a
similar command (projectile-compile-project).

> I'm just asking because it's indeed bare-bones, and I basically never 
> use 'M-x compile' directly.

Hmm, I regularly use compile/recompile, but maybe that's my mistake. If
you don't mind me asking, how do you invoke compile or related
functions? If I'm doing it the "wrong way", maybe it might not be worth
applying this patch.

-- 
	Philip K.

bug#41408: Add a project-compile command

[Dmitry Gutov]

On 19.05.2020 23:07, Philip K. wrote:

>>> The TODOs mention a `project-build' command, and from my interpretation,
>>> this is a slimmed down version (hence the other name, but also because
>>> it just called compile in a different environment).

Regarding the "build" command, I had a bigger idea with a set of 
abstractions and per-project customizations. But so far nobody's needed 
that, it seems.

>> Is this a command you'd be using yourself? If so, we'll add it happily.
> 
> I wrote it because I needed it, otherwise I wouldn't have suggested it,
> hoping others to do.

That's what's important.

 > And I assume others do, since projectile has a
 > similar command (projectile-compile-project).

Projectile has a great many commands, we'll probably refrain from adding 
them all.

>> I'm just asking because it's indeed bare-bones, and I basically never
>> use 'M-x compile' directly.
> 
> Hmm, I regularly use compile/recompile, but maybe that's my mistake. If
> you don't mind me asking, how do you invoke compile or related
> functions?

Someone could give some pointers, but don't mind me: I usually work with 
Ruby, where the main "compilation" is running the tests. And we do that 
(to take advantage of compilation-mode) via a certain abstraction that 
builds up the list of arguments, and uses a mode derived from 
compilation-mode.

 > If I'm doing it the "wrong way", maybe it might not be worth
 > applying this patch.

If you find it helpful, then most likely there will be others that do. 
So please don't worry about that.

bug#41408: Add a project-compile command

[Kévin Le Gouguec]

philip@warpmail.net (Philip K.) writes:

> I wrote it because I needed it, otherwise I wouldn't have suggested it,
> hoping others to do. And I assume others do, since projectile has a
> similar command (projectile-compile-project).

FWIW I have written a similar function in my .emacs, which your command
would replace handily.  Thank you for suggesting this 👍

bug#41408: Add a project-compile command

[Dmitry Gutov]

On 19.05.2020 21:24, Philip K. wrote:
> this patch adds a `compile' command for project.el

I've applied the patch, but moved the new command to the end.

Thanks!