unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Kevin Liu <kevin@nivekuil.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 42653@debbugs.gnu.org
Subject: bug#42653: 28.0.50; scroll-margin is sometimes ignored with hl-line/display-line-numbers-mode
Date: Sun, 02 Aug 2020 13:24:34 -0700	[thread overview]
Message-ID: <878sewlrxt.fsf@nivekuil.com> (raw)
In-Reply-To: <83wo2hawq8.fsf@gnu.org>

Thanks!  This has honestly bugged me forever and will improve my Emacs
experience immeasurably.

> /* if EOB is visible, disable bottom margin */

This is a very interesting change that I didn't know I wanted, and I
really like it.  I see two issues right now:

1. If (hl-line-mode 1), then scrolling down as you reach EOB will
continue "collapsing" the margin, moving the cursor but not scrolling
beyond EOB, until it hits the actual EOB line.  At that point,
scroll-margin will again take effect and the screen will suddenly scroll
down by scroll-margin lines (7 in my case).  This seems like a bug,
off-by-one maybe?

2. The intended behavior of disabling the bottom margin as EOB
approaches seems to only apply when (hl-line-mode 1) or
(display-line-numbers-mode 1).  This means that enabling these modes
still affects scrolling behavior, which I think is fundamentally
unexpected.





  reply	other threads:[~2020-08-02 20:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-01 10:39 bug#42653: 28.0.50; scroll-margin is sometimes ignored with hl-line/display-line-numbers-mode Kevin Liu
2020-08-01 16:44 ` Eli Zaretskii
2020-08-01 17:32   ` Kevin Liu
2020-08-02 15:33     ` Eli Zaretskii
2020-08-02 20:24       ` Kevin Liu [this message]
2020-08-03  2:28         ` Eli Zaretskii
2020-08-03  3:18           ` Kevin Liu
2020-08-03 14:57             ` Eli Zaretskii
2020-09-10 21:18 ` bug#42653: Emacs now recentering very aggressively Dale Sedivec
2020-09-11 10:29   ` Lars Ingebrigtsen
2020-09-12  8:08   ` Eli Zaretskii
2022-02-09  9:49     ` bug#42653: 28.0.50; scroll-margin is sometimes ignored with hl-line/display-line-numbers-mode Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878sewlrxt.fsf@nivekuil.com \
    --to=kevin@nivekuil.com \
    --cc=42653@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).