From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Kevin Liu Newsgroups: gmane.emacs.bugs Subject: bug#42653: 28.0.50; scroll-margin is sometimes ignored with hl-line/display-line-numbers-mode Date: Sun, 02 Aug 2020 13:24:34 -0700 Message-ID: <878sewlrxt.fsf@nivekuil.com> References: <87r1sqtzsy.fsf@nivekuil.com> <83lfiyco47.fsf@gnu.org> <87o8nutgpu.fsf@nivekuil.com> <83wo2hawq8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21358"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.5.3; emacs 28.0.50 Cc: 42653@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 02 22:55:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k2L0j-0005Pt-GR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Aug 2020 22:55:13 +0200 Original-Received: from localhost ([::1]:34460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2L0i-0007qE-GH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Aug 2020 16:55:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2L0Z-0007pe-JO for bug-gnu-emacs@gnu.org; Sun, 02 Aug 2020 16:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60290) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k2L0Z-0003Wu-AO for bug-gnu-emacs@gnu.org; Sun, 02 Aug 2020 16:55:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k2L0Z-0003D4-9n for bug-gnu-emacs@gnu.org; Sun, 02 Aug 2020 16:55:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kevin Liu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Aug 2020 20:55:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42653 X-GNU-PR-Package: emacs Original-Received: via spool by 42653-submit@debbugs.gnu.org id=B42653.159640167512263 (code B ref 42653); Sun, 02 Aug 2020 20:55:03 +0000 Original-Received: (at 42653) by debbugs.gnu.org; 2 Aug 2020 20:54:35 +0000 Original-Received: from localhost ([127.0.0.1]:43596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2L05-0003Bg-MP for submit@debbugs.gnu.org; Sun, 02 Aug 2020 16:54:35 -0400 Original-Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2KXG-0002TN-Py for 42653@debbugs.gnu.org; Sun, 02 Aug 2020 16:24:48 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1596399878; cv=none; d=zohomail.com; s=zohoarc; b=iTzkJBAepFGrNpzHOlvp6hltkVPEC02cg3b29uyLiS3xCh1fAz4psoqcSPgohpU7FP6fCRciQm1mQBKUz8rc6alzUzZGASlkZszeF24NEAXcq5txD/4SsxglBlNIWFm01O6GOs5eHuVJtcEkYEiRoJyFdSV81JmefGcOnazn9xA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596399878; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=NdQzAafqIeBS4/Tsfdoqja/c8djvVbZymASgZc0ZTRo=; b=GFkxCWOAiqvNYDsbSZWVf3ADJSulje/YrLbUNib0x8eCmvHaauwh//4EvMDzTcW0zZoZ8YpTsQ2CH3lDCexsVUdLKhpEPHnjefm6mJx9LUWEqmx+QMX8E0tMLaahjlYZZt3oaGxTW5+NczrvBP8330XnPvn3vXJAOtTvVdJ6kjc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=nivekuil.com; spf=pass smtp.mailfrom=kevin@nivekuil.com; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1596399878; s=mail; d=nivekuil.com; i=kevin@nivekuil.com; h=References:From:To:Cc:Subject:Message-ID:In-reply-to:Date:MIME-Version:Content-Type; bh=NdQzAafqIeBS4/Tsfdoqja/c8djvVbZymASgZc0ZTRo=; b=lY9k96ULLMWtgEWMh/ytjuVP1UmTp4J8+d8Lq0zzwadU+CepRdNtDr8yWkgEvXk3 klzllxwTjLD1ZHspYGqKnCEAkXvfck8T3cvsIbiqbAWiXqLKw89cTf5XGP7KpRJT+Nw gTd1s517clkt0nbwCxqrJxFT9qxvBMq4VWsNp5k0= Original-Received: from machina (71.212.158.154 [71.212.158.154]) by mx.zohomail.com with SMTPS id 1596399875781245.43816353114005; Sun, 2 Aug 2020 13:24:35 -0700 (PDT) In-reply-to: <83wo2hawq8.fsf@gnu.org> X-ZohoMailClient: External X-Mailman-Approved-At: Sun, 02 Aug 2020 16:54:32 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183889 Archived-At: Thanks! This has honestly bugged me forever and will improve my Emacs experience immeasurably. > /* if EOB is visible, disable bottom margin */ This is a very interesting change that I didn't know I wanted, and I really like it. I see two issues right now: 1. If (hl-line-mode 1), then scrolling down as you reach EOB will continue "collapsing" the margin, moving the cursor but not scrolling beyond EOB, until it hits the actual EOB line. At that point, scroll-margin will again take effect and the screen will suddenly scroll down by scroll-margin lines (7 in my case). This seems like a bug, off-by-one maybe? 2. The intended behavior of disabling the bottom margin as EOB approaches seems to only apply when (hl-line-mode 1) or (display-line-numbers-mode 1). This means that enabling these modes still affects scrolling behavior, which I think is fundamentally unexpected.