From: Lars Ingebrigtsen <larsi@gnus.org>
To: Ruthra Kumar <ruthrab@gmail.com>
Cc: 43827@debbugs.gnu.org
Subject: bug#43827: #42223 patch
Date: Fri, 09 Oct 2020 06:19:42 +0200 [thread overview]
Message-ID: <878scg6nfl.fsf@gnus.org> (raw)
In-Reply-To: <CADnj5p=4=8KWMeFQQruRgupguFqKz7_sWqaXXxJrc5n813ozUg@mail.gmail.com> (Ruthra Kumar's message of "Thu, 8 Oct 2020 12:01:15 +0530")
Ruthra Kumar <ruthrab@gmail.com> writes:
> Fixed the bug. It's now able to list and extract files from archive.
Thanks; I was unable to try it because it seems like the patch was
mangled during transport again. Can you re-send it as an attachment?
> There is 1 edge case. If you press 'e' or 'RET' on a directory, the
> expected behaviour is the message 'Entry is not a regular member of
> archive'. Here, it tries to extract it as a file, cause
> 'archive-get-descr' fails to determine the type of the entry using
> 'mode' attribute. I face similar issues on RAR archive files as well.
>
> I suspect the 'mode' is not an exact integer representation of file
> permissions. Need more details on the 'mode' attribute of class
>
> Currently, the 'mode' value for squashfs is calculated from the file
> permissions outputted by 'unsquashfs -ll'.
> Ex: "-rwxrwxr-x" -> #o775
Right. That should be fixed, but if the same issue is present in .rar
files, too, then doing so before integrating probably isn't necessary.
> Yes, i'm willing to assign copyright to Free Software Foundation. Let
> me know the procedure.
Sent off-list.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-10-09 4:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 5:23 bug#43827: #42223 patch Ruthra Kumar
2020-10-07 3:53 ` Lars Ingebrigtsen
2020-10-08 6:31 ` Ruthra Kumar
2020-10-09 4:19 ` Lars Ingebrigtsen [this message]
2020-10-09 5:25 ` Ruthra Kumar
2020-10-10 20:03 ` bug#43827: #42223 squashfs patch Lars Ingebrigtsen
2020-10-23 6:09 ` Ruthra Kumar
2020-10-23 11:03 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878scg6nfl.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=43827@debbugs.gnu.org \
--cc=ruthrab@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).