From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43827: #42223 patch Date: Fri, 09 Oct 2020 06:19:42 +0200 Message-ID: <878scg6nfl.fsf@gnus.org> References: <87pn5u66al.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24895"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43827@debbugs.gnu.org To: Ruthra Kumar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 09 06:20:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQjtD-0006O9-4P for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Oct 2020 06:20:19 +0200 Original-Received: from localhost ([::1]:34206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQjtC-0001w7-2M for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Oct 2020 00:20:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQjsw-0001vz-72 for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2020 00:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50498) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQjsv-0004zu-TK for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2020 00:20:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kQjsv-0004uR-Q9 for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2020 00:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Oct 2020 04:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43827 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43827-submit@debbugs.gnu.org id=B43827.160221719518854 (code B ref 43827); Fri, 09 Oct 2020 04:20:01 +0000 Original-Received: (at 43827) by debbugs.gnu.org; 9 Oct 2020 04:19:55 +0000 Original-Received: from localhost ([127.0.0.1]:33811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQjsp-0004u2-4f for submit@debbugs.gnu.org; Fri, 09 Oct 2020 00:19:55 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:33774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQjsm-0004tm-3Q for 43827@debbugs.gnu.org; Fri, 09 Oct 2020 00:19:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ohTmjtjgGyawCORilTde+6g/gOmRz+nokrhra/Gzz0w=; b=t1/+9VbXuB5id16ThU9nHGs9nP 0y3J8X5ruF5eCx6eSUL5JGeIz8v8dD5j+PqLNKTual7OcE/Y1omRZ+lQC7AOyx46QFYLTRspd9mHT Ol4K1pUI8dwpn40NQ5z7JuBdvccljLaHXx5FFHEyqzVNau/FMBc5r9+yFm/elcv5cIJI=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQjsd-0007gU-M2; Fri, 09 Oct 2020 06:19:46 +0200 X-Now-Playing: M.I.A.'s _Galang_: "Galang" In-Reply-To: (Ruthra Kumar's message of "Thu, 8 Oct 2020 12:01:15 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190129 Archived-At: Ruthra Kumar writes: > Fixed the bug. It's now able to list and extract files from archive. Thanks; I was unable to try it because it seems like the patch was mangled during transport again. Can you re-send it as an attachment? > There is 1 edge case. If you press 'e' or 'RET' on a directory, the > expected behaviour is the message 'Entry is not a regular member of > archive'. Here, it tries to extract it as a file, cause > 'archive-get-descr' fails to determine the type of the entry using > 'mode' attribute. I face similar issues on RAR archive files as well. > > I suspect the 'mode' is not an exact integer representation of file > permissions. Need more details on the 'mode' attribute of class > > Currently, the 'mode' value for squashfs is calculated from the file > permissions outputted by 'unsquashfs -ll'. > Ex: "-rwxrwxr-x" -> #o775 Right. That should be fixed, but if the same issue is present in .rar files, too, then doing so before integrating probably isn't necessary. > Yes, i'm willing to assign copyright to Free Software Foundation. Let > me know the procedure. Sent off-list. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no