* bug#29833: icomplete re-build the completion table after each key press
@ 2017-12-24 8:58 Shuguang Sun
2017-12-25 14:40 ` Shuguang Sun
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Shuguang Sun @ 2017-12-24 8:58 UTC (permalink / raw)
To: 29833
[-- Attachment #1: Type: text/plain, Size: 1997 bytes --]
Hi,
The icomplete re-build the completion table
'completion-all-sorted-completions' after each key press. However, I think
it should keep the 'completion-all-sorted-completions' builded at beging
and re-use it afterwise.
At least in Windows, GNU Emacs 27.0.50 (build 1, x86_64-w64-mingw32) of
2017-12-09.
How to repeat it:
1: emacs -q
2: icomplete-mode (we can't find anything wired unless we call
dired-do-copy on a network-mapped remote file under a slow network)
3: modify function icomplete-exhibit to log as below:
insert '(print completion-all-sorted-completions)' between
'(save-excursion (goto-char (point-max))' and '(if (and (or
icomplete-show-matches-on-no-input', and C-M-x.
Then it will print 'nil' after each key press which means
'completion-all-sorted-completions' is empty.
4. modify function icomplete-completions to log as below:
insert '(print completion-all-sorted-completions)' at the begining of
the function body, prior to "(let* ((minibuffer-completion-table
candidates)'.
Then it will print 'nil' after each key press which means
'completion-all-sorted-completions' is empty.
Thereby, it has to call "(comps (completion-all-sorted-completions
(icomplete--field-beg) (icomplete--field-end)))' in function
icomplete-completions to re-build the completiong table after each key
press.
Thanks *Stefan Monnier *to point out it should be a bug in the help
maillist.
By the way, '(sequencep (icomplete--completion-table))' in function
icomplete-exhibit always returns 'nil', and the
icomplete-delay-completions-threshold actually has no effect.
(print (icomplete--completion-table)) just returns the table name (function
to generate the table), but not the content of the table.
By the way again, if call dired-do-copy or dired-do-rename,
icomplete-max-delay-chars counts the whole path of the file because, the
path has been put to the minibuffer automatically. This may not a bug,
however, I think it should be documented.
Best Regards,
Shuguang Sun
[-- Attachment #2: Type: text/html, Size: 2524 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#29833: icomplete re-build the completion table after each key press
2017-12-24 8:58 bug#29833: icomplete re-build the completion table after each key press Shuguang Sun
@ 2017-12-25 14:40 ` Shuguang Sun
2018-01-06 7:27 ` Shuguang Sun
2020-09-21 17:47 ` Stefan Monnier
2 siblings, 0 replies; 6+ messages in thread
From: Shuguang Sun @ 2017-12-25 14:40 UTC (permalink / raw)
To: shuguang, 29833
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
For reference: If icomplete-mode is on, it has the same issue with
counsel-find-file
(from swiper/counsel, https://github.com/abo-abo/
swiper/blob/master/counsel.el). After typeing each key, it will try to
re-build the file list. If turning icomplete-mode off, it will act as ido
and will not re-build the completion list.
Best Regards,
Shuguang
[-- Attachment #2: Type: text/html, Size: 799 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#29833: icomplete re-build the completion table after each key press
2017-12-24 8:58 bug#29833: icomplete re-build the completion table after each key press Shuguang Sun
2017-12-25 14:40 ` Shuguang Sun
@ 2018-01-06 7:27 ` Shuguang Sun
2020-09-21 14:27 ` Lars Ingebrigtsen
2020-09-21 17:47 ` Stefan Monnier
2 siblings, 1 reply; 6+ messages in thread
From: Shuguang Sun @ 2018-01-06 7:27 UTC (permalink / raw)
To: 29833
[-- Attachment #1.1: Type: text/plain, Size: 3747 bytes --]
Dear Emacs developers:
I tired to find out the issues and provide patches to minibuffer.el and
icomplete.el.
What is the issue?
1. The function completion--flush-all-sorted-completions defined in
minibuffer.el is always called without parameters which make it flush the
cached table every time.
2. The function completion--flush-all-sorted-completions is added to the
hook of after-change-functions, however, (jit-lock-after-change t) in the
hook will trigger flush every time
3. The local cached table completion-all-sorted-completions is not used
actually. The minibuffer-completion-table is called in a lot of function
which will rebuild the table instead of the chached table.
It has small impact on the performance of
1. operation in memory, e.g., describe-variable, describe-function
2. filename in local driver/PC
3. filename in tramp where it works on the ls output instead of trying to
re-do the ls command on the server
Those operations are fast and time for fuctions symbolp and functionp is
ignorable.
However, if it works under some slow instance, for example, a mapped driver
in Window with slow net work, the performance is bad as the completion
tries to list the directory in each call of completion--do-completion and
icomplete-completions, and some other completion functions.
The patches try to use the cached table
completion-all-sorted-completions-table as much as possible, and for
filename completion, it caches the list of files in the base directory
(file-name-directory).
https://github.com/ShuguangSun/emacsimprovement/tree/master/bug%2329833
On Sun, Dec 24, 2017 at 4:58 PM, Shuguang Sun <shuguang@gmail.com> wrote:
> Hi,
>
> The icomplete re-build the completion table 'completion-all-sorted-completions'
> after each key press. However, I think it should keep the
> 'completion-all-sorted-completions' builded at beging and re-use it
> afterwise.
>
> At least in Windows, GNU Emacs 27.0.50 (build 1, x86_64-w64-mingw32) of
> 2017-12-09.
>
> How to repeat it:
> 1: emacs -q
> 2: icomplete-mode (we can't find anything wired unless we call
> dired-do-copy on a network-mapped remote file under a slow network)
> 3: modify function icomplete-exhibit to log as below:
> insert '(print completion-all-sorted-completions)' between
> '(save-excursion (goto-char (point-max))' and '(if (and (or
> icomplete-show-matches-on-no-input', and C-M-x.
> Then it will print 'nil' after each key press which means
> 'completion-all-sorted-completions' is empty.
> 4. modify function icomplete-completions to log as below:
> insert '(print completion-all-sorted-completions)' at the begining of
> the function body, prior to "(let* ((minibuffer-completion-table
> candidates)'.
> Then it will print 'nil' after each key press which means
> 'completion-all-sorted-completions' is empty.
>
> Thereby, it has to call "(comps (completion-all-sorted-completions
> (icomplete--field-beg) (icomplete--field-end)))' in function
> icomplete-completions to re-build the completiong table after each key
> press.
>
> Thanks *Stefan Monnier *to point out it should be a bug in the help
> maillist.
>
> By the way, '(sequencep (icomplete--completion-table))' in function
> icomplete-exhibit always returns 'nil', and the icomplete-delay-completions-threshold
> actually has no effect.
> (print (icomplete--completion-table)) just returns the table name
> (function to generate the table), but not the content of the table.
>
> By the way again, if call dired-do-copy or dired-do-rename,
> icomplete-max-delay-chars counts the whole path of the file because, the
> path has been put to the minibuffer automatically. This may not a bug,
> however, I think it should be documented.
>
>
> Best Regards,
> Shuguang Sun
>
[-- Attachment #1.2: Type: text/html, Size: 4952 bytes --]
[-- Attachment #2: minibuffer.el.patch --]
[-- Type: application/octet-stream, Size: 17837 bytes --]
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index 4d14b2641f..a921dfdba4 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -1,6 +1,6 @@
;;; minibuffer.el --- Minibuffer completion functions -*- lexical-binding: t -*-
-;; Copyright (C) 2008-2018 Free Software Foundation, Inc.
+;; Copyright (C) 2008-2017 Free Software Foundation, Inc.
;; Author: Stefan Monnier <monnier@iro.umontreal.ca>
;; Package: emacs
@@ -977,6 +977,10 @@ completion--replace
(unless (zerop suffix-len)
(setq end (- end suffix-len))
(setq newtext (substring newtext 0 (- suffix-len))))
+ ;; After this amendment, the newtext has no directory
+ (if minibuffer-completing-file-name
+ (setq newtext (concat (file-name-directory (buffer-substring-no-properties beg end)) newtext))
+ )
(goto-char beg)
(let ((length (- end beg))) ;Read `end' before we insert the text.
(insert-and-inherit newtext)
@@ -999,7 +1003,11 @@ completion--cycle-threshold
(over (completion--category-override cat 'cycle)))
(if over (cdr over) completion-cycle-threshold)))
-(defvar-local completion-all-sorted-completions nil)
+;; If there is a proper completion-all-sorted-completions-table,
+;; fuction completion-all-sorted-completions needs not to be called
+(defvar-local completion-all-sorted-completions-table nil)
+;; The string to build completion-all-sorted-completions-table
+(defvar-local completion--all-sorted-completions-name nil)
(defvar-local completion--all-sorted-completions-location nil)
(defvar completion-cycling nil)
@@ -1030,15 +1038,18 @@ completion--do-completion
TRY-COMPLETION-FUNCTION is a function to use in place of `try-completion'.
EXPECT-EXACT, if non-nil, means that there is no need to tell the user
when the buffer's text is already an exact match."
- (let* ((string (buffer-substring beg end))
+ (let* ((string (if minibuffer-completing-file-name
+ (file-name-nondirectory (buffer-substring-no-properties beg end))
+ (buffer-substring-no-properties beg end)))
(md (completion--field-metadata beg))
- (comp (funcall (or try-completion-function
- 'completion-try-completion)
- string
- minibuffer-completion-table
- minibuffer-completion-predicate
- (- (point) beg)
- md)))
+ ;; completion-all-sorted-completions takes care about the predict
+ (comp (completion-try-completion
+ string
+ (completion-all-sorted-completions beg end)
+ nil
+ (length string)
+ md))
+ )
(cond
((null comp)
(minibuffer-hide-completions)
@@ -1080,8 +1091,13 @@ completion--do-completion
;; It did find a match. Do we match some possibility exactly now?
(let* ((exact (test-completion completion
- minibuffer-completion-table
- minibuffer-completion-predicate))
+ (if (consp completion-all-sorted-completions-table)
+ completion-all-sorted-completions-table
+ minibuffer-completion-table
+ )
+ (if (not (consp completion-all-sorted-completions-table))
+ minibuffer-completion-predicate)
+ ))
(threshold (completion--cycle-threshold md))
(comps
;; Check to see if we want to do cycling. We do it
@@ -1095,12 +1111,17 @@ completion--do-completion
(or (not completed)
(< (car (completion-boundaries
(substring completion 0 comp-pos)
- minibuffer-completion-table
- minibuffer-completion-predicate
+ (if (consp completion-all-sorted-completions-table)
+ completion-all-sorted-completions-table
+ minibuffer-completion-table
+ )
+ (if (not (consp completion-all-sorted-completions-table))
+ minibuffer-completion-predicate)
""))
comp-pos)))
- (completion-all-sorted-completions beg end))))
- (completion--flush-all-sorted-completions)
+ (completion-all-sorted-completions beg end))))
+ ;; it is not necessary to flush tables for each call
+ ;; (completion--flush-all-sorted-completions)
(cond
((and (consp (cdr comps)) ;; There's something to cycle.
(not (ignore-errors
@@ -1110,7 +1131,11 @@ completion--do-completion
;; Not more than completion-cycle-threshold remaining
;; completions: let's cycle.
(setq completed t exact t)
- (completion--cache-all-sorted-completions beg end comps)
+ ;; It is not necessary to flush tables for each call
+ ;; Would it be more efficient to replace the cached table
+ ;; with the new restricted one?
+ ;; For filename completion, it is based on base directory.
+ (completion-all-sorted-completions beg end)
(minibuffer-force-complete beg end))
(completed
;; We could also decide to refresh the completions,
@@ -1159,7 +1184,9 @@ completion--in-region-1
;; mark the completion buffer obsolete.
(setq this-command 'completion-at-point)
(unless (eq 'completion-at-point last-command)
- (completion--flush-all-sorted-completions)
+ ;; flush with no args will always flush the completion table
+ ;; not necessary to flush here
+ ;; (completion--flush-all-sorted-completions)
(setq minibuffer-scroll-window nil))
(cond
@@ -1177,7 +1204,7 @@ completion--in-region-1
(scroll-up)))
nil)))
;; If we're cycling, keep on cycling.
- ((and completion-cycling completion-all-sorted-completions)
+ ((and completion-cycling completion-all-sorted-completions-table)
(minibuffer-force-complete beg end)
t)
(t (pcase (completion--do-completion beg end)
@@ -1185,20 +1212,39 @@ completion--in-region-1
(_ t)))))
(defun completion--cache-all-sorted-completions (beg end comps)
- (add-hook 'after-change-functions
- 'completion--flush-all-sorted-completions nil t)
+ ;; The value of after-change-functions is (jit-lock-after-change t),
+ ;; it makes the flush called without parameters every time
+ ;; (add-hook 'after-change-functions
+ ;; 'completion--flush-all-sorted-completions nil t)
(setq completion--all-sorted-completions-location
(cons (copy-marker beg) (copy-marker end)))
- (setq completion-all-sorted-completions comps))
+ ;; The string to build the completion table
+ (setq completion--all-sorted-completions-name
+ (if minibuffer-completing-file-name
+ (file-name-directory (buffer-substring-no-properties beg end))
+ (buffer-substring-no-properties beg end)))
+ (setq completion-all-sorted-completions-table comps))
(defun completion--flush-all-sorted-completions (&optional start end _len)
(unless (and start end
- (or (> start (cdr completion--all-sorted-completions-location))
- (< end (car completion--all-sorted-completions-location))))
+ completion--all-sorted-completions-location
+ completion--all-sorted-completions-name
+ ;; not sure which is more efficient to compare location or the string
+ (not (or (> start (cdr completion--all-sorted-completions-location))
+ (< end (car completion--all-sorted-completions-location))))
+ (if minibuffer-completing-file-name
+ (let ((strc (compare-strings
+ completion--all-sorted-completions-name nil nil
+ (file-name-directory (buffer-substring-no-properties start end)) nil nil t)))
+ (eq t strc))
+ (eq 0 (string-match-p (regexp-quote completion--all-sorted-completions-name)
+ (buffer-substring-no-properties start end)))
+ ))
(remove-hook 'after-change-functions
'completion--flush-all-sorted-completions t)
(setq completion-cycling nil)
- (setq completion-all-sorted-completions nil)))
+ (setq completion--all-sorted-completions-name nil)
+ (setq completion-all-sorted-completions-table nil)))
(defun completion--metadata (string base md-at-point table pred)
;; Like completion-metadata, but for the specific case of getting the
@@ -1209,21 +1255,46 @@ completion--metadata
(completion-metadata (substring string 0 base) table pred))))
(defun completion-all-sorted-completions (&optional start end)
- (or completion-all-sorted-completions
+
+ ;; completion--flush-all-sorted-completions is always called without args...
+ ;; which means it will always flush the completion table
+ ;; therefore, need to take care about it out there
+ (unless (and start end
+ completion--all-sorted-completions-location
+ completion--all-sorted-completions-name
+ ;; not sure which is more sufficient, to compare location or string
+ (not (or (> start (cdr completion--all-sorted-completions-location))
+ (< end (car completion--all-sorted-completions-location))))
+ (if minibuffer-completing-file-name
+ (let ((strc (compare-strings
+ completion--all-sorted-completions-name nil nil
+ (file-name-directory (buffer-substring-no-properties start end)) nil nil t)))
+ (eq t strc))
+ (eq 0 (string-match-p (regexp-quote completion--all-sorted-completions-name)
+ (buffer-substring-no-properties start end)))
+ ))
+ (completion--flush-all-sorted-completions)
+ )
+
+ (or completion-all-sorted-completions-table
(let* ((start (or start (minibuffer-prompt-end)))
(end (or end (point-max)))
- (string (buffer-substring start end))
+ (string (if minibuffer-completing-file-name
+ ;; It builds the completion list on the directory, instead the substring
+ ;; not sure which one is more effecient
+ (file-name-directory (buffer-substring-no-properties start end))
+ (buffer-substring-no-properties start end)))
(md (completion--field-metadata start))
(all (completion-all-completions
string
minibuffer-completion-table
minibuffer-completion-predicate
- (- (point) start)
+ (length string)
md))
(last (last all))
(base-size (or (cdr last) 0))
- (all-md (completion--metadata (buffer-substring-no-properties
- start (point))
+ ;; predict and metatdata works here
+ (all-md (completion--metadata string
base-size md
minibuffer-completion-table
minibuffer-completion-predicate))
@@ -1252,6 +1323,42 @@ completion-all-sorted-completions
(completion--cache-all-sorted-completions
start end (nconc all base-size))))))
+;; This one acceptable cached table.
+;; It could be made into function completion-all-sorted-completions
+(defun completion--all-sorted-completions (start name table)
+
+ (let* ((md (completion--field-metadata start))
+ (all (completion-all-completions
+ name table nil (length name) md))
+ (last (last all))
+ (base-size (or (cdr last) 0))
+ (all-md (completion--metadata name
+ base-size md
+ table
+ nil))
+ (sort-fun (completion-metadata-get all-md 'cycle-sort-function)))
+
+ (when last
+ (setcdr last nil)
+
+ ;; Delete duplicates: do it after setting last's cdr to nil (so
+ ;; it's a proper list), and be careful to reset `last' since it
+ ;; may be a different cons-cell.
+ (setq all (delete-dups all))
+ (setq last (last all))
+
+ (setq all (if sort-fun (funcall sort-fun all)
+ ;; Prefer shorter completions, by default.
+ (sort all (lambda (c1 c2) (< (length c1) (length c2))))))
+ ;; Prefer recently used completions.
+ (when (minibufferp)
+ (let ((hist (symbol-value minibuffer-history-variable)))
+ (setq all (sort all (lambda (c1 c2)
+ (> (length (member c1 hist))
+ (length (member c2 hist))))))))
+ )))
+
+
(defun minibuffer-force-complete-and-exit ()
"Complete the minibuffer with first of the matches and exit."
(interactive)
@@ -1293,7 +1400,7 @@ minibuffer-force-complete
(setq this-command 'completion-at-point) ;For completion-in-region.
;; If completing file names, (car all) may be a directory, so we'd now
;; have a new set of possible completions and might want to reset
- ;; completion-all-sorted-completions to nil, but we prefer not to,
+ ;; completion-all-sorted-completions-table to nil, but we prefer not to,
;; so that repeated calls minibuffer-force-complete still cycle
;; through the previous possible completions.
(let ((last (last all)))
@@ -1787,13 +1894,23 @@ minibuffer-completion-help
(message "Making completion list...")
(let* ((start (or start (minibuffer-prompt-end)))
(end (or end (point-max)))
+ ;; Does it need to keep the text properties?
(string (buffer-substring start end))
+ (string (if minibuffer-completing-file-name
+ (file-name-nondirectory (buffer-substring-no-properties start end))
+ (buffer-substring-no-properties start end)))
(md (completion--field-metadata start))
(completions (completion-all-completions
string
- minibuffer-completion-table
- minibuffer-completion-predicate
- (- (point) start)
+ ;; If there is cached table, using the table
+ (if (consp completion-all-sorted-completions-table)
+ completion-all-sorted-completions-table
+ minibuffer-completion-table
+ )
+ (if (consp completion-all-sorted-completions-table)
+ nil
+ minibuffer-completion-predicate)
+ (length string)
md)))
(message nil)
(if (or (null completions)
@@ -1810,11 +1927,19 @@ minibuffer-completion-help
(let* ((last (last completions))
(base-size (or (cdr last) 0))
(prefix (unless (zerop base-size) (substring string 0 base-size)))
- (all-md (completion--metadata (buffer-substring-no-properties
- start (point))
+ (string2 (if minibuffer-completing-file-name
+ (file-name-nondirectory (buffer-substring-no-properties start (point)))
+ (buffer-substring-no-properties start (point))))
+ (all-md (completion--metadata string2
base-size md
- minibuffer-completion-table
- minibuffer-completion-predicate))
+ (if (consp completion-all-sorted-completions-table)
+ completion-all-sorted-completions-table
+ minibuffer-completion-table
+ )
+ (if (consp completion-all-sorted-completions-table)
+ nil
+ minibuffer-completion-predicate)
+ ))
(afun (or (completion-metadata-get all-md 'annotation-function)
(plist-get completion-extra-properties
:annotation-function)
[-- Attachment #3: icomplete.el.patch --]
[-- Type: application/octet-stream, Size: 1081 bytes --]
diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index b37db8869b..3f9b48b3c3 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -1,6 +1,6 @@
;;; icomplete.el --- minibuffer completion incremental feedback
-;; Copyright (C) 1992-1994, 1997, 1999, 2001-2018 Free Software
+;; Copyright (C) 1992-1994, 1997, 1999, 2001-2017 Free Software
;; Foundation, Inc.
;; Author: Ken Manheimer <klm@i.am>
@@ -387,7 +387,11 @@ icomplete-completions
(if last (setcdr last nil))
(when (and minibuffer-completing-file-name
icomplete-with-completion-tables)
- (setq comps (completion-pcm--filename-try-filter comps)))
+ (setq comps (completion-pcm--filename-try-filter comps))
+ ;; no directory
+ (setq name (file-name-nondirectory name)))
+ ;; get all completions in cached table
+ (setq comps (completion--all-sorted-completions (icomplete--field-beg) name comps))
(let* ((most-try
(if (and base-size (> base-size 0))
(completion-try-completion
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#29833: icomplete re-build the completion table after each key press
2018-01-06 7:27 ` Shuguang Sun
@ 2020-09-21 14:27 ` Lars Ingebrigtsen
0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2020-09-21 14:27 UTC (permalink / raw)
To: Shuguang Sun; +Cc: 29833, Stefan Monnier
Shuguang Sun <shuguang@gmail.com> writes:
> I tired to find out the issues and provide patches to minibuffer.el and icomplete.el.
>
> What is the issue?
> 1. The function completion--flush-all-sorted-completions defined in minibuffer.el is
> always called without parameters which make it flush the cached table every
> time.
> 2. The function completion--flush-all-sorted-completions is added to the hook of
> after-change-functions, however, (jit-lock-after-change t) in the hook will trigger
> flush every time
> 3. The local cached table completion-all-sorted-completions is not used actually.
> The minibuffer-completion-table is called in a lot of function which will rebuild the
> table instead of the chached table.
[...]
> The patches try to use the cached table completion-all-sorted-completions-table as
> much as possible, and for filename completion, it caches the list of files in the base
> directory (file-name-directory).
This patch unfortunately got no response when it was posted two years
ago, and it no longer applies cleanly to Emacs 28.
I'm not very familiar with the completion functions, but I think your
changes make conceptual sense, at least. Perhaps Stefan can provide
some feedback here?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#29833: icomplete re-build the completion table after each key press
2017-12-24 8:58 bug#29833: icomplete re-build the completion table after each key press Shuguang Sun
2017-12-25 14:40 ` Shuguang Sun
2018-01-06 7:27 ` Shuguang Sun
@ 2020-09-21 17:47 ` Stefan Monnier
2021-07-23 12:51 ` Lars Ingebrigtsen
2 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2020-09-21 17:47 UTC (permalink / raw)
To: Shuguang Sun; +Cc: 29833
> The icomplete re-build the completion table
> 'completion-all-sorted-completions' after each key press.
This is considered normal.
The reason is that icomplete can't know in general how to take the
list of matching completions for "foob" or for "fo" (or for any other
string for that matter) and compute the corresponding list of
matching completions.
This is because it depends on lots of details. E.g. when completing
files when going from "foo" to "foo/" the list of completions is
completely changed. In other cases, "foo" matches something using
a particular completion-style but "foob" doesn't, so a different
completion-style will be used, ...
It is true that in many case the completions of "foob" are a subset of
the completions of "foo", so we could recompute them faster but
icomplete is not being told under which conditions this is true and it's
not being told *how* it could be recomputed (e.g. by looking for
candidates matching "foob" or by looking for candidates matching
"f.*o.*o.*b", ...).
So in order to be able to avoid recomputing the candidates "from
scratch", we'd need the rest of the completion code to give us more
info, but there is no such infrastructure.
What the current completion system expects instead is that if the time
needed to recompute the candidates can be large, the *completion table*
should use a cache.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#29833: icomplete re-build the completion table after each key press
2020-09-21 17:47 ` Stefan Monnier
@ 2021-07-23 12:51 ` Lars Ingebrigtsen
0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-07-23 12:51 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 29833, Shuguang Sun
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> So in order to be able to avoid recomputing the candidates "from
> scratch", we'd need the rest of the completion code to give us more
> info, but there is no such infrastructure.
>
> What the current completion system expects instead is that if the time
> needed to recompute the candidates can be large, the *completion table*
> should use a cache.
The completion code has gotten a lot of work lately, but I guess the
conclusion here is that there's nothing specific to do in this bug
report, so I'm closing it.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-23 12:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-24 8:58 bug#29833: icomplete re-build the completion table after each key press Shuguang Sun
2017-12-25 14:40 ` Shuguang Sun
2018-01-06 7:27 ` Shuguang Sun
2020-09-21 14:27 ` Lars Ingebrigtsen
2020-09-21 17:47 ` Stefan Monnier
2021-07-23 12:51 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).