* bug#55275: 29.0.50; Gnus' nnvirtual-retrieve-headers shouldn't force usage of the cache
@ 2022-05-05 15:28 Eric Abrahamsen
2022-05-06 12:17 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Eric Abrahamsen @ 2022-05-05 15:28 UTC (permalink / raw)
To: 55275
In ./lisp/gnus/nnvirtual.el, the `nnvirtual-retrieve-headers' deffoo
let-binds `gnus-use-cache' to t when it uses `gnus-retrieve-headers' on
its various constituent groups. For users not using the cache, this
will result in an error.
I can put an additional check in gnus-cache.el when we call
`gnus-cache-retrieve-headers', but it would be nice to know why this
necessary in the first place. The code comment on
`nnvirtual-retrieve-headers' says:
;; FIX FIX FIX we want to check the cache!
;; This is probably evil if people have set
;; gnus-use-cache to nil themselves, but I
;; have no way of finding the true value of it.
All the above is true, except I don't understand why we want to check
the cache. This code is ancient and I'm only medium-hopeful Lars
remembers the reasoning here, but on the face of it I don't know why we
need to force a check of the cache. It seems like we could simply remove
that, and the cache will still be checked iff the user has set
`gnus-use-cache' to t.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#55275: 29.0.50; Gnus' nnvirtual-retrieve-headers shouldn't force usage of the cache
2022-05-05 15:28 bug#55275: 29.0.50; Gnus' nnvirtual-retrieve-headers shouldn't force usage of the cache Eric Abrahamsen
@ 2022-05-06 12:17 ` Lars Ingebrigtsen
2022-05-06 17:17 ` Eric Abrahamsen
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2022-05-06 12:17 UTC (permalink / raw)
To: Eric Abrahamsen; +Cc: 55275
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> All the above is true, except I don't understand why we want to check
> the cache. This code is ancient and I'm only medium-hopeful Lars
> remembers the reasoning here, but on the face of it I don't know why we
> need to force a check of the cache. It seems like we could simply remove
> that, and the cache will still be checked iff the user has set
> `gnus-use-cache' to t.
I have no recollection of that code. :-/
But, yes, I think removing that binding would be the right thing to do.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#55275: 29.0.50; Gnus' nnvirtual-retrieve-headers shouldn't force usage of the cache
2022-05-06 12:17 ` Lars Ingebrigtsen
@ 2022-05-06 17:17 ` Eric Abrahamsen
0 siblings, 0 replies; 3+ messages in thread
From: Eric Abrahamsen @ 2022-05-06 17:17 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 55275-done
On 05/06/22 14:17 PM, Lars Ingebrigtsen wrote:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> All the above is true, except I don't understand why we want to check
>> the cache. This code is ancient and I'm only medium-hopeful Lars
>> remembers the reasoning here, but on the face of it I don't know why we
>> need to force a check of the cache. It seems like we could simply remove
>> that, and the cache will still be checked iff the user has set
>> `gnus-use-cache' to t.
>
> I have no recollection of that code. :-/
It was a while ago :)
> But, yes, I think removing that binding would be the right thing to do.
Done.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-06 17:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-05 15:28 bug#55275: 29.0.50; Gnus' nnvirtual-retrieve-headers shouldn't force usage of the cache Eric Abrahamsen
2022-05-06 12:17 ` Lars Ingebrigtsen
2022-05-06 17:17 ` Eric Abrahamsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).