bug#37019: 27.0.50; "C-x v =' and 'diff-font-lock-prettify' when there's no left fringe

bug#37019: 27.0.50; "C-x v =' and 'diff-font-lock-prettify' when there's no left fringe

[Eli Zaretskii]

To reproduce:

  emacs -Q
  [visit some versioned file under Git control]
  M-x set-variable RET diff-font-lock-prettify RET t RET
  M-x fringe-mode RET right-only RET
  C-u C-x v = SOME-REVISION RET RET

The last command reports changes of the file since SOME-REVISION.  But
because the left fringe is unavailable, there's no insert/delete
indicators at all, not even the original ones displayed when
diff-font-lock-prettify is nil.

I think in this case we should keep the original indicators.

In GNU Emacs 27.0.50 (build 1283, i686-pc-mingw32)
 of 2019-08-13 built on HOME-C4E4A596F7
Repository revision: c90975f92fd71be7282293e0ed1098c0fa5d62a0
Repository branch: master
Windowing system distributor 'Microsoft Corp.', version 5.1.2600
System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600)

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure -C --prefix=/d/usr --with-wide-int --with-modules
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3''

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY W32NOTIFY ACL GNUTLS LIBXML2
HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS JSON PDUMPER LCMS2 GMP

Important settings:
  value of $LANG: ENU
  locale-coding-system: cp1255

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads w32notify w32 lcms2 multi-tty make-network-process
emacs)

Memory information:
((conses 16 50468 9853)
 (symbols 48 7137 1)
 (strings 16 18710 2458)
 (string-bytes 1 526563)
 (vectors 16 9759)
 (vector-slots 8 127151 9604)
 (floats 8 19 113)
 (intervals 40 258 92)
 (buffers 880 11))

bug#37019: 27.0.50; "C-x v =' and 'diff-font-lock-prettify' when there's no left fringe

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> To reproduce:
>
>   emacs -Q
>   [visit some versioned file under Git control]
>   M-x set-variable RET diff-font-lock-prettify RET t RET
>   M-x fringe-mode RET right-only RET
>   C-u C-x v = SOME-REVISION RET RET
>
> The last command reports changes of the file since SOME-REVISION.  But
> because the left fringe is unavailable, there's no insert/delete
> indicators at all, not even the original ones displayed when
> diff-font-lock-prettify is nil.
>
> I think in this case we should keep the original indicators.

Yup.  I've now fixed this in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no