unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: 58515@debbugs.gnu.org
Subject: bug#58515: 29.0.50; [PATCH] Fix menu bar height
Date: Sat, 15 Oct 2022 09:37:28 +0800	[thread overview]
Message-ID: <878rlhsw87.fsf@yahoo.com> (raw)
In-Reply-To: <87tu46v543.fsf@elite.giraud> (Manuel Giraud's message of "Fri, 14 Oct 2022 16:42:36 +0200")

Manuel Giraud <manuel@ledu-giraud.fr> writes:

> Hi,
>
> This patch tries to fix height calculation for menu bar in X when not
> using a toolkit.  It is taking into account the fact that the menu bar
> face could be boxed.
>
> There are others issues left (i.e. not handled by this patch):
>
>       - a customization of the menu face does not trigger a redisplay,
>         so one has to deactivate/re-activate the menu bar in order to
>         update (I don't know how this is done for other faces)
>         
>       - with a boxed menu bar face, the box is not displayed correctly
>         on the right side of the bar

Thanks.  I think the latter two should be fixed first before installing
this; also, menu bar height computation is rather tricky in its
interaction with various window managers, so I'd wait until after the
Emacs 29 branch is cut.

Also, please move the changes to xterm.c to xfns.c.





  reply	other threads:[~2022-10-15  1:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14 14:42 bug#58515: 29.0.50; [PATCH] Fix menu bar height Manuel Giraud
2022-10-15  1:37 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-10-15  8:28   ` Manuel Giraud
2022-10-15  8:29     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rlhsw87.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=58515@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).