From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#58515: 29.0.50; [PATCH] Fix menu bar height Date: Sat, 15 Oct 2022 09:37:28 +0800 Message-ID: <878rlhsw87.fsf@yahoo.com> References: <87tu46v543.fsf@elite.giraud> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13640"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58515@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 15 03:38:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojW85-0003K2-Kh for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Oct 2022 03:38:21 +0200 Original-Received: from localhost ([::1]:44112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojW84-0001oX-At for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Oct 2022 21:38:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojW7m-0001oI-FX for bug-gnu-emacs@gnu.org; Fri, 14 Oct 2022 21:38:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39957) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojW7m-0005oY-7D for bug-gnu-emacs@gnu.org; Fri, 14 Oct 2022 21:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ojW7l-0000pe-Nd for bug-gnu-emacs@gnu.org; Fri, 14 Oct 2022 21:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Oct 2022 01:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58515 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58515-submit@debbugs.gnu.org id=B58515.16657978653176 (code B ref 58515); Sat, 15 Oct 2022 01:38:01 +0000 Original-Received: (at 58515) by debbugs.gnu.org; 15 Oct 2022 01:37:45 +0000 Original-Received: from localhost ([127.0.0.1]:39035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojW7U-0000p8-IN for submit@debbugs.gnu.org; Fri, 14 Oct 2022 21:37:44 -0400 Original-Received: from sonic315-21.consmr.mail.ne1.yahoo.com ([66.163.190.147]:38176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojW7S-0000oq-66 for 58515@debbugs.gnu.org; Fri, 14 Oct 2022 21:37:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1665797855; bh=ZeARWid8npKDXvzmMaLOCbAFNmXiznsjSBg8o1Rk18k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=rWXEJAxu/NoviJ+F7C/iw/sKpsD7dNOg9NKg3yZdaNGDHwbTdAKCKL61JPOoD4d0DQVh2XzGHfbZsDsrcXa9tzh8E2+PnU5VsVby559iXG77MPQWklQ4EnMKUyi43GVA4CRPsrMEa/N61RkwbSKNBBV682SPjKfRYM8V7lVGyggFiLzKHbIrvhsxGK70lINdoUXNKs/fl3Oiv2082fOy5FtqnphhjMRI6MyS4hruKuHHgWQYCC5IN+4Bg+nrn5G7jaq5rINflRJK3hmqE+jw1gMLHbXqhyTHYoMsKm5wp5v3tJ3omcxWZQK5p12M6bnX5FClJPjls/VnGt5yIRHNmA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1665797855; bh=S7l7duNlmzinu4r4YiZu0YSpON7KtSHxAXPEKE+dFMF=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ofRAGWwemgn1ZElQ3iMNrDQj7SrBh7WcQCFlMcmBLuBzBj9keShchw0wSXTBYAgNG8iDoVIjB2+rqHegfdNf5S6QcJHFM00zDPf/9q3B6wVsYCOTkGHAFtikZwuYMoGtM1/Sr74Fx1havAOYE2FzyidoXAnK54pTtLHgf5sQFLtSUsb/+Wsnp18P7jyYoEAzT36C+k09URijs/+ZUUR5gedI86PR58UIMOTWnkoVUp7PJMPbalBGogJdGgsUAVANNMerR4tswOD/oAut3/87Te7VhujFQ65qIvOoE7yE0L8w7qenWzXw+lhWhCYzaYXfxL1APb24v5Hc8iZy7Pvihw== X-YMail-OSG: Q6HjIlUVM1lim_wtHTL6FHzVkvDnuj5W50tyxFLo.Wj.pHzNK97UH1h8x9I.YxQ g3txK6qSaEtjW7P_FxvNaQEKPM3j8B_7CiYVGaNfxUr15U1oK98u.kEvYd_cg86UGXvKvkyzk6zj gk98ZPTzmr8yUj4qLQ6tBNqVFmht0WC_OBZrJPiWHsPdyrXqt.qOoSIOWDYNXOAoRzBRry_gVlWz WA5vHAVvW014sRxzSD.jQ1FPxVz73ELyY4gsumt7hgM6B0fx0MhSu3XI0rqA5Mmm92edqOpmFGwy t6ognzjMr4SwBLKN7ndskVPbdQW_mW4qB0dGMCbGgRCkhol0nOmc_g7AcKFukNYtBJ5auqw7ZHQ. L_q_tzaqX2cJo.Q0ajVQVM3vPipIw7fNtbPw8LGDgiZS4gcXgGCXpqyIJ2jlDCBnVNIszVWfJL7P 99fGucr9uf5JX0xsuKoXi3O8Uir8DrbZlpWQ7OV1fHavSU1w0eA22wKhchpBtl1qrI4RW3OUMMMm YMPXVwcUWLw4_MWEC802RascsGf8jxjv_otEYTlx15zNZtij26ruqvZIBRsTIKgejFEWNNzcFyNt BkRJzrbm5BtZKQAZOGtfBc9KJ5gLrGgpAfVT5UXIKoLJVQC8hbp1f6Gz7K10Ls0BkYfA38IoIM6X PPuCaBGdpLnyQShiia1NBrv.EcWbsNMKArKcZ0vuKIWUQySyDQxf88uQfs7bk6jNaEaop7N0LP2m R43M3_VgwPprsL2n6UNRi8q.R77IAH3R8Z9KrfgSr7YEwIuZ6.bhTASTKM2WIol.n177jkDxELVr aduI6nt3O4CkpkrYyF721GcbDXoGj5fCLub5flXpy9 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.ne1.yahoo.com with HTTP; Sat, 15 Oct 2022 01:37:35 +0000 Original-Received: by hermes--production-sg3-785466d859-nkfcl (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 8253a8cde5afe32906da880aaecce6ef; Sat, 15 Oct 2022 01:37:32 +0000 (UTC) In-Reply-To: <87tu46v543.fsf@elite.giraud> (Manuel Giraud's message of "Fri, 14 Oct 2022 16:42:36 +0200") X-Mailer: WebService/1.1.20740 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245496 Archived-At: Manuel Giraud writes: > Hi, > > This patch tries to fix height calculation for menu bar in X when not > using a toolkit. It is taking into account the fact that the menu bar > face could be boxed. > > There are others issues left (i.e. not handled by this patch): > > - a customization of the menu face does not trigger a redisplay, > so one has to deactivate/re-activate the menu bar in order to > update (I don't know how this is done for other faces) > > - with a boxed menu bar face, the box is not displayed correctly > on the right side of the bar Thanks. I think the latter two should be fixed first before installing this; also, menu bar height computation is rather tricky in its interaction with various window managers, so I'd wait until after the Emacs 29 branch is cut. Also, please move the changes to xterm.c to xfns.c.