bug#403: 23.0.60; two bugs with internal-border-width

bug#403: 23.0.60; two bugs with internal-border-width

[Tom Tromey]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:


Evalling this form yields 0:

(let ((f (make-frame '((internal-border-width . 20)))))
  (prog1
      (frame-parameter f 'internal-border-width)
    (delete-frame f)))

... I expected it to yield 20.

Also, once a frame is displayed, if I modify internal-border-width
(changing it from 0 to 20, say), it can leave some garbage on the
screen, where the new border should be.  recenter fixes this.


If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/home/tromey/Emacs/install/share/emacs/23.0.60/etc/DEBUG for instructions.


In GNU Emacs 23.0.60.1 (i686-pc-linux-gnu, GTK+ Version 2.12.10)
 of 2008-06-12 on mopsy
Windowing system distributor `The X.Org Foundation', version 11.0.10499901
configured using `configure  '--prefix=/home/tromey/Emacs/install' '--enable-languages=c++,java' '--enable-threads=posix' '--enable-checking=yes' '--enable-java-awt=gtk' '--disable-static''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.utf8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  eldoc-mode: t
  erc-services-mode: t
  erc-networks-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
n n n n n q C-a M-v M-v M-v C-v C-v M-> M-< M-> M-v 
M-v M-v M-v <f12> n n n n n n n n n n n n n n n n n 
p p p p p p p p p p p p p p p p p p n n n n n n n n 
n n n n n n n n n p p p p p p n n q <S-up> <S-up> <S-up> 
<S-up> <S-up> <S-up> <S-up> <S-up> <S-up> <f12> n n 
n n q C-x b e p <tab> C-g C-g C-x C-f <M-backspace> 
E m <tab> E m <tab> e p r <tab> <return> C-x 4 f C-g 
C-x 4 b * s r <tab> <backspace> c r <tab> <return> 
C-x o C-v C-x o C-x o C-v C-l C-v C-s m a k e - C-l 
C-x o ( l e t SPC ( ( f SPC ( m a k e - f r a m e SPC 
' ( ( i n t e r n M-/ SPC . SPC 2 0 ) ) ) ) ) ) <backspace> 
<return> ( f r a m e - p a r ESC TAB M-x f l y s p 
<tab> m o <tab> <return> ESC TAB SPC f SPC ' i n M-/ 
) ) C-j <switch-frame> C-z 0 C-p C-p C-e <backspace> 
<return> ( d e s t r ESC TAB o y <M-backspace> d e 
l e ESC TAB - f r ESC TAB SPC f ) ) C-j C-u C-p C-n 
<tab> M-o ( p r o g 1 SPC <backspace> C-n TAB C-n TAB 
C-e <backspace> ) ) C-j M-x r e p o r t - e m <tab> 
<return>

Recent messages:
call-interactively: Beginning of buffer [2 times]
Mark set
Quit [2 times]
Loading vc-cvs...done
Quit
Mark saved where search started
Scanning for dabbrevs...100%
Expansion found in 'epresent.el'
Flyspell mode disabled
Making completion list...done

bug#403: 23.0.60; two bugs with internal-border-width

[Stefan Monnier]

> Evalling this form yields 0:

> (let ((f (make-frame '((internal-border-width . 20)))))
>   (prog1
>       (frame-parameter f 'internal-border-width)
>     (delete-frame f)))

> ... I expected it to yield 20.

Apparently it's because of

  /* GTK does not set any border, and they look bad with GTK.  */
  f->border_width = 0;
  f->internal_border_width = 0;

in gtkutil.c:xg_create_frame_widgets.  I think I've fixed it now.

> Also, once a frame is displayed, if I modify internal-border-width
> (changing it from 0 to 20, say), it can leave some garbage on the
> screen, where the new border should be.  recenter fixes this.

Sorry, I don't know how to even begin debugging this.


        Stefan

bug#403: 23.0.60; two bugs with internal-border-width

[Tom Tromey]

>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:

[...]
Stefan> in gtkutil.c:xg_create_frame_widgets.  I think I've fixed it now.

Thanks, this worked for me.

>> Also, once a frame is displayed, if I modify internal-border-width
>> (changing it from 0 to 20, say), it can leave some garbage on the
>> screen, where the new border should be.  recenter fixes this.

Stefan> Sorry, I don't know how to even begin debugging this.

I can try to provide more details if you think that would be useful;
maybe a form to eval to see the problem.

Tom

bug#403: 23.0.60; two bugs with internal-border-width

[Stefan Monnier]

Stefan> Sorry, I don't know how to even begin debugging this.
> I can try to provide more details if you think that would be useful;
> maybe a form to eval to see the problem.

No, that's OK, I can reproduce the problem just fine, I just don't know
anything about the code.


        Stefan

bug#403: 23.0.60; two bugs with internal-border-width

[Chong Yidong]

> Evalling this form yields 0:
>
> (let ((f (make-frame '((internal-border-width . 20)))))
>   (prog1
>       (frame-parameter f 'internal-border-width)
>     (delete-frame f)))
>
> ... I expected it to yield 20.
>
> Also, once a frame is displayed, if I modify internal-border-width
> (changing it from 0 to 20, say), it can leave some garbage on the
> screen, where the new border should be.  recenter fixes this.

This seems to have been fixed in the meantime.  At least, it DTRT on my
machine (x86_64-unknown-linux-gnu, GTK+ Version 2.12.9).  Do you still
see this problem?

bug#403: 23.0.60; two bugs with internal-border-width

[Lars Magne Ingebrigtsen]

Chong Yidong <cyd@stupidchicken.com> writes:

> This seems to have been fixed in the meantime.  At least, it DTRT on my
> machine (x86_64-unknown-linux-gnu, GTK+ Version 2.12.9).  Do you still
> see this problem?

More information was requested three years ago, so I'm closing this
bug.  If this is still a problem, please reopen the report.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/