bug#4052: Emacs hangs with C-u C-u lrgep

bug#4052: Emacs hangs with C-u C-u lrgep

[Juri Linkov]

Emacs hangs and every keystroke beeps with error messages like

  cd: Wrong type argument: stringp, nil
  file-remote-p: Wrong type argument: stringp, nil

because `C-u C-u M-x lrgep M-p RET' sets `default-directory' to nil.

I believe this is the correct fix:

Index: lisp/progmodes/grep.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/grep.el,v
retrieving revision 1.102
diff -u -r1.102 grep.el
--- lisp/progmodes/grep.el	8 Jul 2009 14:24:00 -0000	1.102
+++ lisp/progmodes/grep.el	5 Aug 2009 22:17:36 -0000
@@ -827,7 +827,7 @@
 					  command nil nil 'grep-history))
 	    (add-to-history 'grep-history command))))
       (when command
-	(let ((default-directory dir))
+	(let ((default-directory (or dir default-directory)))
 	  ;; Setting process-setup-function makes exit-message-function work
 	  ;; even when async processes aren't supported.
 	  (compilation-start (if (and grep-use-null-device null-device)

-- 
Juri Linkov
http://www.jurta.org/emacs/

bug#4052: marked as done (Emacs hangs with C-u C-u lrgep)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]


Your message dated Wed, 12 Aug 2009 23:58:55 +0300
with message-id <87zla4kauo.fsf@mail.jurta.org>
and subject line Re: bug#4052: Emacs hangs with C-u C-u lrgep
has caused the Emacs bug report #4052,
regarding Emacs hangs with C-u C-u lrgep
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4052: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4052
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3020 bytes --]

From: Juri Linkov <juri@jurta.org>
To: emacs-pretest-bug@gnu.org
Subject: Emacs hangs with C-u C-u lrgep
Date: Thu, 06 Aug 2009 01:17:43 +0300
Message-ID: <877hxh7u9c.fsf@mail.jurta.org>

Emacs hangs and every keystroke beeps with error messages like

  cd: Wrong type argument: stringp, nil
  file-remote-p: Wrong type argument: stringp, nil

because `C-u C-u M-x lrgep M-p RET' sets `default-directory' to nil.

I believe this is the correct fix:

Index: lisp/progmodes/grep.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/progmodes/grep.el,v
retrieving revision 1.102
diff -u -r1.102 grep.el
--- lisp/progmodes/grep.el	8 Jul 2009 14:24:00 -0000	1.102
+++ lisp/progmodes/grep.el	5 Aug 2009 22:17:36 -0000
@@ -827,7 +827,7 @@
 					  command nil nil 'grep-history))
 	    (add-to-history 'grep-history command))))
       (when command
-	(let ((default-directory dir))
+	(let ((default-directory (or dir default-directory)))
 	  ;; Setting process-setup-function makes exit-message-function work
 	  ;; even when async processes aren't supported.
 	  (compilation-start (if (and grep-use-null-device null-device)

-- 
Juri Linkov
http://www.jurta.org/emacs/


[-- Attachment #3: Type: message/rfc822, Size: 1774 bytes --]

From: Juri Linkov <juri@jurta.org>
To: 4052-done@emacsbugs.donarmstrong.com
Subject: Re: bug#4052: Emacs hangs with C-u C-u lrgep
Date: Wed, 12 Aug 2009 23:58:55 +0300
Message-ID: <87zla4kauo.fsf@mail.jurta.org>

> Emacs hangs and every keystroke beeps with error messages like
>
>   cd: Wrong type argument: stringp, nil
>   file-remote-p: Wrong type argument: stringp, nil
>
> because `C-u C-u M-x lrgep M-p RET' sets `default-directory' to nil.
>
> I believe this is the correct fix:

Fixed.

-- 
Juri Linkov
http://www.jurta.org/emacs/

bug#4052: marked as done (Emacs hangs with C-u C-u lrgep)

[Glenn Morris]

> Fixed.

Are you sure this is fixed?

emacs -Q
M-x lgrep RET foo RET RET RET
select grep buffer
C-u C-u M-x lgrep RET M-p RET

-> default-directory is now nil in the grep buffer (eg the scroll bars
vanish)

The very last clause in lgrep

(if (eq next-error-last-buffer (current-buffer))
        (setq default-directory dir))

is outside the let-binding that you changed.


Also, regardless of the above, does rgrep need the same kind of fix as lgrep?

bug#4052: marked as done (Emacs hangs with C-u C-u lrgep)

[Juri Linkov]

>> Fixed.
>
> Are you sure this is fixed?
>
> emacs -Q
> M-x lgrep RET foo RET RET RET
> select grep buffer
> C-u C-u M-x lgrep RET M-p RET
>
> -> default-directory is now nil in the grep buffer (eg the scroll bars
> vanish)
>
> The very last clause in lgrep
>
> (if (eq next-error-last-buffer (current-buffer))
>         (setq default-directory dir))
>
> is outside the let-binding that you changed.

Oops, I missed this case.  Now fixed by checking for a non-nil
readable directory at the beginning of this command.

> Also, regardless of the above, does rgrep need the same kind of fix as lgrep?

When used interactively, rgrep doesn't need the same fix because it uses
a slightly different logic.  But this is needed when rgrep is called
programmatically with an invalid `dir' argument.

`lgrep' and `rgrep' are still different in regard to their argument `dir'.
When `lgrep' is called programmatically with a non-nil `regexp' and `dir'
but with `files'=nil, then `lgrep' runs in the directory `dir'.  However,
when `rgrep' is called with the same arguments, it runs in the current
directory.  I'm not sure if this behavior should be the same for both.

-- 
Juri Linkov
http://www.jurta.org/emacs/