* bug#13563: tabulated-list-print-col nicer help-echo
@ 2013-01-26 21:14 Jonas Bernoulli
2013-01-27 2:53 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Jonas Bernoulli @ 2013-01-26 21:14 UTC (permalink / raw)
To: 13563
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
`tabulated-list-set-col' adds a help-echo property to the "labels" that
it inserts. With this patch this is done a bit differently:
* If the label already has a help-echo property then use that help-echo
instead of overriding it with a generic one. This allows displaying
additional information when it makes sense.
* Otherwise propertize as before but don't prefix the help-echo with the
column name. That information is not really useful.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: tabulated-list-print-col.patch --]
[-- Type: text/x-diff, Size: 1533 bytes --]
From bbe78adda05897c892ea3c3687912a4c056d6fe1 Mon Sep 17 00:00:00 2001
From: Jonas Bernoulli <jonas@bernoul.li>
Date: Sat, 26 Jan 2013 22:03:09 +0100
Subject: [PATCH] lisp/emacs-lisp/tabulated-list.el (tabulated-list-print-col):
don't prepend help-echo with column name, if help-echo is already predefined
don't replace it
---
lisp/emacs-lisp/tabulated-list.el | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el
index 94b3c15..13fc730 100644
--- a/lisp/emacs-lisp/tabulated-list.el
+++ b/lisp/emacs-lisp/tabulated-list.el
@@ -363,7 +363,6 @@ Return the column number after insertion."
(right-align (plist-get props :right-align))
(label (if (stringp col-desc) col-desc (car col-desc)))
(label-width (string-width label))
- (help-echo (concat (car format) ": " label))
(opoint (point))
(not-last-col (< (1+ n) (length tabulated-list-format))))
;; Truncate labels if necessary (except last column).
@@ -379,7 +378,9 @@ Return the column number after insertion."
(setq width (- width shift))
(setq x (+ x shift))))
(if (stringp col-desc)
- (insert (propertize label 'help-echo help-echo))
+ (insert (if (get-text-property 0 'help-echo label)
+ label
+ (propertize label 'help-echo label)))
(apply 'insert-text-button label (cdr col-desc)))
(let ((next-x (+ x pad-right width)))
;; No need to append any spaces if this is the last column.
--
1.8.0.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#13563: tabulated-list-print-col nicer help-echo
2013-01-26 21:14 bug#13563: tabulated-list-print-col nicer help-echo Jonas Bernoulli
@ 2013-01-27 2:53 ` Glenn Morris
2013-01-27 3:58 ` Jonas Bernoulli
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2013-01-27 2:53 UTC (permalink / raw)
To: Jonas Bernoulli; +Cc: 13563
Jonas Bernoulli wrote:
> `tabulated-list-set-col' adds a help-echo property to the "labels" that
> it inserts. With this patch this is done a bit differently:
>
> * If the label already has a help-echo property then use that help-echo
> instead of overriding it with a generic one. This allows displaying
> additional information when it makes sense.
Seems good.
> * Otherwise propertize as before but don't prefix the help-echo with the
> column name. That information is not really useful.
Not sure I agree. Eg in Buffer-menu mode, the prefix is useful IMO.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#13563: tabulated-list-print-col nicer help-echo
2013-01-27 2:53 ` Glenn Morris
@ 2013-01-27 3:58 ` Jonas Bernoulli
2013-02-16 2:52 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Jonas Bernoulli @ 2013-01-27 3:58 UTC (permalink / raw)
To: Glenn Morris; +Cc: 13563
Glenn Morris <rgm@gnu.org> writes:
> Jonas Bernoulli wrote:
>
>> `tabulated-list-set-col' adds a help-echo property to the "labels" that
>> it inserts. With this patch this is done a bit differently:
>>
>> * If the label already has a help-echo property then use that help-echo
>> instead of overriding it with a generic one. This allows displaying
>> additional information when it makes sense.
>
> Seems good.
>
>> * Otherwise propertize as before but don't prefix the help-echo with the
>> column name. That information is not really useful.
>
> Not sure I agree. Eg in Buffer-menu mode, the prefix is useful IMO.
I don't find it very useful since the same information is also displayed
in the header-line. But if the other change is merged then I can easily
work around this by explicitly setting the help-echo in my
Tabulated-List mode derived modes.
One other thing I forgot to include in this pull request: I think it
would make sense to set `x-stretch-cursor' to nil in
`tabulated-list-mode'. One shouldn't set that to t globally (I did for
a while, silly me) but it also does not hurt to actively override such a
setting in cases where it is known not to make any sense.
I don't care much about this (after all I have not enabled this globally
anymore:). Let me know what you think and I will create a new patch
with the second change above removed and this one included if desired.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#13563: tabulated-list-print-col nicer help-echo
2013-01-27 3:58 ` Jonas Bernoulli
@ 2013-02-16 2:52 ` Glenn Morris
0 siblings, 0 replies; 4+ messages in thread
From: Glenn Morris @ 2013-02-16 2:52 UTC (permalink / raw)
To: 13563-done
Version: 24.4
Jonas Bernoulli wrote:
>>> * If the label already has a help-echo property then use that help-echo
>>> instead of overriding it with a generic one. This allows displaying
>>> additional information when it makes sense.
I applied this part, thanks.
> One other thing I forgot to include in this pull request: I think it
> would make sense to set `x-stretch-cursor' to nil in
> `tabulated-list-mode'.
I don't see the point.
> One shouldn't set that to t globally (I did for a while, silly me) but
> it also does not hurt to actively override such a setting in cases
> where it is known not to make any sense.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-16 2:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-26 21:14 bug#13563: tabulated-list-print-col nicer help-echo Jonas Bernoulli
2013-01-27 2:53 ` Glenn Morris
2013-01-27 3:58 ` Jonas Bernoulli
2013-02-16 2:52 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).