* bug#16342: 24.3.50; RET during search inserts newline in PostScript mode
@ 2014-01-04 21:09 Markus Triska
2014-01-06 9:38 ` Juri Linkov
0 siblings, 1 reply; 4+ messages in thread
From: Markus Triska @ 2014-01-04 21:09 UTC (permalink / raw)
To: 16342
With "test.ps" which only contains the string "test", when I do:
$ emacs -Q test.ps
and then search for 'e' with:
C-s e
and then press RET to stop the search, it unexpectedly inserts a
newline. This does not happen for example in fundamental-mode.
In GNU Emacs 24.3.50.1 (x86_64-apple-darwin10.8.0, X toolkit, Xaw scroll bars)
of 2014-01-04 on mt-imac.local
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
Configured using:
`configure --with-xpm=no --with-tiff=no --with-jpeg=no --with-png=no
CFLAGS=-I/opt/local/include LDFLAGS=-L/opt/local/lib'
Important settings:
value of $LANG: en_US.UTF-8
locale-coding-system: utf-8-unix
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#16342: 24.3.50; RET during search inserts newline in PostScript mode
2014-01-04 21:09 bug#16342: 24.3.50; RET during search inserts newline in PostScript mode Markus Triska
@ 2014-01-06 9:38 ` Juri Linkov
2014-01-06 15:24 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Juri Linkov @ 2014-01-06 9:38 UTC (permalink / raw)
To: Markus Triska; +Cc: 16342
> With "test.ps" which only contains the string "test", when I do:
>
> $ emacs -Q test.ps
>
> and then search for 'e' with:
>
> C-s e
>
> and then press RET to stop the search, it unexpectedly inserts a
> newline. This does not happen for example in fundamental-mode.
This is because ps-mode.el binds [return] in addition to "\r":
(define-key ps-mode-map "\r" 'ps-mode-newline)
(define-key ps-mode-map [return] 'ps-mode-newline)
whereas isearch.el binds only "\r":
(define-key isearch-mode-map "\r" 'isearch-exit)
We could remove the [return] keybinding from ps-mode.el,
but there are many other places that bind [return] and [backspace]
in the Emacs source tree, external packages as well as in
countless user init files, so maybe better would be to add [return]
and [backspace] keybindings to isearch-mode-map in isearch.el.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#16342: 24.3.50; RET during search inserts newline in PostScript mode
2014-01-06 9:38 ` Juri Linkov
@ 2014-01-06 15:24 ` Stefan Monnier
2014-01-07 7:57 ` Juri Linkov
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2014-01-06 15:24 UTC (permalink / raw)
To: Juri Linkov; +Cc: 16342, Markus Triska
> countless user init files, so maybe better would be to add [return]
> and [backspace] keybindings to isearch-mode-map in isearch.el.
Agreed. Tho we should *also* remove the `return' binding in ps-mode.el.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#16342: 24.3.50; RET during search inserts newline in PostScript mode
2014-01-06 15:24 ` Stefan Monnier
@ 2014-01-07 7:57 ` Juri Linkov
0 siblings, 0 replies; 4+ messages in thread
From: Juri Linkov @ 2014-01-07 7:57 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Markus Triska, 16342-done
>> countless user init files, so maybe better would be to add [return]
>> and [backspace] keybindings to isearch-mode-map in isearch.el.
>
> Agreed. Tho we should *also* remove the `return' binding in ps-mode.el.
The revno 115903 fixes this in both isearch.el and ps-mode.el.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-07 7:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-04 21:09 bug#16342: 24.3.50; RET during search inserts newline in PostScript mode Markus Triska
2014-01-06 9:38 ` Juri Linkov
2014-01-06 15:24 ` Stefan Monnier
2014-01-07 7:57 ` Juri Linkov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).