bug#24477: 25.1; make-mode: should '$' have punctuation syntax?

bug#24477: 25.1; make-mode: should '$' have punctuation syntax?

[Dima Kogan]

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

This is a report from this emacs-devel post:

    https://lists.gnu.org/archive/html/emacs-devel/2016-09/msg00414.html

Making a bug report to keep track of this question. The original
message:

I've been working with Makefiles recently, and discovered that $ has
word syntax. This results in odd behaviors. For instance, if you have

    asdf-$(xyz)

in your buffer with the point on 'a', then commands like M-s . or
C-M-SPC select "asdf-$", which makes no sense. Shouldn't $ have
punctuation syntax (attached patch)? Am I missing something obvious
here?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: make-mode-punctuation-syntax-for-$.patch --]
[-- Type: text/x-diff, Size: 431 bytes --]

diff --git a/lisp/progmodes/make-mode.el b/lisp/progmodes/make-mode.el
index fb71420..2b4ed85 100644
--- a/lisp/progmodes/make-mode.el
+++ b/lisp/progmodes/make-mode.el
@@ -712,6 +712,7 @@ makefile-mode-syntax-table
     (modify-syntax-entry ?#  "<     " st)
     (modify-syntax-entry ?\n ">     " st)
     (modify-syntax-entry ?= "." st)
+    (modify-syntax-entry ?$ "." st)
     st)
   "Syntax table used in `makefile-mode'.")
 

bug#24477: 25.1; make-mode: should '$' have punctuation syntax?

[Eli Zaretskii]

> From: Dima Kogan <dima@secretsauce.net>
> Date: Mon, 19 Sep 2016 22:55:34 -0700
> 
> I've been working with Makefiles recently, and discovered that $ has
> word syntax. This results in odd behaviors. For instance, if you have
> 
>     asdf-$(xyz)
> 
> in your buffer with the point on 'a', then commands like M-s . or
> C-M-SPC select "asdf-$", which makes no sense. Shouldn't $ have
> punctuation syntax (attached patch)? Am I missing something obvious
> here?

Does your change still allow to type "C-x 4 a" in a line like this:

asdf-$(xyz) = FOO

and get a ChangeLog entry that references "asdf-$(xyz)"?

bug#24477: 25.1; make-mode: should '$' have punctuation syntax?

[Dima Kogan]

Eli Zaretskii <eliz@gnu.org> writes:

> Does your change still allow to type "C-x 4 a" in a line like this:
>
> asdf-$(xyz) = FOO
>
> and get a ChangeLog entry that references "asdf-$(xyz)"?

It appears to, yes.

bug#24477: 25.1; make-mode: should '$' have punctuation syntax?

[Noam Postavsky]

tags 24477 fixed
close 24477 27.1
quit

Dima Kogan <dima@secretsauce.net> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>> Does your change still allow to type "C-x 4 a" in a line like this:
>>
>> asdf-$(xyz) = FOO
>>
>> and get a ChangeLog entry that references "asdf-$(xyz)"?
>
> It appears to, yes.

`makefile-add-log-defun' doesn't consult the syntax table, it uses only
regexps (which don't use the \sSYNTAX construct, as far as I can tell).

Anyway, there seems to be no reason not to make this change, so I've
pushed it in master.

[1: 4c3cd27df9]: 2018-05-15 19:33:34 -0400
  Give '$' punctuation syntax in make-mode (Bug#24477)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4c3cd27df9c0735d907813a8c16a87acc54b9edc